| Message ID | 20210825165907.34026-13-philipp.tomsich@vrull.eu (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/riscv: Update QEmu for Zb[abcs] 1.0.0 | expand |
On Thu, Aug 26, 2021 at 3:14 AM Philipp Tomsich <philipp.tomsich@vrull.eu> wrote: > > The 1.0.0 version of Zbb does not contain pack/packu/packh. However, a > zext.h instruction is provided (built on pack/packh from pre-0.93 > draft-B) is available. > > This commit adds zext.h and removes the pack* instructions. > > Note that the encodings for zext.h are different between RV32 and > RV64, which is handled through REQUIRE_32BIT. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > > (no changes since v4) > > Changes in v4: > - Renamed RV32 variant to zext_h_32. > - Reordered trans_zext_h_{32,64} to be next to each other. > > Changes in v3: > - Moved zext.h-addition & pack*-removal to a separate commit. > > target/riscv/insn32.decode | 12 ++++--- > target/riscv/insn_trans/trans_rvb.c.inc | 46 ++++++++----------------- > target/riscv/translate.c | 40 --------------------- > 3 files changed, 21 insertions(+), 77 deletions(-) > > diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode > index 017eb50a49..abf794095a 100644 > --- a/target/riscv/insn32.decode > +++ b/target/riscv/insn32.decode > @@ -691,6 +691,9 @@ rori 01100 ............ 101 ..... 0010011 @sh > sext_b 011000 000100 ..... 001 ..... 0010011 @r2 > sext_h 011000 000101 ..... 001 ..... 0010011 @r2 > xnor 0100000 .......... 100 ..... 0110011 @r > +# The encoding for zext.h differs between RV32 and RV64. > +# zext_h_32 denotes the RV32 variant. > +zext_h_32 0000100 00000 ..... 100 ..... 0110011 @r2 > > # *** RV64 Zbb Standard Extension (in addition to RV32 Zbb) *** > clzw 0110000 00000 ..... 001 ..... 0011011 @r2 > @@ -703,15 +706,14 @@ rev8_64 011010 111000 ..... 101 ..... 0010011 @r2 > rolw 0110000 .......... 001 ..... 0111011 @r > roriw 0110000 .......... 101 ..... 0011011 @sh5 > rorw 0110000 .......... 101 ..... 0111011 @r > +# The encoding for zext.h differs between RV32 and RV64. > +# When executing on RV64, the encoding used in RV32 is an illegal > +# instruction, so we use different handler functions to differentiate. > +zext_h_64 0000100 00000 ..... 100 ..... 0111011 @r2 > > # *** RV32B Standard Extension *** > -pack 0000100 .......... 100 ..... 0110011 @r > -packu 0100100 .......... 100 ..... 0110011 @r > -packh 0000100 .......... 111 ..... 0110011 @r > > # *** RV64B Standard Extension (in addition to RV32B) *** > -packw 0000100 .......... 100 ..... 0111011 @r > -packuw 0100100 .......... 100 ..... 0111011 @r > > # *** RV32 Zbc Standard Extension *** > clmul 0000101 .......... 001 ..... 0110011 @r > diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c.inc > index b283c1dccf..4949fb6fdb 100644 > --- a/target/riscv/insn_trans/trans_rvb.c.inc > +++ b/target/riscv/insn_trans/trans_rvb.c.inc > @@ -78,24 +78,6 @@ static bool trans_xnor(DisasContext *ctx, arg_xnor *a) > return gen_arith(ctx, a, tcg_gen_eqv_tl); > } > > -static bool trans_pack(DisasContext *ctx, arg_pack *a) > -{ > - REQUIRE_EXT(ctx, RVB); > - return gen_arith(ctx, a, gen_pack); > -} > - > -static bool trans_packu(DisasContext *ctx, arg_packu *a) > -{ > - REQUIRE_EXT(ctx, RVB); > - return gen_arith(ctx, a, gen_packu); > -} > - > -static bool trans_packh(DisasContext *ctx, arg_packh *a) > -{ > - REQUIRE_EXT(ctx, RVB); > - return gen_arith(ctx, a, gen_packh); > -} > - > static bool trans_min(DisasContext *ctx, arg_min *a) > { > REQUIRE_ZBB(ctx); > @@ -236,6 +218,20 @@ static bool trans_orc_b(DisasContext *ctx, arg_orc_b *a) > return gen_unary(ctx, a, &gen_orc_b); > } > > +static bool trans_zext_h_32(DisasContext *ctx, arg_zext_h_32 *a) > +{ > + REQUIRE_32BIT(ctx); > + REQUIRE_ZBB(ctx); > + return gen_unary(ctx, a, &tcg_gen_ext16u_tl); > +} > + > +static bool trans_zext_h_64(DisasContext *ctx, arg_zext_h_64 *a) > +{ > + REQUIRE_64BIT(ctx); > + REQUIRE_ZBB(ctx); > + return gen_unary(ctx, a, &tcg_gen_ext16u_tl); > +} > + > > #define GEN_TRANS_SHADD(SHAMT) \ > static bool trans_sh##SHAMT##add(DisasContext *ctx, arg_sh##SHAMT##add *a) \ > @@ -269,20 +265,6 @@ static bool trans_cpopw(DisasContext *ctx, arg_cpopw *a) > return gen_unary(ctx, a, gen_cpopw); > } > > -static bool trans_packw(DisasContext *ctx, arg_packw *a) > -{ > - REQUIRE_64BIT(ctx); > - REQUIRE_EXT(ctx, RVB); > - return gen_arith(ctx, a, gen_packw); > -} > - > -static bool trans_packuw(DisasContext *ctx, arg_packuw *a) > -{ > - REQUIRE_64BIT(ctx); > - REQUIRE_EXT(ctx, RVB); > - return gen_arith(ctx, a, gen_packuw); > -} > - > static bool trans_rorw(DisasContext *ctx, arg_rorw *a) > { > REQUIRE_64BIT(ctx); > diff --git a/target/riscv/translate.c b/target/riscv/translate.c > index f16ac8bb1a..639f34b8f6 100644 > --- a/target/riscv/translate.c > +++ b/target/riscv/translate.c > @@ -536,29 +536,6 @@ static bool gen_arith_div_uw(DisasContext *ctx, arg_r *a, > return true; > } > > -static void gen_pack(TCGv ret, TCGv arg1, TCGv arg2) > -{ > - tcg_gen_deposit_tl(ret, arg1, arg2, > - TARGET_LONG_BITS / 2, > - TARGET_LONG_BITS / 2); > -} > - > -static void gen_packu(TCGv ret, TCGv arg1, TCGv arg2) > -{ > - TCGv t = tcg_temp_new(); > - tcg_gen_shri_tl(t, arg1, TARGET_LONG_BITS / 2); > - tcg_gen_deposit_tl(ret, arg2, t, 0, TARGET_LONG_BITS / 2); > - tcg_temp_free(t); > -} > - > -static void gen_packh(TCGv ret, TCGv arg1, TCGv arg2) > -{ > - TCGv t = tcg_temp_new(); > - tcg_gen_ext8u_tl(t, arg2); > - tcg_gen_deposit_tl(ret, arg1, t, 8, TARGET_LONG_BITS - 8); > - tcg_temp_free(t); > -} > - > static void gen_sbop_mask(TCGv ret, TCGv shamt) > { > tcg_gen_movi_tl(ret, 1); > @@ -635,23 +612,6 @@ static void gen_cpopw(TCGv ret, TCGv arg1) > tcg_gen_ctpop_tl(ret, arg1); > } > > -static void gen_packw(TCGv ret, TCGv arg1, TCGv arg2) > -{ > - TCGv t = tcg_temp_new(); > - tcg_gen_ext16s_tl(t, arg2); > - tcg_gen_deposit_tl(ret, arg1, t, 16, 48); > - tcg_temp_free(t); > -} > - > -static void gen_packuw(TCGv ret, TCGv arg1, TCGv arg2) > -{ > - TCGv t = tcg_temp_new(); > - tcg_gen_shri_tl(t, arg1, 16); > - tcg_gen_deposit_tl(ret, arg2, t, 0, 16); > - tcg_gen_ext32s_tl(ret, ret); > - tcg_temp_free(t); > -} > - > static void gen_rorw(TCGv ret, TCGv arg1, TCGv arg2) > { > TCGv_i32 t1 = tcg_temp_new_i32(); > -- > 2.25.1 > >
diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 017eb50a49..abf794095a 100644 --- a/target/riscv/insn32.decode +++ b/target/riscv/insn32.decode @@ -691,6 +691,9 @@ rori 01100 ............ 101 ..... 0010011 @sh sext_b 011000 000100 ..... 001 ..... 0010011 @r2 sext_h 011000 000101 ..... 001 ..... 0010011 @r2 xnor 0100000 .......... 100 ..... 0110011 @r +# The encoding for zext.h differs between RV32 and RV64. +# zext_h_32 denotes the RV32 variant. +zext_h_32 0000100 00000 ..... 100 ..... 0110011 @r2 # *** RV64 Zbb Standard Extension (in addition to RV32 Zbb) *** clzw 0110000 00000 ..... 001 ..... 0011011 @r2 @@ -703,15 +706,14 @@ rev8_64 011010 111000 ..... 101 ..... 0010011 @r2 rolw 0110000 .......... 001 ..... 0111011 @r roriw 0110000 .......... 101 ..... 0011011 @sh5 rorw 0110000 .......... 101 ..... 0111011 @r +# The encoding for zext.h differs between RV32 and RV64. +# When executing on RV64, the encoding used in RV32 is an illegal +# instruction, so we use different handler functions to differentiate. +zext_h_64 0000100 00000 ..... 100 ..... 0111011 @r2 # *** RV32B Standard Extension *** -pack 0000100 .......... 100 ..... 0110011 @r -packu 0100100 .......... 100 ..... 0110011 @r -packh 0000100 .......... 111 ..... 0110011 @r # *** RV64B Standard Extension (in addition to RV32B) *** -packw 0000100 .......... 100 ..... 0111011 @r -packuw 0100100 .......... 100 ..... 0111011 @r # *** RV32 Zbc Standard Extension *** clmul 0000101 .......... 001 ..... 0110011 @r diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c.inc index b283c1dccf..4949fb6fdb 100644 --- a/target/riscv/insn_trans/trans_rvb.c.inc +++ b/target/riscv/insn_trans/trans_rvb.c.inc @@ -78,24 +78,6 @@ static bool trans_xnor(DisasContext *ctx, arg_xnor *a) return gen_arith(ctx, a, tcg_gen_eqv_tl); } -static bool trans_pack(DisasContext *ctx, arg_pack *a) -{ - REQUIRE_EXT(ctx, RVB); - return gen_arith(ctx, a, gen_pack); -} - -static bool trans_packu(DisasContext *ctx, arg_packu *a) -{ - REQUIRE_EXT(ctx, RVB); - return gen_arith(ctx, a, gen_packu); -} - -static bool trans_packh(DisasContext *ctx, arg_packh *a) -{ - REQUIRE_EXT(ctx, RVB); - return gen_arith(ctx, a, gen_packh); -} - static bool trans_min(DisasContext *ctx, arg_min *a) { REQUIRE_ZBB(ctx); @@ -236,6 +218,20 @@ static bool trans_orc_b(DisasContext *ctx, arg_orc_b *a) return gen_unary(ctx, a, &gen_orc_b); } +static bool trans_zext_h_32(DisasContext *ctx, arg_zext_h_32 *a) +{ + REQUIRE_32BIT(ctx); + REQUIRE_ZBB(ctx); + return gen_unary(ctx, a, &tcg_gen_ext16u_tl); +} + +static bool trans_zext_h_64(DisasContext *ctx, arg_zext_h_64 *a) +{ + REQUIRE_64BIT(ctx); + REQUIRE_ZBB(ctx); + return gen_unary(ctx, a, &tcg_gen_ext16u_tl); +} + #define GEN_TRANS_SHADD(SHAMT) \ static bool trans_sh##SHAMT##add(DisasContext *ctx, arg_sh##SHAMT##add *a) \ @@ -269,20 +265,6 @@ static bool trans_cpopw(DisasContext *ctx, arg_cpopw *a) return gen_unary(ctx, a, gen_cpopw); } -static bool trans_packw(DisasContext *ctx, arg_packw *a) -{ - REQUIRE_64BIT(ctx); - REQUIRE_EXT(ctx, RVB); - return gen_arith(ctx, a, gen_packw); -} - -static bool trans_packuw(DisasContext *ctx, arg_packuw *a) -{ - REQUIRE_64BIT(ctx); - REQUIRE_EXT(ctx, RVB); - return gen_arith(ctx, a, gen_packuw); -} - static bool trans_rorw(DisasContext *ctx, arg_rorw *a) { REQUIRE_64BIT(ctx); diff --git a/target/riscv/translate.c b/target/riscv/translate.c index f16ac8bb1a..639f34b8f6 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -536,29 +536,6 @@ static bool gen_arith_div_uw(DisasContext *ctx, arg_r *a, return true; } -static void gen_pack(TCGv ret, TCGv arg1, TCGv arg2) -{ - tcg_gen_deposit_tl(ret, arg1, arg2, - TARGET_LONG_BITS / 2, - TARGET_LONG_BITS / 2); -} - -static void gen_packu(TCGv ret, TCGv arg1, TCGv arg2) -{ - TCGv t = tcg_temp_new(); - tcg_gen_shri_tl(t, arg1, TARGET_LONG_BITS / 2); - tcg_gen_deposit_tl(ret, arg2, t, 0, TARGET_LONG_BITS / 2); - tcg_temp_free(t); -} - -static void gen_packh(TCGv ret, TCGv arg1, TCGv arg2) -{ - TCGv t = tcg_temp_new(); - tcg_gen_ext8u_tl(t, arg2); - tcg_gen_deposit_tl(ret, arg1, t, 8, TARGET_LONG_BITS - 8); - tcg_temp_free(t); -} - static void gen_sbop_mask(TCGv ret, TCGv shamt) { tcg_gen_movi_tl(ret, 1); @@ -635,23 +612,6 @@ static void gen_cpopw(TCGv ret, TCGv arg1) tcg_gen_ctpop_tl(ret, arg1); } -static void gen_packw(TCGv ret, TCGv arg1, TCGv arg2) -{ - TCGv t = tcg_temp_new(); - tcg_gen_ext16s_tl(t, arg2); - tcg_gen_deposit_tl(ret, arg1, t, 16, 48); - tcg_temp_free(t); -} - -static void gen_packuw(TCGv ret, TCGv arg1, TCGv arg2) -{ - TCGv t = tcg_temp_new(); - tcg_gen_shri_tl(t, arg1, 16); - tcg_gen_deposit_tl(ret, arg2, t, 0, 16); - tcg_gen_ext32s_tl(ret, ret); - tcg_temp_free(t); -} - static void gen_rorw(TCGv ret, TCGv arg1, TCGv arg2) { TCGv_i32 t1 = tcg_temp_new_i32();