From patchwork Fri Sep 3 17:45:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 12474929 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E66C433EF for ; Fri, 3 Sep 2021 18:19:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38D1960FDC for ; Fri, 3 Sep 2021 18:19:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 38D1960FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMDmu-0003ft-Db for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 14:19:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMDI2-0001oa-UL for qemu-devel@nongnu.org; Fri, 03 Sep 2021 13:47:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMDI0-0002dD-4q for qemu-devel@nongnu.org; Fri, 03 Sep 2021 13:47:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630691263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dThNb9up0Udv82pZnAoy1KC7krZ7htoDQTtIaOGdW3Q=; b=GVlCAYzkWNRyAbFZ979ENUOuq4jsd7HhLHmG2OmZZ0lXtZ1qt1l+2H0MoSiZSs8SxHmKIG mt6NgnAeMcJppq0bPB0+0Nk8YpjLNSfRuqfiQJexCk2ZQXrbLzV+UPmpHYasSZRgx9cQw/ p/1YlT4FVz34pzpLIOb8sKgxQGR7QKg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-dxFtDy2_Ox6b27Y0iTWMhA-1; Fri, 03 Sep 2021 13:47:42 -0400 X-MC-Unique: dxFtDy2_Ox6b27Y0iTWMhA-1 Received: by mail-wr1-f69.google.com with SMTP id r11-20020a5d4e4b000000b001575c5ed4b4so1819441wrt.4 for ; Fri, 03 Sep 2021 10:47:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dThNb9up0Udv82pZnAoy1KC7krZ7htoDQTtIaOGdW3Q=; b=ak/ykR5NObbpbGkKBnsKKNHssgI0wkijBPHTRR+LllX9yvI3iT2SI6KL05mmfBXdfO xWFgKkLfWj91b/5QYaA0grrIX8pbe/5SZVNj2Wcn5yhgcmRTNPnASn7R8/+m/lUZZ3Qq orNGr60uxMySZnY6lJHpoFuJ2VwWn7sJgzW+rFP57EWT2NhPT1zYcxKisa5LCcXnzlIf U4b9Iome3+u3815F0C5ad4UI0dnX/pUPbori9G+CNMbLNNCv7K9mixf/DkhBZncI5N6I qzkjSUOLhw2HlDYb5qSRROXmdDbzWOL3KHlrFMb++CuSv1cSsg880Jv5jhI08LL12Ix6 uUZw== X-Gm-Message-State: AOAM532Nv2sRPHbBSoftbbqDTT+SRag9BS9OcpWRDnrDSCuZPd0bb+Xx 77ZF/8hdwwMvSMSIrzvgn/EtD9aDAZnXoQ1Wfp6lKAZV4TOpK1a9kRsWu+iqk3IFqXi3jrAjvR3 Zrycl0XgkXbEjJKJ+mPLmnW1RZwgAW+2SRKRoAs+98XoBLJ1yXol0Dmyik0HnxFvQ X-Received: by 2002:a7b:c3d0:: with SMTP id t16mr12139wmj.169.1630691261326; Fri, 03 Sep 2021 10:47:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2SysOKuoZRdoE1pkwTtmdJbw35VhU7Ev3gABzeU23tq/9p3cRCC2MEatHy61N2yQkO6oWlA== X-Received: by 2002:a7b:c3d0:: with SMTP id t16mr12089wmj.169.1630691260951; Fri, 03 Sep 2021 10:47:40 -0700 (PDT) Received: from x1w.. (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id t11sm38889wmi.23.2021.09.03.10.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 10:47:40 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 28/28] checkpatch: Do not allow deprecated g_memdup() Date: Fri, 3 Sep 2021 19:45:10 +0200 Message-Id: <20210903174510.751630-29-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210903174510.751630-1-philmd@redhat.com> References: <20210903174510.751630-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , Gerd Hoffmann , Eric Blake , qemu-block@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= , David Hildenbrand , Markus Armbruster , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , qemu-arm@nongnu.org, John Snow , David Gibson , Kevin Wolf , Vladimir Sementsov-Ogievskiy , "Daniel P . Berrange" , Hanna Reitz , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" g_memdup() is insecure and as been deprecated in GLib 2.68. QEMU provides the safely equivalent g_memdup2() wrapper. Do not allow more g_memdup() calls in the repository, provide a hint to use g_memdup2(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake --- scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index cb8eff233e0..5caa739db48 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2850,6 +2850,11 @@ sub process { WARN("consider using g_path_get_$1() in preference to g_strdup($1())\n" . $herecurr); } +# enforce g_memdup2() over g_memdup() + if ($line =~ /\bg_memdup\s*\(/) { + ERROR("use g_memdup2() instead of unsafe g_memdup()\n" . $herecurr); + } + # recommend qemu_strto* over strto* for numeric conversions if ($line =~ /\b(strto[^kd].*?)\s*\(/) { ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr);