diff mbox series

Fix virtio-net-pci* "vectors" compat

Message ID 20211103085234.15079-1-jean-louis@dupond.be (mailing list archive)
State New, archived
Headers show
Series Fix virtio-net-pci* "vectors" compat | expand

Commit Message

Jean-Louis Dupond Nov. 3, 2021, 8:52 a.m. UTC
From: Eduardo Habkost <ehabkost@redhat.com>

hw_compat_5_2 has an issue: it affects only "virtio-net-pci"
but not "virtio-net-pci-transitional" and
"virtio-net-pci-non-transitional".  The solution is to use the
"virtio-net-pci-base" type in compat_props.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Jean-Louis Dupond <jean-louis@dupond.be>
---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cornelia Huck Nov. 3, 2021, 9:36 a.m. UTC | #1
On Wed, Nov 03 2021, Jean-Louis Dupond <jean-louis@dupond.be> wrote:

> From: Eduardo Habkost <ehabkost@redhat.com>
>
> hw_compat_5_2 has an issue: it affects only "virtio-net-pci"
> but not "virtio-net-pci-transitional" and
> "virtio-net-pci-non-transitional".  The solution is to use the
> "virtio-net-pci-base" type in compat_props.
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
> Acked-by: Jean-Louis Dupond <jean-louis@dupond.be>

<process>This needs to have your s-o-b at the bottom, as you passed
Eduardo's patch on.</process>

> ---
>  hw/core/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>
diff mbox series

Patch

diff --git a/hw/core/machine.c b/hw/core/machine.c
index e24e3e27db..b17a15508c 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -56,7 +56,7 @@  GlobalProperty hw_compat_5_2[] = {
     { "ICH9-LPC", "smm-compat", "on"},
     { "PIIX4_PM", "smm-compat", "on"},
     { "virtio-blk-device", "report-discard-granularity", "off" },
-    { "virtio-net-pci", "vectors", "3"},
+    { "virtio-net-pci-base", "vectors", "3"},
 };
 const size_t hw_compat_5_2_len = G_N_ELEMENTS(hw_compat_5_2);