diff mbox series

[v2] Fix virtio-net-pci* "vectors" compat

Message ID 20211103113830.22283-1-jean-louis@dupond.be (mailing list archive)
State New, archived
Headers show
Series [v2] Fix virtio-net-pci* "vectors" compat | expand

Commit Message

Jean-Louis Dupond Nov. 3, 2021, 11:38 a.m. UTC
From: Eduardo Habkost <ehabkost@redhat.com>

hw_compat_5_2 has an issue: it affects only "virtio-net-pci"
but not "virtio-net-pci-transitional" and
"virtio-net-pci-non-transitional".  The solution is to use the
"virtio-net-pci-base" type in compat_props.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Jean-Louis Dupond <jean-louis@dupond.be>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/core/machine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Wang Nov. 4, 2021, 2:47 a.m. UTC | #1
On Wed, Nov 3, 2021 at 7:39 PM Jean-Louis Dupond <jean-louis@dupond.be> wrote:
>
> From: Eduardo Habkost <ehabkost@redhat.com>
>
> hw_compat_5_2 has an issue: it affects only "virtio-net-pci"
> but not "virtio-net-pci-transitional" and
> "virtio-net-pci-non-transitional".  The solution is to use the
> "virtio-net-pci-base" type in compat_props.
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1999141
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
> Acked-by: Jason Wang <jasowang@redhat.com>
> Acked-by: Jean-Louis Dupond <jean-louis@dupond.be>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Applied, and queue for -stable.

Thanks

> ---
>  hw/core/machine.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index e24e3e27db..b17a15508c 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -56,7 +56,7 @@ GlobalProperty hw_compat_5_2[] = {
>      { "ICH9-LPC", "smm-compat", "on"},
>      { "PIIX4_PM", "smm-compat", "on"},
>      { "virtio-blk-device", "report-discard-granularity", "off" },
> -    { "virtio-net-pci", "vectors", "3"},
> +    { "virtio-net-pci-base", "vectors", "3"},
>  };
>  const size_t hw_compat_5_2_len = G_N_ELEMENTS(hw_compat_5_2);
>
> --
> 2.33.1
>
diff mbox series

Patch

diff --git a/hw/core/machine.c b/hw/core/machine.c
index e24e3e27db..b17a15508c 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -56,7 +56,7 @@  GlobalProperty hw_compat_5_2[] = {
     { "ICH9-LPC", "smm-compat", "on"},
     { "PIIX4_PM", "smm-compat", "on"},
     { "virtio-blk-device", "report-discard-granularity", "off" },
-    { "virtio-net-pci", "vectors", "3"},
+    { "virtio-net-pci-base", "vectors", "3"},
 };
 const size_t hw_compat_5_2_len = G_N_ELEMENTS(hw_compat_5_2);