| Message ID | 20211224111148.345438-7-nikita.lapshin@virtuozzo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | migration: Add 'no-ram' and 'ram-only' cpabilities | expand |
24.12.2021 14:11, Nikita Lapshin wrote: > Use scripts/analyze-migration.py to split migration stream into > sections and analyze its output. > > Signed-off-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com> > --- > .../tests/migrate-ram-capabilities-test | 96 +++++++++++++++++++ > .../tests/migrate-ram-capabilities-test.out | 5 + Most probably we have to move it ti tests/avocado (look at tests/avocado/migration.py for example). > 2 files changed, 101 insertions(+) > create mode 100755 tests/qemu-iotests/tests/migrate-ram-capabilities-test > create mode 100644 tests/qemu-iotests/tests/migrate-ram-capabilities-test.out > > diff --git a/tests/qemu-iotests/tests/migrate-ram-capabilities-test b/tests/qemu-iotests/tests/migrate-ram-capabilities-test > new file mode 100755 > index 0000000000..917f888340 > --- /dev/null > +++ b/tests/qemu-iotests/tests/migrate-ram-capabilities-test > @@ -0,0 +1,96 @@ > +#!/usr/bin/env python3 > +# group: rw migration > +# > +# Tests for 'no-ram' and 'ram-only' capabilities > +# > +# Copyright (c) 2021 Virtuozzo International GmbH. > +# > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 2 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see <http://www.gnu.org/licenses/>. > +# > + > +import os > +import json > +import subprocess > +import iotests > + > +img = os.path.join(iotests.test_dir, 'disk.img') > + > +class TestRamCapabilities(iotests.QMPTestCase): > + def setUp(self): > + iotests.qemu_img('create', '-f', iotests.imgfmt, img, '10M') > + self.vm = iotests.VM() > + self.vm.launch() > + self.vm.qmp('migrate-set-capabilities', capabilities=[ > + { > + 'capability': 'events', > + 'state': True > + } > + ]) > + > + def tearDown(self): > + self.vm.shutdown() > + os.remove(img) > + > + def check_ram_only(self, output): > + str_json = output.decode() > + json_obj = json.loads(str_json) > + > + success = False > + for key in json_obj: > + self.assertTrue("ram" in key) > + success = True > + self.assertTrue(success) without explicit loop and extra variable: self.assertTrue(json_obj) # not empty self.assertTrue(all("ram" in key for key in json_obj)) > + > + def run_migration(self, capability, tmp_stream): > + self.vm.qmp('migrate-set-capabilities', capabilities=[ > + { > + 'capability': capability, > + 'state': True > + } > + ]) > + > + self.vm.qmp('migrate', uri='exec:cat>' + tmp_stream) > + > + while True: > + event = self.vm.event_wait('MIGRATION') > + > + if event['data']['status'] == 'completed': > + break > + > + > + def test_no_ram(self): > + with iotests.FilePath('tmp_stream') as tmp_stream: Hmm, you use same construction and same file-path for both tests. Let's instead just set the path variable at top (like you do for img) and remove it in tearDown(). > + self.run_migration('no-ram', tmp_stream) and you will not need the second argument of run_migration() > + output = subprocess.run( > + ['../../../scripts/analyze-migration.py', '-f', tmp_stream], > + stdout=subprocess.PIPE, > + stderr=subprocess.STDOUT, > + check=False).stdout > + > + self.assertFalse('ram' in output.decode()) > + > + def test_ram_only(self): > + with iotests.FilePath('tmp_stream') as tmp_stream: > + self.run_migration('ram-only', tmp_stream) > + output = subprocess.run( > + ['../../../scripts/analyze-migration.py', '-f', tmp_stream, > + '--ram-only'], > + stdout=subprocess.PIPE, > + stderr=subprocess.STDOUT, > + check=False).stdout > + > + self.check_ram_only(output) > + > +if __name__ == '__main__': > + iotests.main(supported_protocols=['file']) > diff --git a/tests/qemu-iotests/tests/migrate-ram-capabilities-test.out b/tests/qemu-iotests/tests/migrate-ram-capabilities-test.out > new file mode 100644 > index 0000000000..fbc63e62f8 > --- /dev/null > +++ b/tests/qemu-iotests/tests/migrate-ram-capabilities-test.out > @@ -0,0 +1,5 @@ > +.. > +---------------------------------------------------------------------- > +Ran 2 tests > + > +OK >
diff --git a/tests/qemu-iotests/tests/migrate-ram-capabilities-test b/tests/qemu-iotests/tests/migrate-ram-capabilities-test new file mode 100755 index 0000000000..917f888340 --- /dev/null +++ b/tests/qemu-iotests/tests/migrate-ram-capabilities-test @@ -0,0 +1,96 @@ +#!/usr/bin/env python3 +# group: rw migration +# +# Tests for 'no-ram' and 'ram-only' capabilities +# +# Copyright (c) 2021 Virtuozzo International GmbH. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. +# + +import os +import json +import subprocess +import iotests + +img = os.path.join(iotests.test_dir, 'disk.img') + +class TestRamCapabilities(iotests.QMPTestCase): + def setUp(self): + iotests.qemu_img('create', '-f', iotests.imgfmt, img, '10M') + self.vm = iotests.VM() + self.vm.launch() + self.vm.qmp('migrate-set-capabilities', capabilities=[ + { + 'capability': 'events', + 'state': True + } + ]) + + def tearDown(self): + self.vm.shutdown() + os.remove(img) + + def check_ram_only(self, output): + str_json = output.decode() + json_obj = json.loads(str_json) + + success = False + for key in json_obj: + self.assertTrue("ram" in key) + success = True + self.assertTrue(success) + + def run_migration(self, capability, tmp_stream): + self.vm.qmp('migrate-set-capabilities', capabilities=[ + { + 'capability': capability, + 'state': True + } + ]) + + self.vm.qmp('migrate', uri='exec:cat>' + tmp_stream) + + while True: + event = self.vm.event_wait('MIGRATION') + + if event['data']['status'] == 'completed': + break + + + def test_no_ram(self): + with iotests.FilePath('tmp_stream') as tmp_stream: + self.run_migration('no-ram', tmp_stream) + output = subprocess.run( + ['../../../scripts/analyze-migration.py', '-f', tmp_stream], + stdout=subprocess.PIPE, + stderr=subprocess.STDOUT, + check=False).stdout + + self.assertFalse('ram' in output.decode()) + + def test_ram_only(self): + with iotests.FilePath('tmp_stream') as tmp_stream: + self.run_migration('ram-only', tmp_stream) + output = subprocess.run( + ['../../../scripts/analyze-migration.py', '-f', tmp_stream, + '--ram-only'], + stdout=subprocess.PIPE, + stderr=subprocess.STDOUT, + check=False).stdout + + self.check_ram_only(output) + +if __name__ == '__main__': + iotests.main(supported_protocols=['file']) diff --git a/tests/qemu-iotests/tests/migrate-ram-capabilities-test.out b/tests/qemu-iotests/tests/migrate-ram-capabilities-test.out new file mode 100644 index 0000000000..fbc63e62f8 --- /dev/null +++ b/tests/qemu-iotests/tests/migrate-ram-capabilities-test.out @@ -0,0 +1,5 @@ +.. +---------------------------------------------------------------------- +Ran 2 tests + +OK
Use scripts/analyze-migration.py to split migration stream into sections and analyze its output. Signed-off-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com> --- .../tests/migrate-ram-capabilities-test | 96 +++++++++++++++++++ .../tests/migrate-ram-capabilities-test.out | 5 + 2 files changed, 101 insertions(+) create mode 100755 tests/qemu-iotests/tests/migrate-ram-capabilities-test create mode 100644 tests/qemu-iotests/tests/migrate-ram-capabilities-test.out