| Message ID | 20220328140604.41484-8-victortoso@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix some qapi examples and a TODO section | expand |
Victor Toso <victortoso@redhat.com> writes: > Example output lacks mandatory member @timestamp. Provide it. > > Example output is not properly formatted. Fixing it by: > - Adding '<-' to signalize it is receiving the data; > - Breaking lines similar to the other examples. > > Signed-off-by: Victor Toso <victortoso@redhat.com> > Reviewed-by: John Snow <jsnow@redhat.com> > --- > qapi/migration.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index 18e2610e88..092a63354b 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -1736,7 +1736,9 @@ > # Since: 4.2 > # > # Example: > -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } > +# <- { "event": "UNPLUG_PRIMARY", > +# "data": { "device-id": "hostdev0" }, > +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > # > ## > { 'event': 'UNPLUG_PRIMARY', Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/qapi/migration.json b/qapi/migration.json index 18e2610e88..092a63354b 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1736,7 +1736,9 @@ # Since: 4.2 # # Example: -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } +# <- { "event": "UNPLUG_PRIMARY", +# "data": { "device-id": "hostdev0" }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'UNPLUG_PRIMARY',