| Message ID | 20220422114332.374472-2-jcmvbkbc@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/xtensa: use tcg_constant_* where possible | expand |
On 4/22/22 04:43, Max Filippov wrote: > pc and w are allocated with tcg_const_i32 but not freed in > gen_window_check. Use tcg_constant_i32 for them both. > > Fixes: 2db59a76c421 ("target-xtensa: record available window in TB flags") > Signed-off-by: Max Filippov<jcmvbkbc@gmail.com> > --- > Changes v1->v2: > - also use tcg_constant_* for PC > > target/xtensa/translate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c index b1491ed625e5..9ecbbf172114 100644 --- a/target/xtensa/translate.c +++ b/target/xtensa/translate.c @@ -571,8 +571,8 @@ static bool gen_window_check(DisasContext *dc, uint32_t mask) unsigned r = 31 - clz32(mask); if (r / 4 > dc->window) { - TCGv_i32 pc = tcg_const_i32(dc->pc); - TCGv_i32 w = tcg_const_i32(r / 4); + TCGv_i32 pc = tcg_constant_i32(dc->pc); + TCGv_i32 w = tcg_constant_i32(r / 4); gen_helper_window_check(cpu_env, pc, w); dc->base.is_jmp = DISAS_NORETURN;
pc and w are allocated with tcg_const_i32 but not freed in gen_window_check. Use tcg_constant_i32 for them both. Fixes: 2db59a76c421 ("target-xtensa: record available window in TB flags") Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> --- Changes v1->v2: - also use tcg_constant_* for PC target/xtensa/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)