| Message ID | 20220427114057.36651-4-hreitz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "main-loop: Disable GLOBAL_STATE_CODE() assertions" | expand |
On Wed, Apr 27, 2022 at 01:40:56PM +0200, Hanna Reitz wrote: > This reverts commit b1c073490553f80594b903ceedfc7c1aef6b1b19. (We > wanted to do so once the 7.1 tree opens, which has happened. The issue > reported in https://gitlab.com/qemu-project/qemu/-/issues/945 should be > fixed by the preceding patches.) > > Signed-off-by: Hanna Reitz <hreitz@redhat.com> > --- > include/qemu/main-loop.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Eric Blake <eblake@redhat.com> [Here's hoping we don't have to re-disable it because it finds more bugs - but maximizing the soak time during development with it enabled is good]
diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h index d3750c8e76..89bd9edefb 100644 --- a/include/qemu/main-loop.h +++ b/include/qemu/main-loop.h @@ -284,8 +284,7 @@ bool qemu_in_main_thread(void); #else #define GLOBAL_STATE_CODE() \ do { \ - /* FIXME: Re-enable after 7.0 release */ \ - /* assert(qemu_in_main_thread()); */ \ + assert(qemu_in_main_thread()); \ } while (0) #endif /* CONFIG_COCOA */
This reverts commit b1c073490553f80594b903ceedfc7c1aef6b1b19. (We wanted to do so once the 7.1 tree opens, which has happened. The issue reported in https://gitlab.com/qemu-project/qemu/-/issues/945 should be fixed by the preceding patches.) Signed-off-by: Hanna Reitz <hreitz@redhat.com> --- include/qemu/main-loop.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)