| Message ID | 20220512154906.331399-1-kkostiuk@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | qga-vss: Add auto generated headers to dependencies | expand |
Hi On Thu, May 12, 2022 at 5:49 PM Konstantin Kostiuk <kkostiuk@redhat.com> wrote: > > Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com> > --- > qga/vss-win32/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build > index 26c5dd6e0e..9483ccd3b8 100644 > --- a/qga/vss-win32/meson.build > +++ b/qga/vss-win32/meson.build > @@ -7,7 +7,7 @@ link_args = cc.get_supported_link_arguments([ > > qga_vss = shared_module( > 'qga-vss', > - ['requester.cpp', 'provider.cpp', 'install.cpp'], > + ['requester.cpp', 'provider.cpp', 'install.cpp', genh], Looks fine, but could you tell which file was needed? (not qapi or trace files, I suppose, so what else?) > name_prefix: '', > cpp_args: ['-Wno-unknown-pragmas', '-Wno-delete-non-virtual-dtor', '-Wno-non-virtual-dtor'], > link_args: link_args, > -- > 2.25.1 >
Hi On Thu, May 12, 2022 at 8:00 PM Marc-André Lureau < marcandre.lureau@redhat.com> wrote: > Hi > > On Thu, May 12, 2022 at 5:49 PM Konstantin Kostiuk <kkostiuk@redhat.com> > wrote: > > > > Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com> > > --- > > qga/vss-win32/meson.build | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build > > index 26c5dd6e0e..9483ccd3b8 100644 > > --- a/qga/vss-win32/meson.build > > +++ b/qga/vss-win32/meson.build > > @@ -7,7 +7,7 @@ link_args = cc.get_supported_link_arguments([ > > > > qga_vss = shared_module( > > 'qga-vss', > > - ['requester.cpp', 'provider.cpp', 'install.cpp'], > > + ['requester.cpp', 'provider.cpp', 'install.cpp', genh], > > Looks fine, but could you tell which file was needed? (not qapi or > trace files, I suppose, so what else?) > During the CI build I got the next error [176/701] Compiling C++ object qga/vss-win32/qga-vss.dll.p/provider.cpp.obj FAILED: qga/vss-win32/qga-vss.dll.p/provider.cpp.obj fatal error: config-poison.h: No such file or directory [180/701] Generating config-poison.h with a custom command (wrapped by meson to capture output) > > > name_prefix: '', > > cpp_args: ['-Wno-unknown-pragmas', '-Wno-delete-non-virtual-dtor', > '-Wno-non-virtual-dtor'], > > link_args: link_args, > > -- > > 2.25.1 > > > >
Queued, thanks. Paolo
diff --git a/qga/vss-win32/meson.build b/qga/vss-win32/meson.build index 26c5dd6e0e..9483ccd3b8 100644 --- a/qga/vss-win32/meson.build +++ b/qga/vss-win32/meson.build @@ -7,7 +7,7 @@ link_args = cc.get_supported_link_arguments([ qga_vss = shared_module( 'qga-vss', - ['requester.cpp', 'provider.cpp', 'install.cpp'], + ['requester.cpp', 'provider.cpp', 'install.cpp', genh], name_prefix: '', cpp_args: ['-Wno-unknown-pragmas', '-Wno-delete-non-virtual-dtor', '-Wno-non-virtual-dtor'], link_args: link_args,
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com> --- qga/vss-win32/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)