| Message ID | 20220613084531.8086-2-helei.sig11@bytedance.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | crypto: Introduce ECDSA algorithm | expand |
On 13/6/22 10:45, Lei He wrote: > Introduce ECDSA related structures to qapi-crypto. > > Signed-off-by: lei he <helei.sig11@bytedance.com> > --- > qapi/crypto.json | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > +## > +# @QCryptoAkCipherOptionsECDSA: > +# > +# Specific parameters for ECDSA algorithm. > +# > +# @curve-id: QCryptoCurveId > +# > +# Since: 7.1 > +## > +{ 'struct': 'QCryptoAkCipherOptionsECDSA', > + 'data': { 'curve-id':'QCryptoCurveID' }} Missing an extra space after 'curve-id':, otherwise Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
On Mon, Jun 13, 2022 at 04:45:25PM +0800, Lei He wrote: > Introduce ECDSA related structures to qapi-crypto. > > Signed-off-by: lei he <helei.sig11@bytedance.com> > --- > qapi/crypto.json | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
diff --git a/qapi/crypto.json b/qapi/crypto.json index 653e6e3f3d..c2fcdaa13a 100644 --- a/qapi/crypto.json +++ b/qapi/crypto.json @@ -545,7 +545,7 @@ ## { 'enum': 'QCryptoAkCipherAlgorithm', 'prefix': 'QCRYPTO_AKCIPHER_ALG', - 'data': ['rsa']} + 'data': ['rsa', 'ecdsa']} ## # @QCryptoAkCipherKeyType: @@ -587,6 +587,29 @@ 'padding-alg': 'QCryptoRSAPaddingAlgorithm'}} ## +# @QCryptoCurveID: +# +# The known curved for ECC algorithms. +# +# Since: 7.1 +## +{ 'enum': 'QCryptoCurveID', + 'prefix': 'QCRYPTO_CURVE_ID', + 'data': ['nist-p192', 'nist-p256', 'nist-p384']} + +## +# @QCryptoAkCipherOptionsECDSA: +# +# Specific parameters for ECDSA algorithm. +# +# @curve-id: QCryptoCurveId +# +# Since: 7.1 +## +{ 'struct': 'QCryptoAkCipherOptionsECDSA', + 'data': { 'curve-id':'QCryptoCurveID' }} + +## # @QCryptoAkCipherOptions: # # The options that are available for all asymmetric key algorithms @@ -597,4 +620,5 @@ { 'union': 'QCryptoAkCipherOptions', 'base': { 'alg': 'QCryptoAkCipherAlgorithm' }, 'discriminator': 'alg', - 'data': { 'rsa': 'QCryptoAkCipherOptionsRSA' }} + 'data': { 'rsa': 'QCryptoAkCipherOptionsRSA', + 'ecdsa': 'QCryptoAkCipherOptionsECDSA' }}
Introduce ECDSA related structures to qapi-crypto. Signed-off-by: lei he <helei.sig11@bytedance.com> --- qapi/crypto.json | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-)