diff mbox series

iotests/297: Have mypy ignore unused ignores

Message ID 20220621092536.19837-1-hreitz@redhat.com (mailing list archive)
State New, archived
Headers show
Series iotests/297: Have mypy ignore unused ignores | expand

Commit Message

Hanna Czenczek June 21, 2022, 9:25 a.m. UTC
e7874a50ff3f5b20fb46f36958ad ("python: update for mypy 0.950") has added
`warn_unused_ignores = False` to python/setup.cfg, to be able to keep
compatibility with both pre- and post-0.950 mypy versions.

The iotests' mypy.ini needs the same, or 297 will fail (on both pre- and
post-0.950 mypy, as far as I can tell; just for different `ignore`
lines).

Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---
 tests/qemu-iotests/mypy.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

John Snow June 21, 2022, 3:53 p.m. UTC | #1
On Tue, Jun 21, 2022, 5:25 AM Hanna Reitz <hreitz@redhat.com> wrote:

> e7874a50ff3f5b20fb46f36958ad ("python: update for mypy 0.950") has added
> `warn_unused_ignores = False` to python/setup.cfg, to be able to keep
> compatibility with both pre- and post-0.950 mypy versions.
>
> The iotests' mypy.ini needs the same, or 297 will fail (on both pre- and
> post-0.950 mypy, as far as I can tell; just for different `ignore`
> lines).
>
> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
> ---
>  tests/qemu-iotests/mypy.ini | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/mypy.ini b/tests/qemu-iotests/mypy.ini
> index 4c0339f558..d66ffc2e3c 100644
> --- a/tests/qemu-iotests/mypy.ini
> +++ b/tests/qemu-iotests/mypy.ini
> @@ -9,4 +9,4 @@ no_implicit_optional = True
>  scripts_are_modules = True
>  warn_redundant_casts = True
>  warn_unused_configs = True
> -warn_unused_ignores = True
> +warn_unused_ignores = False
> --
> 2.35.3
>

I'm away for the week, but:

Acked-By: John Snow <jsnow@redhat.com>


diff mbox series

Patch

diff --git a/tests/qemu-iotests/mypy.ini b/tests/qemu-iotests/mypy.ini
index 4c0339f558..d66ffc2e3c 100644
--- a/tests/qemu-iotests/mypy.ini
+++ b/tests/qemu-iotests/mypy.ini
@@ -9,4 +9,4 @@  no_implicit_optional = True
 scripts_are_modules = True
 warn_redundant_casts = True
 warn_unused_configs = True
-warn_unused_ignores = True
+warn_unused_ignores = False