From patchwork Fri Jun 24 14:50:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Akihiko Odaki X-Patchwork-Id: 12894734 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89802C43334 for ; Fri, 24 Jun 2022 14:53:14 +0000 (UTC) Received: from localhost ([::1]:50692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4kgL-0004y4-Mb for qemu-devel@archiver.kernel.org; Fri, 24 Jun 2022 10:53:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4ke9-0001sT-H7 for qemu-devel@nongnu.org; Fri, 24 Jun 2022 10:50:57 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:44943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4ke7-0000Sx-90 for qemu-devel@nongnu.org; Fri, 24 Jun 2022 10:50:56 -0400 Received: by mail-pf1-x42e.google.com with SMTP id 65so2739341pfw.11 for ; Fri, 24 Jun 2022 07:50:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pv04gkshDxNH3B9RohTSkXVFQo/HTk4n+LV9OX7qnAM=; b=eg39UZu2ujd5z642KgBvJ2F9743xs+xlI8g/uH8F+ZN0N996NRD2+8EZ+V83CAD34R Wf4fR8oUVKDearWQ0hiKrNeaEbpiEI6g5gTtZHViwBwypQUmxTdk19YY29gZDPRwcuND Kg8vCTY4GAYiJeErat2GZqxSkAgF8lS9oPIFpVX4+Fg+6YPnTsUpdfbGmSYrthNovYGp HZjjAnhCwJFE01LHY2lWOyhV9z9iCyEar04Cj6ekkkIoINMu/ilvVmKnLTa3sGJxxuiP ClLXdlLbUd7GQLgL+hMDODYqc5gExalR1nHaLKgiWbBSUgqOrYVZsrglzCGrHGd83rjA UttQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pv04gkshDxNH3B9RohTSkXVFQo/HTk4n+LV9OX7qnAM=; b=1HK3HWan5sMxn443VqXuBJ7qsdDTUmaaVgSNLNmT1Z+O2UXfGo6hU3FaYPXPpQU+5u IMR2Wmq+ulSDhZtM9TsFLYEDbs9RXM5bQJbx6DsG2Pq4vcsCptkaOJVXXza7flKc5iCC Wnpb1OqVcC8aDPRJSjRQeCfRTbndwGmIYeCyXEel9QY/qrU1mOfsy4SZgr91G0fgNpHr j6U+27OvAgKW2YByJmWoL9R94Aj+HSa/4DvpLPQdWemJmoOMacuMenoe0Ziw70tWnH4P pdv8Dn04VeG+9iV3JjGTLwoS0NwpBR5Bvh+ybXok2y5bVAJiipQ+0FUZcR8Ed/pgmv9S kAlQ== X-Gm-Message-State: AJIora8XB5Wtgs/3h7Mom5fNwD6I4l9N4WlcmBfG4BlhugdXWR3dtXnO mNLbQ9yqTwhxbOGlCjx7kkI= X-Google-Smtp-Source: AGRyM1ul2l/zPE1O4ZDzWNPghfGk5tx8Qbq1SMrpcGpQ0PC2xi2rOjnBPGOvod5OHbAF5eM5rwewxg== X-Received: by 2002:a05:6a00:1941:b0:50d:807d:530b with SMTP id s1-20020a056a00194100b0050d807d530bmr46343699pfk.17.1656082253625; Fri, 24 Jun 2022 07:50:53 -0700 (PDT) Received: from localhost.localdomain ([2400:4050:c360:8200:80ba:2fd0:a1d1:c891]) by smtp.gmail.com with ESMTPSA id 20-20020a170902ee5400b001690a7df347sm1921125plo.96.2022.06.24.07.50.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 24 Jun 2022 07:50:52 -0700 (PDT) From: Akihiko Odaki To: Cc: Peter Maydell , Jason Wang , qemu-devel@nongnu.org, Programmingkid , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Gerd Hoffmann , =?utf-8?q?Daniel_P_=2E_Berrang=C3=A9?= , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= , Thomas Huth , John Snow , Cleber Rosa , Stefan Weil , Akihiko Odaki Subject: [PATCH v8 1/4] tests/vm: do not specify -bios option Date: Fri, 24 Jun 2022 23:50:36 +0900 Message-Id: <20220624145039.49929-2-akihiko.odaki@gmail.com> X-Mailer: git-send-email 2.32.1 (Apple Git-133) In-Reply-To: <20220624145039.49929-1-akihiko.odaki@gmail.com> References: <20220624145039.49929-1-akihiko.odaki@gmail.com> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=akihiko.odaki@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Paolo Bonzini When running from the build tree, the executable is able to find the BIOS on its own; when running from the source tree, a firmware blob should already be installed and there is no guarantee that the one in the source tree works with the QEMU that is being used for the installation. Just remove the -bios option, since it is unnecessary and in fact there are other x86 VM tests that do not bother specifying it. Signed-off-by: Paolo Bonzini Reviewed-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Signed-off-by: Akihiko Odaki Message-Id: <20220616083025.116902-1-pbonzini@redhat.com> --- tests/vm/fedora | 1 - tests/vm/freebsd | 1 - tests/vm/netbsd | 1 - tests/vm/openbsd | 1 - 4 files changed, 4 deletions(-) diff --git a/tests/vm/fedora b/tests/vm/fedora index 92b78d6e2c9..12eca919a08 100755 --- a/tests/vm/fedora +++ b/tests/vm/fedora @@ -79,7 +79,6 @@ class FedoraVM(basevm.BaseVM): self.exec_qemu_img("create", "-f", "qcow2", img_tmp, self.size) self.print_step("Booting installer") self.boot(img_tmp, extra_args = [ - "-bios", "pc-bios/bios-256k.bin", "-machine", "graphics=off", "-device", "VGA", "-cdrom", iso diff --git a/tests/vm/freebsd b/tests/vm/freebsd index 805db759d67..cd1fabde523 100755 --- a/tests/vm/freebsd +++ b/tests/vm/freebsd @@ -95,7 +95,6 @@ class FreeBSDVM(basevm.BaseVM): self.print_step("Booting installer") self.boot(img_tmp, extra_args = [ - "-bios", "pc-bios/bios-256k.bin", "-machine", "graphics=off", "-device", "VGA", "-cdrom", iso diff --git a/tests/vm/netbsd b/tests/vm/netbsd index 45aa9a7fda7..aa883ec23c9 100755 --- a/tests/vm/netbsd +++ b/tests/vm/netbsd @@ -86,7 +86,6 @@ class NetBSDVM(basevm.BaseVM): self.print_step("Booting installer") self.boot(img_tmp, extra_args = [ - "-bios", "pc-bios/bios-256k.bin", "-machine", "graphics=off", "-cdrom", iso ]) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 13c82542140..6f1b6f5b98a 100755 --- a/tests/vm/openbsd +++ b/tests/vm/openbsd @@ -82,7 +82,6 @@ class OpenBSDVM(basevm.BaseVM): self.print_step("Booting installer") self.boot(img_tmp, extra_args = [ - "-bios", "pc-bios/bios-256k.bin", "-machine", "graphics=off", "-device", "VGA", "-cdrom", iso