[v2,05/39] tcg: Avoid using hardcoded /tmp

Commit Message

Bin Meng Sept. 20, 2022, 10:31 a.m. UTC

From: Bin Meng <[e-mail]>

Use g_get_tmp_dir() to get the directory to use for temporary files.

Signed-off-by: Bin Meng <[e-mail]>
Reviewed-by: Marc-André Lureau <[e-mail]>
---

Changes in v2:
- Use g_autofree to declare the variable

 tcg/tcg.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Alex Bennée Sept. 23, 2022, 4:20 p.m. UTC | #1

Bin Meng <[e-mail]> writes:

> From: Bin Meng <[e-mail]>
>
> Use g_get_tmp_dir() to get the directory to use for temporary files.
>
> Signed-off-by: Bin Meng <[e-mail]>
> Reviewed-by: Marc-André Lureau <[e-mail]>

Reviewed-by: Alex Bennée <[e-mail]>

Patch

diff --git a/tcg/tcg.c b/tcg/tcg.c
index 0f9cfe96f2..8847053176 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -4729,7 +4729,8 @@  static void tcg_register_jit_int(const void *buf_ptr, size_t buf_size,
     /* Enable this block to be able to debug the ELF image file creation.
        One can use readelf, objdump, or other inspection utilities.  */
     {
-        FILE *f = fopen("/tmp/qemu.jit", "w+b");
+        g_autofree char *jit = g_strdup_printf("%s/qemu.jit", g_get_tmp_dir());
+        FILE *f = fopen(jit, "w+b");
         if (f) {
             if (fwrite(img, img_size, 1, f) != img_size) {
                 /* Avoid stupid unused return value warning for fwrite.  */