| Message ID | 20220923183640.8314-3-vr_qemu@t-online.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | audio: misc. improvements and bug fixes | expand |
On Fri, Sep 23, 2022 at 10:45 PM Volker Rümelin <vr_qemu@t-online.de> wrote: > Run the downstream playback queue even if the emulated audio > device didn't write new samples. There still may be buffered > audio samples downstream. > > This is for the -audiodev out.mixing-engine=off case. Commit > a8a98cfd42 ("audio: run downstream playback queue uncondition- > ally") fixed the out.mixing-engine=on case. > > Signed-off-by: Volker Rümelin <vr_qemu@t-online.de> > lgtm Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > audio/audio.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/audio/audio.c b/audio/audio.c > index 343786243d..9e55834909 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -1143,6 +1143,10 @@ static void audio_run_out (AudioState *s) > hw_free * sw->info.bytes_per_frame); > } > > + if (hw->pcm_ops->run_buffer_out) { > + hw->pcm_ops->run_buffer_out(hw); > + } > + > continue; > } > > @@ -1501,10 +1505,6 @@ size_t audio_generic_write(HWVoiceOut *hw, void > *buf, size_t size) > } > } > > - if (hw->pcm_ops->run_buffer_out) { > - hw->pcm_ops->run_buffer_out(hw); > - } > - > return total; > } > > -- > 2.35.3 > > >
diff --git a/audio/audio.c b/audio/audio.c index 343786243d..9e55834909 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1143,6 +1143,10 @@ static void audio_run_out (AudioState *s) hw_free * sw->info.bytes_per_frame); } + if (hw->pcm_ops->run_buffer_out) { + hw->pcm_ops->run_buffer_out(hw); + } + continue; } @@ -1501,10 +1505,6 @@ size_t audio_generic_write(HWVoiceOut *hw, void *buf, size_t size) } } - if (hw->pcm_ops->run_buffer_out) { - hw->pcm_ops->run_buffer_out(hw); - } - return total; }
Run the downstream playback queue even if the emulated audio device didn't write new samples. There still may be buffered audio samples downstream. This is for the -audiodev out.mixing-engine=off case. Commit a8a98cfd42 ("audio: run downstream playback queue uncondition- ally") fixed the out.mixing-engine=on case. Signed-off-by: Volker Rümelin <vr_qemu@t-online.de> --- audio/audio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)