diff mbox series

[v2,3/5] thread: de-const qemu_spin_destroy

Message ID 20230109224954.161672-4-cota@braap.org (mailing list archive)
State New, archived
Headers show
Series tsan fixes | expand

Commit Message

Emilio Cota Jan. 9, 2023, 10:49 p.m. UTC 
Signed-off-by: Emilio Cota <cota@braap.org>
---
 include/qemu/thread.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Alex Bennée Jan. 10, 2023, 9:09 a.m. UTC | #1 
Emilio Cota <cota@braap.org> writes:

> Signed-off-by: Emilio Cota <cota@braap.org>
> ---
>  include/qemu/thread.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/qemu/thread.h b/include/qemu/thread.h
> index 7c6703bce3..7841084199 100644
> --- a/include/qemu/thread.h
> +++ b/include/qemu/thread.h
> @@ -237,11 +237,10 @@ static inline void qemu_spin_init(QemuSpin *spin)
>  #endif
>  }
>  
> -/* const parameter because the only purpose here is the TSAN annotation */
> -static inline void qemu_spin_destroy(const QemuSpin *spin)
> +static inline void qemu_spin_destroy(QemuSpin *spin)
>  {
>  #ifdef CONFIG_TSAN
> -    __tsan_mutex_destroy((void *)spin, __tsan_mutex_not_static);
> +    __tsan_mutex_destroy(spin, __tsan_mutex_not_static);
>  #endif
>  }

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
diff mbox series

Patch

diff --git a/include/qemu/thread.h b/include/qemu/thread.h
index 7c6703bce3..7841084199 100644
--- a/include/qemu/thread.h
+++ b/include/qemu/thread.h
@@ -237,11 +237,10 @@  static inline void qemu_spin_init(QemuSpin *spin)
 #endif
 }
 
-/* const parameter because the only purpose here is the TSAN annotation */
-static inline void qemu_spin_destroy(const QemuSpin *spin)
+static inline void qemu_spin_destroy(QemuSpin *spin)
 {
 #ifdef CONFIG_TSAN
-    __tsan_mutex_destroy((void *)spin, __tsan_mutex_not_static);
+    __tsan_mutex_destroy(spin, __tsan_mutex_not_static);
 #endif
 }