[PULL,17/59] target/riscv: Indent fixes in cpu.c

Message ID	20230303083740.12817-18-palmer@rivosinc.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> Subject: [PULL 17/59] target/riscv: Indent fixes in cpu.c Date: Fri, 3 Mar 2023 00:36:58 -0800 Message-Id: <20230303083740.12817-18-palmer@rivosinc.com> In-Reply-To: <20230303083740.12817-1-palmer@rivosinc.com> References: <20230303083740.12817-1-palmer@rivosinc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Weiwei Li <liweiwei@iscas.ac.cn>, Junqiang Wang <wangjunqiang@iscas.ac.cn>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Palmer Dabbelt <palmer@rivosinc.com> From: Palmer Dabbelt <palmer@rivosinc.com> To: Peter Maydell <peter.maydell@linaro.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=palmer@rivosinc.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Series	[PULL,01/59] target/riscv: introduce riscv_cpu_cfg() \| expand [PULL,01/59] target/riscv: introduce riscv_cpu_cfg() [PULL,02/59] target/riscv: do not mask unsupported QEMU extensions in write_misa() [PULL,03/59] target/riscv: allow MISA writes as experimental [PULL,04/59] target/riscv: remove RISCV_FEATURE_DEBUG [PULL,05/59] target/riscv/cpu.c: error out if EPMP is enabled without PMP [PULL,06/59] target/riscv: remove RISCV_FEATURE_EPMP [PULL,07/59] target/riscv: remove RISCV_FEATURE_PMP [PULL,08/59] hw/riscv/virt.c: do not use RISCV_FEATURE_MMU in create_fdt_socket_cpus() [PULL,09/59] target/riscv: remove RISCV_FEATURE_MMU [PULL,10/59] target/riscv/cpu: remove CPUArchState::features and friends [PULL,11/59] target/riscv: Fix the relationship between Zfhmin and Zfh [PULL,12/59] target/riscv: Fix the relationship between Zhinxmin and Zhinx [PULL,13/59] target/riscv: Simplify the check for Zfhmin and Zhinxmin [PULL,14/59] target/riscv: Add cfg properties for Zv* extensions [PULL,15/59] target/riscv: Fix relationship between V, Zve, F and D [PULL,16/59] target/riscv: Add property check for Zvfh{min} extensions [PULL,17/59] target/riscv: Indent fixes in cpu.c [PULL,18/59] target/riscv: Simplify check for Zve32f and Zve64f [PULL,19/59] target/riscv: Replace check for F/D to Zve32f/Zve64d in trans_rvv.c.inc [PULL,20/59] target/riscv: Remove redundunt check for zve32f and zve64f [PULL,21/59] target/riscv: Add support for Zvfh/zvfhmin extensions [PULL,22/59] target/riscv: Fix check for vector load/store instructions when EEW=64 [PULL,23/59] target/riscv: Simplify check for EEW = 64 in trans_rvv.c.inc [PULL,24/59] target/riscv: Expose properties for Zv extensions [PULL,25/59] target/riscv: gdbstub: Check priv spec version before reporting CSR [PULL,26/59] target/riscv: Add some comments to clarify the priority policy of riscv_csrrw_check() [PULL,27/59] target/riscv: Use g_assert() for the predicate() NULL check [PULL,28/59] target/riscv: gdbstub: Minor change for better readability [PULL,29/59] target/riscv: gdbstub: Do not generate CSR XML if Zicsr is disabled [PULL,30/59] target/riscv: Coding style fixes in csr.c [PULL,31/59] target/riscv: Use 'bool' type for read_only [PULL,32/59] target/riscv: Simplify {read, write}_pmpcfg() a little bit [PULL,33/59] target/riscv: Simplify getting RISCVCPU pointer from env [PULL,34/59] target/riscv: Avoid reporting odd-numbered pmpcfgX in the CSR XML for RV64 [PULL,35/59] target/riscv: gdbstub: Turn on debugger mode before calling CSR predicate() [PULL,36/59] target/riscv: gdbstub: Drop the vector CSRs in riscv-vector.xml [PULL,37/59] target/riscv: Allow debugger to access user timer and counter CSRs [PULL,38/59] target/riscv: Allow debugger to access seed CSR [PULL,39/59] target/riscv: Allow debugger to access {h, s}stateen CSRs [PULL,40/59] target/riscv: Allow debugger to access sstc CSRs [PULL,41/59] target/riscv: Drop priv level check in mseccfg predicate() [PULL,42/59] target/riscv: Group all predicate() routines together [PULL,43/59] target/riscv: Fix checking of whether instruciton at 'pc_next' spans pages [PULL,44/59] RISC-V: XTheadMemPair: Remove register restrictions for store-pair [PULL,45/59] target/riscv: Add support for Zicond extension [PULL,46/59] hw/riscv: Skip re-generating DT nodes for a given DTB [PULL,47/59] hw/riscv: Move the dtb load bits outside of create_fdt() [PULL,48/59] target/riscv: Fix the relationship between menvcfg.PBMTE/STCE and Svpbmt/Sstc extensio… [PULL,49/59] target/riscv: Fix the relationship of PBMTE/STCE fields between menvcfg and henvcfg [PULL,50/59] target/riscv: Add csr support for svadu [PULL,51/59] target/riscv: Add envcfg.PBMTE related check in address translation [PULL,52/59] target/riscv: Add envcfg.HADE related check in address translation [PULL,53/59] target/riscv: Export Svadu property [PULL,54/59] target/riscv/csr.c: use env_archcpu() in ctr() [PULL,55/59] target/riscv/csr.c: simplify mctr() [PULL,56/59] target/riscv/csr.c: use riscv_cpu_cfg() to avoid env_cpu() pointers [PULL,57/59] target/riscv/csr.c: avoid env_archcpu() usages when reading RISCVCPUConfig [PULL,58/59] target/riscv/vector_helper.c: create vext_set_tail_elems_1s() [PULL,59/59] target/riscv/vector_helper.c: avoid env_archcpu() when reading RISCVCPUConfig

Message ID

20230303083740.12817-18-palmer@rivosinc.com (mailing list archive)

State

New, archived

Headers

Subject: [PULL 17/59] target/riscv: Indent fixes in cpu.c
Date: Fri,  3 Mar 2023 00:36:58 -0800
Message-Id: <20230303083740.12817-18-palmer@rivosinc.com>
In-Reply-To: <20230303083740.12817-1-palmer@rivosinc.com>
References: <20230303083740.12817-1-palmer@rivosinc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Cc: qemu-riscv@nongnu.org,          qemu-devel@nongnu.org,
 Weiwei Li <liweiwei@iscas.ac.cn>, Junqiang Wang <wangjunqiang@iscas.ac.cn>,
 Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
 Palmer Dabbelt <palmer@rivosinc.com>
From: Palmer Dabbelt <palmer@rivosinc.com>
To: Peter Maydell <peter.maydell@linaro.org>
Received-SPF: pass client-ip=2607:f8b0:4864:20::42c;
 envelope-from=palmer@rivosinc.com; helo=mail-pf1-x42c.google.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
 <mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org

Series

[PULL,01/59] target/riscv: introduce riscv_cpu_cfg() | expand

Commit Message

Palmer Dabbelt March 3, 2023, 8:36 a.m. UTC

From: Weiwei Li <liweiwei@iscas.ac.cn>

Fix indent problems in vector related check.

Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Message-ID: <20230215020539.4788-8-liweiwei@iscas.ac.cn>
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
 target/riscv/cpu.c | 44 ++++++++++++++++++++++----------------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 49ac368662..9b8747ab15 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -798,7 +798,7 @@  static void riscv_cpu_validate_set_extensions(RISCVCPU *cpu, Error **errp)
         }
         if (cpu->cfg.ext_f) {
             error_setg(errp,
-                "Zfinx cannot be supported together with F extension");
+                       "Zfinx cannot be supported together with F extension");
             return;
         }
     }
@@ -861,40 +861,40 @@  static void riscv_cpu_validate_set_extensions(RISCVCPU *cpu, Error **errp)
         ext |= RVV;
         if (!is_power_of_2(cpu->cfg.vlen)) {
             error_setg(errp,
-                    "Vector extension VLEN must be power of 2");
+                       "Vector extension VLEN must be power of 2");
             return;
         }
         if (cpu->cfg.vlen > RV_VLEN_MAX || cpu->cfg.vlen < 128) {
             error_setg(errp,
-                    "Vector extension implementation only supports VLEN "
-                    "in the range [128, %d]", RV_VLEN_MAX);
+                       "Vector extension implementation only supports VLEN "
+                       "in the range [128, %d]", RV_VLEN_MAX);
             return;
         }
         if (!is_power_of_2(cpu->cfg.elen)) {
             error_setg(errp,
-                    "Vector extension ELEN must be power of 2");
+                       "Vector extension ELEN must be power of 2");
             return;
         }
-    if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
-        error_setg(errp,
-                "Vector extension implementation only supports ELEN "
-                "in the range [8, 64]");
-        return;
-    }
-    if (cpu->cfg.vext_spec) {
-        if (!g_strcmp0(cpu->cfg.vext_spec, "v1.0")) {
-            vext_version = VEXT_VERSION_1_00_0;
-        } else {
+        if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
             error_setg(errp,
-                   "Unsupported vector spec version '%s'",
-                   cpu->cfg.vext_spec);
+                       "Vector extension implementation only supports ELEN "
+                       "in the range [8, 64]");
             return;
         }
-    } else {
-        qemu_log("vector version is not specified, "
-                 "use the default value v1.0\n");
-    }
-    set_vext_version(env, vext_version);
+        if (cpu->cfg.vext_spec) {
+            if (!g_strcmp0(cpu->cfg.vext_spec, "v1.0")) {
+                vext_version = VEXT_VERSION_1_00_0;
+            } else {
+                error_setg(errp,
+                           "Unsupported vector spec version '%s'",
+                           cpu->cfg.vext_spec);
+                return;
+            }
+        } else {
+            qemu_log("vector version is not specified, "
+                     "use the default value v1.0\n");
+        }
+        set_vext_version(env, vext_version);
     }
     if (cpu->cfg.ext_j) {
         ext |= RVJ;

[PULL,17/59] target/riscv: Indent fixes in cpu.c

Commit Message

Patch