mbox

[PULL,0/5] Misc fixes, for thread-pool, xen, and xen-emulate

Message ID 20230801094038.11026-1-anthony.perard@citrix.com (mailing list archive)
State New, archived
Headers show

Pull-request

https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git tags/pull-xen-20230801

Message

Anthony PERARD Aug. 1, 2023, 9:40 a.m. UTC
The following changes since commit 802341823f1720511dd5cf53ae40285f7978c61b:

  Merge tag 'pull-tcg-20230731' of https://gitlab.com/rth7680/qemu into staging (2023-07-31 14:02:51 -0700)

are available in the Git repository at:

  https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git tags/pull-xen-20230801

for you to fetch changes up to 856ca10f9ce1fcffeab18546b36a64f79017c905:

  xen-platform: do full PCI reset during unplug of IDE devices (2023-08-01 10:22:33 +0100)

----------------------------------------------------------------
Misc fixes, for thread-pool, xen, and xen-emulate

* fix an access to `request_cond` QemuCond in thread-pool
* fix issue with PCI devices when unplugging IDE devices in Xen guest
* several fixes for issues pointed out by Coverity

----------------------------------------------------------------
Anthony PERARD (2):
      xen-block: Avoid leaks on new error path
      thread-pool: signal "request_cond" while locked

David Woodhouse (1):
      hw/xen: Clarify (lack of) error handling in transaction_commit()

Olaf Hering (1):
      xen-platform: do full PCI reset during unplug of IDE devices

Peter Maydell (1):
      xen: Don't pass MemoryListener around by value

 hw/arm/xen_arm.c                |  4 ++--
 hw/block/xen-block.c            | 11 ++++++-----
 hw/i386/kvm/xenstore_impl.c     | 12 +++++++++++-
 hw/i386/xen/xen-hvm.c           |  4 ++--
 hw/i386/xen/xen_platform.c      |  7 ++++---
 hw/xen/xen-hvm-common.c         |  8 ++++----
 include/hw/xen/xen-hvm-common.h |  2 +-
 util/thread-pool.c              |  2 +-
 8 files changed, 31 insertions(+), 19 deletions(-)

Comments

Richard Henderson Aug. 1, 2023, 5:48 p.m. UTC | #1
On 8/1/23 02:40, Anthony PERARD via wrote:
> The following changes since commit 802341823f1720511dd5cf53ae40285f7978c61b:
> 
>    Merge tag 'pull-tcg-20230731' ofhttps://gitlab.com/rth7680/qemu  into staging (2023-07-31 14:02:51 -0700)
> 
> are available in the Git repository at:
> 
>    https://xenbits.xen.org/git-http/people/aperard/qemu-dm.git  tags/pull-xen-20230801
> 
> for you to fetch changes up to 856ca10f9ce1fcffeab18546b36a64f79017c905:
> 
>    xen-platform: do full PCI reset during unplug of IDE devices (2023-08-01 10:22:33 +0100)
> 
> ----------------------------------------------------------------
> Misc fixes, for thread-pool, xen, and xen-emulate
> 
> * fix an access to `request_cond` QemuCond in thread-pool
> * fix issue with PCI devices when unplugging IDE devices in Xen guest
> * several fixes for issues pointed out by Coverity

Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.


r~
Michael Tokarev Aug. 2, 2023, 3:18 p.m. UTC | #2
01.08.2023 12:40, Anthony PERARD via wrote:
...
> Anthony PERARD (2):
>        xen-block: Avoid leaks on new error path
>        thread-pool: signal "request_cond" while locked
> 
> David Woodhouse (1):
>        hw/xen: Clarify (lack of) error handling in transaction_commit()
> 
> Olaf Hering (1):
>        xen-platform: do full PCI reset during unplug of IDE devices
> 
> Peter Maydell (1):
>        xen: Don't pass MemoryListener around by value

 From the descriptions, it looks like

         xen-block: Avoid leaks on new error path
         thread-pool: signal "request_cond" while locked
         xen-platform: do full PCI reset during unplug of IDE devices

should be applied to -stable.

More, it looks like all 3 should be applied to v7.2.x series too,
including the PCI reset one, which is a bit problematic for 7.2
because it lacks dfa6ba6baeebe "Replace use of qdev_reset_all()
with device_cold_reset()", but that change was mechanical.

Olaf, can you please take a look at
https://gitlab.com/mjt0k/qemu/-/commit/645d74c366c8c6334bf9a3403f780adefe4e410f
(from https://gitlab.com/mjt0k/qemu/-/commits/staging-7.2/ )
and check if it makes sense?

Or if whole thing makes no sense to backport to stable, please
let me know as well.

Thanks!

/mjt
Olaf Hering Aug. 2, 2023, 6:34 p.m. UTC | #3
Wed, 2 Aug 2023 18:18:01 +0300 Michael Tokarev <mjt@tls.msk.ru>:

> Or if whole thing makes no sense to backport to stable, please
> let me know as well.

The xen-platform change does not need to be backported IMHO.


Olaf