[PULL,04/13] io: check there are no qio_channel_yield() coroutines during ->finalize()

Commit Message

Eric Blake Sept. 8, 2023, 1:35 a.m. UTC

From: Stefan Hajnoczi <[e-mail]>

Callers must clean up their coroutines before calling
object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an
assertion to check this.

This patch is preparation for the fd handler changes that follow.

Signed-off-by: Stefan Hajnoczi <[e-mail]>
Reviewed-by: Daniel P. Berrangé <[e-mail]>
Reviewed-by: Eric Blake <[e-mail]>
Message-ID: <[e-mail]>
Signed-off-by: Eric Blake <[e-mail]>
---
 io/channel.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch

diff --git a/io/channel.c b/io/channel.c
index 72f0066af55..c415f3fc885 100644
--- a/io/channel.c
+++ b/io/channel.c
@@ -653,6 +653,10 @@  static void qio_channel_finalize(Object *obj)
 {
     QIOChannel *ioc = QIO_CHANNEL(obj);

+    /* Must not have coroutines in qio_channel_yield() */
+    assert(!ioc->read_coroutine);
+    assert(!ioc->write_coroutine);
+
     g_free(ioc->name);

 #ifdef _WIN32