[v2,4/4] multifd: reset next_packet_len after sending pages

Commit Message

Elena Ufimtseva Oct. 11, 2023, 6:43 p.m. UTC

Sometimes multifd sends just sync packet with no pages
(normal_num is 0). In this case the old value is being
preserved and being accounted for while only packet_len
is being transferred.
Reset it to 0 after sending and accounting for.

Signed-off-by: Elena Ufimtseva <[e-mail]>
Reviewed-by: Fabiano Rosas <[e-mail]>
---
 migration/multifd.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Juan Quintela Oct. 16, 2023, 7:26 a.m. UTC | #1

Elena Ufimtseva <[e-mail]> wrote:
> Sometimes multifd sends just sync packet with no pages
> (normal_num is 0). In this case the old value is being
> preserved and being accounted for while only packet_len
> is being transferred.
> Reset it to 0 after sending and accounting for.
>
> Signed-off-by: Elena Ufimtseva <[e-mail]>
> Reviewed-by: Fabiano Rosas <[e-mail]>

Reviewed-by: Juan Quintela <[e-mail]>

Patch

diff --git a/migration/multifd.c b/migration/multifd.c
index e6e0013c16..c45f5015f8 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -730,6 +730,7 @@  static void *multifd_send_thread(void *opaque)
                        p->next_packet_size + p->packet_len);
             stat64_add(&mig_stats.transferred,
                        p->next_packet_size + p->packet_len);
+            p->next_packet_size = 0;
             qemu_mutex_lock(&p->mutex);
             p->pending_job--;
             qemu_mutex_unlock(&p->mutex);