[v1,2/2] oslib-posix: initialize backend memory objects in parallel

Commit Message

Mark Kanda Jan. 8, 2024, 3:10 p.m. UTC

QEMU initializes preallocated backend memory as the objects are parsed from
the command line. This is not optimal in some cases (e.g. memory spanning
multiple numa nodes) because the memory objects are initialized in series.

Allow the initialization to occur in parallel. The performance increase is
significant and scales with the number of objects. On a 2 socket Skylake VM
with 128GB and 2 init threads per socket (256GB total), the memory init time
decreases from ~27 seconds to ~14 seconds.

Signed-off-by: Mark Kanda <[e-mail]>
---
 include/qemu/osdep.h |  6 ++++++
 system/vl.c          |  2 ++
 util/oslib-posix.c   | 46 +++++++++++++++++++++++++++++++++-----------
 util/oslib-win32.c   |  5 +++++
 4 files changed, 48 insertions(+), 11 deletions(-)

Patch

diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index d30ba73eda..57185e6309 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -682,6 +682,12 @@  typedef struct ThreadContext ThreadContext;
 void qemu_prealloc_mem(int fd, char *area, size_t sz, int max_threads,
                        ThreadContext *tc, Error **errp);
 
+/**
+ * Wait for any outstanding memory prealloc initialization
+ * to complete.
+ */
+void wait_mem_prealloc_init(void);
+
 /**
  * qemu_get_pid_name:
  * @pid: pid of a process
diff --git a/system/vl.c b/system/vl.c
index 6b87bfa32c..9e04acbb2c 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -2010,6 +2010,8 @@  static void qemu_create_late_backends(void)
 
     object_option_foreach_add(object_create_late);
 
+    wait_mem_prealloc_init();
+
     if (tpm_init() < 0) {
         exit(1);
     }
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 293297ac6c..667d2d960c 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -91,6 +91,7 @@  static QemuMutex sigbus_mutex;
 
 static QemuMutex page_mutex;
 static QemuCond page_cond;
+static bool prealloc_init;
 
 int qemu_get_thread_id(void)
 {
@@ -487,6 +488,12 @@  static int wait_mem_prealloc(void)
 {
     int i, ret = 0;
     MemsetContext *context, *next_context;
+
+    /* Return if memory prealloc isn't enabled or active */
+    if (QLIST_EMPTY(&memset_contexts) || !prealloc_init) {
+        return 0;
+    }
+
     qemu_mutex_lock(&page_mutex);
     QLIST_FOREACH(context, &memset_contexts, next) {
         context->all_threads_created = true;
@@ -553,21 +560,23 @@  void qemu_prealloc_mem(int fd, char *area, size_t sz, int max_threads,
         }
 
         qemu_mutex_lock(&sigbus_mutex);
-        memset(&act, 0, sizeof(act));
+        if (!sigbus_oldact.sa_handler) {
+            memset(&act, 0, sizeof(act));
 #ifdef CONFIG_LINUX
-        act.sa_sigaction = &sigbus_handler;
-        act.sa_flags = SA_SIGINFO;
+            act.sa_sigaction = &sigbus_handler;
+            act.sa_flags = SA_SIGINFO;
 #else /* CONFIG_LINUX */
-        act.sa_handler = &sigbus_handler;
-        act.sa_flags = 0;
+            act.sa_handler = &sigbus_handler;
+            act.sa_flags = 0;
 #endif /* CONFIG_LINUX */
 
-        ret = sigaction(SIGBUS, &act, &sigbus_oldact);
-        if (ret) {
-            qemu_mutex_unlock(&sigbus_mutex);
-            error_setg_errno(errp, errno,
-                "qemu_prealloc_mem: failed to install signal handler");
-            return;
+            ret = sigaction(SIGBUS, &act, &sigbus_oldact);
+            if (ret) {
+                qemu_mutex_unlock(&sigbus_mutex);
+                error_setg_errno(errp, errno,
+                    "qemu_prealloc_mem: failed to install signal handler");
+                return;
+            }
         }
     }
 
@@ -589,6 +598,21 @@  void qemu_prealloc_mem(int fd, char *area, size_t sz, int max_threads,
     }
 }
 
+void wait_mem_prealloc_init(void)
+{
+    /*
+     * Set prealloc_init true to make wait_mem_prealloc() wait for the
+     * initialization to complete.
+     */
+    prealloc_init = true;
+
+    /* Wait for any outstanding init to complete */
+    if (wait_mem_prealloc()) {
+        perror("wait_mem_prealloc_init: failed waiting for memory prealloc");
+        exit(1);
+    }
+}
+
 char *qemu_get_pid_name(pid_t pid)
 {
     char *name = NULL;
diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index 55b0189dc3..72e050bee1 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -276,6 +276,11 @@  void qemu_prealloc_mem(int fd, char *area, size_t sz, int max_threads,
     }
 }
 
+void wait_mem_prealloc_init(void)
+{
+    /* not supported */
+}
+
 char *qemu_get_pid_name(pid_t pid)
 {
     /* XXX Implement me */