| Message ID | 20240319164527.1873891-5-yuan1.liu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Live Migration With IAA | expand |
On Wed, Mar 20, 2024 at 12:45:24AM +0800, Yuan Liu wrote: > add the Query Processing Library (QPL) compression method > > Although both qpl and zlib support deflate compression, qpl will > only use the In-Memory Analytics Accelerator(IAA) for compression > and decompression, and IAA is not compatible with the Zlib in > migration, so qpl is used as a new compression method for migration. > > How to enable qpl compression during migration: > migrate_set_parameter multifd-compression qpl > > The qpl only supports one compression level, there is no qpl > compression level parameter added, users do not need to specify > the qpl compression level. > > Signed-off-by: Yuan Liu <yuan1.liu@intel.com> > Reviewed-by: Nanhai Zou <nanhai.zou@intel.com> > --- > hw/core/qdev-properties-system.c | 2 +- > migration/meson.build | 1 + > migration/multifd-qpl.c | 20 ++++++++++++++++++++ > migration/multifd.h | 1 + > qapi/migration.json | 7 ++++++- > 5 files changed, 29 insertions(+), 2 deletions(-) > create mode 100644 migration/multifd-qpl.c > > diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c > index d79d6f4b53..6ccd7224f6 100644 > --- a/hw/core/qdev-properties-system.c > +++ b/hw/core/qdev-properties-system.c > @@ -659,7 +659,7 @@ const PropertyInfo qdev_prop_fdc_drive_type = { > const PropertyInfo qdev_prop_multifd_compression = { > .name = "MultiFDCompression", > .description = "multifd_compression values, " > - "none/zlib/zstd", > + "none/zlib/zstd/qpl", > .enum_table = &MultiFDCompression_lookup, > .get = qdev_propinfo_get_enum, > .set = qdev_propinfo_set_enum, > diff --git a/migration/meson.build b/migration/meson.build > index 1eeb915ff6..cb177de1d2 100644 > --- a/migration/meson.build > +++ b/migration/meson.build > @@ -41,6 +41,7 @@ if get_option('live_block_migration').allowed() > system_ss.add(files('block.c')) > endif > system_ss.add(when: zstd, if_true: files('multifd-zstd.c')) > +system_ss.add(when: qpl, if_true: files('multifd-qpl.c')) > > specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', > if_true: files('ram.c', > diff --git a/migration/multifd-qpl.c b/migration/multifd-qpl.c > new file mode 100644 > index 0000000000..056a68a060 > --- /dev/null > +++ b/migration/multifd-qpl.c > @@ -0,0 +1,20 @@ > +/* > + * Multifd qpl compression accelerator implementation > + * > + * Copyright (c) 2023 Intel Corporation > + * > + * Authors: > + * Yuan Liu<yuan1.liu@intel.com> > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or later. > + * See the COPYING file in the top-level directory. > + */ > +#include "qemu/osdep.h" > +#include "qemu/module.h" > + > +static void multifd_qpl_register(void) > +{ > + /* noop */ > +} > + > +migration_init(multifd_qpl_register); > diff --git a/migration/multifd.h b/migration/multifd.h > index c9d9b09239..5b7d9b15f8 100644 > --- a/migration/multifd.h > +++ b/migration/multifd.h > @@ -40,6 +40,7 @@ MultiFDRecvData *multifd_get_recv_data(void); > #define MULTIFD_FLAG_NOCOMP (0 << 1) > #define MULTIFD_FLAG_ZLIB (1 << 1) > #define MULTIFD_FLAG_ZSTD (2 << 1) > +#define MULTIFD_FLAG_QPL (4 << 1) > > /* This value needs to be a multiple of qemu_target_page_size() */ > #define MULTIFD_PACKET_SIZE (512 * 1024) > diff --git a/qapi/migration.json b/qapi/migration.json > index aa1b39bce1..dceb35db5b 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -629,11 +629,16 @@ > # > # @zstd: use zstd compression method. > # > +# @qpl: use qpl compression method. Query Processing Library(qpl) is based on > +# the deflate compression algorithm and use the Intel In-Memory Analytics > +# Accelerator(IAA) accelerated compression and decompression. (Since 9.0) s/9.0/9.1/ > +# > # Since: 5.0 > ## > { 'enum': 'MultiFDCompression', > 'data': [ 'none', 'zlib', > - { 'name': 'zstd', 'if': 'CONFIG_ZSTD' } ] } > + { 'name': 'zstd', 'if': 'CONFIG_ZSTD' }, > + { 'name': 'qpl', 'if': 'CONFIG_QPL' } ] } > > ## > # @MigMode: > -- > 2.39.3 > Reviewed-by: Peter Xu <peterx@redhat.com>
> -----Original Message----- > From: Peter Xu <peterx@redhat.com> > Sent: Thursday, March 28, 2024 3:49 AM > To: Liu, Yuan1 <yuan1.liu@intel.com> > Cc: farosas@suse.de; qemu-devel@nongnu.org; hao.xiang@bytedance.com; > bryan.zhang@bytedance.com; Zou, Nanhai <nanhai.zou@intel.com> > Subject: Re: [PATCH v5 4/7] migration/multifd: add qpl compression method > > On Wed, Mar 20, 2024 at 12:45:24AM +0800, Yuan Liu wrote: > > add the Query Processing Library (QPL) compression method > > > > Although both qpl and zlib support deflate compression, qpl will > > only use the In-Memory Analytics Accelerator(IAA) for compression > > and decompression, and IAA is not compatible with the Zlib in > > migration, so qpl is used as a new compression method for migration. > > > > How to enable qpl compression during migration: > > migrate_set_parameter multifd-compression qpl > > > > The qpl only supports one compression level, there is no qpl > > compression level parameter added, users do not need to specify > > the qpl compression level. > > > > Signed-off-by: Yuan Liu <yuan1.liu@intel.com> > > Reviewed-by: Nanhai Zou <nanhai.zou@intel.com> > > --- > > hw/core/qdev-properties-system.c | 2 +- > > migration/meson.build | 1 + > > migration/multifd-qpl.c | 20 ++++++++++++++++++++ > > migration/multifd.h | 1 + > > qapi/migration.json | 7 ++++++- > > 5 files changed, 29 insertions(+), 2 deletions(-) > > create mode 100644 migration/multifd-qpl.c > > > > diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties- > system.c > > index d79d6f4b53..6ccd7224f6 100644 > > --- a/hw/core/qdev-properties-system.c > > +++ b/hw/core/qdev-properties-system.c > > @@ -659,7 +659,7 @@ const PropertyInfo qdev_prop_fdc_drive_type = { > > const PropertyInfo qdev_prop_multifd_compression = { > > .name = "MultiFDCompression", > > .description = "multifd_compression values, " > > - "none/zlib/zstd", > > + "none/zlib/zstd/qpl", > > .enum_table = &MultiFDCompression_lookup, > > .get = qdev_propinfo_get_enum, > > .set = qdev_propinfo_set_enum, > > diff --git a/migration/meson.build b/migration/meson.build > > index 1eeb915ff6..cb177de1d2 100644 > > --- a/migration/meson.build > > +++ b/migration/meson.build > > @@ -41,6 +41,7 @@ if get_option('live_block_migration').allowed() > > system_ss.add(files('block.c')) > > endif > > system_ss.add(when: zstd, if_true: files('multifd-zstd.c')) > > +system_ss.add(when: qpl, if_true: files('multifd-qpl.c')) > > > > specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', > > if_true: files('ram.c', > > diff --git a/migration/multifd-qpl.c b/migration/multifd-qpl.c > > new file mode 100644 > > index 0000000000..056a68a060 > > --- /dev/null > > +++ b/migration/multifd-qpl.c > > @@ -0,0 +1,20 @@ > > +/* > > + * Multifd qpl compression accelerator implementation > > + * > > + * Copyright (c) 2023 Intel Corporation > > + * > > + * Authors: > > + * Yuan Liu<yuan1.liu@intel.com> > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2 or > later. > > + * See the COPYING file in the top-level directory. > > + */ > > +#include "qemu/osdep.h" > > +#include "qemu/module.h" > > + > > +static void multifd_qpl_register(void) > > +{ > > + /* noop */ > > +} > > + > > +migration_init(multifd_qpl_register); > > diff --git a/migration/multifd.h b/migration/multifd.h > > index c9d9b09239..5b7d9b15f8 100644 > > --- a/migration/multifd.h > > +++ b/migration/multifd.h > > @@ -40,6 +40,7 @@ MultiFDRecvData *multifd_get_recv_data(void); > > #define MULTIFD_FLAG_NOCOMP (0 << 1) > > #define MULTIFD_FLAG_ZLIB (1 << 1) > > #define MULTIFD_FLAG_ZSTD (2 << 1) > > +#define MULTIFD_FLAG_QPL (4 << 1) > > > > /* This value needs to be a multiple of qemu_target_page_size() */ > > #define MULTIFD_PACKET_SIZE (512 * 1024) > > diff --git a/qapi/migration.json b/qapi/migration.json > > index aa1b39bce1..dceb35db5b 100644 > > --- a/qapi/migration.json > > +++ b/qapi/migration.json > > @@ -629,11 +629,16 @@ > > # > > # @zstd: use zstd compression method. > > # > > +# @qpl: use qpl compression method. Query Processing Library(qpl) is > based on > > +# the deflate compression algorithm and use the Intel In-Memory > Analytics > > +# Accelerator(IAA) accelerated compression and decompression. > (Since 9.0) > > s/9.0/9.1/ Ok, I will fix it in the next version. > > +# > > # Since: 5.0 > > ## > > { 'enum': 'MultiFDCompression', > > 'data': [ 'none', 'zlib', > > - { 'name': 'zstd', 'if': 'CONFIG_ZSTD' } ] } > > + { 'name': 'zstd', 'if': 'CONFIG_ZSTD' }, > > + { 'name': 'qpl', 'if': 'CONFIG_QPL' } ] } > > > > ## > > # @MigMode: > > -- > > 2.39.3 > > > > Reviewed-by: Peter Xu <peterx@redhat.com> > > -- > Peter Xu
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c index d79d6f4b53..6ccd7224f6 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -659,7 +659,7 @@ const PropertyInfo qdev_prop_fdc_drive_type = { const PropertyInfo qdev_prop_multifd_compression = { .name = "MultiFDCompression", .description = "multifd_compression values, " - "none/zlib/zstd", + "none/zlib/zstd/qpl", .enum_table = &MultiFDCompression_lookup, .get = qdev_propinfo_get_enum, .set = qdev_propinfo_set_enum, diff --git a/migration/meson.build b/migration/meson.build index 1eeb915ff6..cb177de1d2 100644 --- a/migration/meson.build +++ b/migration/meson.build @@ -41,6 +41,7 @@ if get_option('live_block_migration').allowed() system_ss.add(files('block.c')) endif system_ss.add(when: zstd, if_true: files('multifd-zstd.c')) +system_ss.add(when: qpl, if_true: files('multifd-qpl.c')) specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_true: files('ram.c', diff --git a/migration/multifd-qpl.c b/migration/multifd-qpl.c new file mode 100644 index 0000000000..056a68a060 --- /dev/null +++ b/migration/multifd-qpl.c @@ -0,0 +1,20 @@ +/* + * Multifd qpl compression accelerator implementation + * + * Copyright (c) 2023 Intel Corporation + * + * Authors: + * Yuan Liu<yuan1.liu@intel.com> + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ +#include "qemu/osdep.h" +#include "qemu/module.h" + +static void multifd_qpl_register(void) +{ + /* noop */ +} + +migration_init(multifd_qpl_register); diff --git a/migration/multifd.h b/migration/multifd.h index c9d9b09239..5b7d9b15f8 100644 --- a/migration/multifd.h +++ b/migration/multifd.h @@ -40,6 +40,7 @@ MultiFDRecvData *multifd_get_recv_data(void); #define MULTIFD_FLAG_NOCOMP (0 << 1) #define MULTIFD_FLAG_ZLIB (1 << 1) #define MULTIFD_FLAG_ZSTD (2 << 1) +#define MULTIFD_FLAG_QPL (4 << 1) /* This value needs to be a multiple of qemu_target_page_size() */ #define MULTIFD_PACKET_SIZE (512 * 1024) diff --git a/qapi/migration.json b/qapi/migration.json index aa1b39bce1..dceb35db5b 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -629,11 +629,16 @@ # # @zstd: use zstd compression method. # +# @qpl: use qpl compression method. Query Processing Library(qpl) is based on +# the deflate compression algorithm and use the Intel In-Memory Analytics +# Accelerator(IAA) accelerated compression and decompression. (Since 9.0) +# # Since: 5.0 ## { 'enum': 'MultiFDCompression', 'data': [ 'none', 'zlib', - { 'name': 'zstd', 'if': 'CONFIG_ZSTD' } ] } + { 'name': 'zstd', 'if': 'CONFIG_ZSTD' }, + { 'name': 'qpl', 'if': 'CONFIG_QPL' } ] } ## # @MigMode: