| Message ID | 20240328102052.3499331-6-marcandre.lureau@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | -Werror=maybe-uninitialized fixes | expand |
On 28.03.24 13:20, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > ../block/mirror.c:1066:22: error: ‘iostatus’ may be used uninitialized [-Werror=maybe-uninitialized] Actually that's a false-positive.. Compiler can't believe that body of WITH_JOB_LOCK_GUARD() will be executed unconditionally. Probably we should mention this in a comment. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> > --- > block/mirror.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/mirror.c b/block/mirror.c > index 1bdce3b657..53dd7332ee 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -926,7 +926,7 @@ static int coroutine_fn mirror_run(Job *job, Error **errp) > MirrorBDSOpaque *mirror_top_opaque = s->mirror_top_bs->opaque; > BlockDriverState *target_bs = blk_bs(s->target); > bool need_drain = true; > - BlockDeviceIoStatus iostatus; > + BlockDeviceIoStatus iostatus = BLOCK_DEVICE_IO_STATUS__MAX; > int64_t length; > int64_t target_length; > BlockDriverInfo bdi;
diff --git a/block/mirror.c b/block/mirror.c index 1bdce3b657..53dd7332ee 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -926,7 +926,7 @@ static int coroutine_fn mirror_run(Job *job, Error **errp) MirrorBDSOpaque *mirror_top_opaque = s->mirror_top_bs->opaque; BlockDriverState *target_bs = blk_bs(s->target); bool need_drain = true; - BlockDeviceIoStatus iostatus; + BlockDeviceIoStatus iostatus = BLOCK_DEVICE_IO_STATUS__MAX; int64_t length; int64_t target_length; BlockDriverInfo bdi;