[PULL,04/15] Hexagon (target/hexagon) Pass P0 explicitly to helpers that need it

Commit Message

Brian Cain May 6, 2024, 2:42 a.m. UTC

From: Taylor Simpson <[e-mail]>

Rather than reading P0 from the env, pass it explicitly

Signed-off-by: Taylor Simpson <[e-mail]>
Reviewed-by: Anton Johansson <[e-mail]>
Tested-by: Anton Johansson <[e-mail]>
Reviewed-by: Brian Cain <[e-mail]>
Message-Id: <[e-mail]>
Signed-off-by: Brian Cain <[e-mail]>
---
 target/hexagon/hex_common.py | 10 ++++++++++
 target/hexagon/macros.h      |  4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

Patch

diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
index 9e7f613e3c..63d18f73ad 100755
--- a/target/hexagon/hex_common.py
+++ b/target/hexagon/hex_common.py
@@ -197,6 +197,10 @@  def get_tagimms():
     return dict(zip(tags, list(map(compute_tag_immediates, tags))))
 
 
+def need_p0(tag):
+    return "A_IMPLICIT_READS_P0" in attribdict[tag]
+
+
 def need_slot(tag):
     if (
         "A_CVI_SCATTER" not in attribdict[tag]
@@ -1134,6 +1138,12 @@  def helper_args(tag, regs, imms):
             "tcg_constant_tl(ctx->next_PC)",
             "target_ulong next_PC"
         ))
+    if need_p0(tag):
+        args.append(HelperArg(
+            "i32",
+            "hex_pred[0]",
+            "uint32_t P0"
+        ))
     if need_slot(tag):
         args.append(HelperArg(
             "i32",
diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
index 1376d6ccc1..aedc863fab 100644
--- a/target/hexagon/macros.h
+++ b/target/hexagon/macros.h
@@ -1,5 +1,5 @@ 
 /*
- *  Copyright(c) 2019-2023 Qualcomm Innovation Center, Inc. All Rights Reserved.
+ *  Copyright(c) 2019-2024 Qualcomm Innovation Center, Inc. All Rights Reserved.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -358,7 +358,7 @@  static inline TCGv gen_read_ireg(TCGv result, TCGv val, int shift)
 #endif
 #define fREAD_PC() (PC)
 
-#define fREAD_P0() (env->pred[0])
+#define fREAD_P0() (P0)
 
 #define fCHECK_PCALIGN(A)