From patchwork Wed May 15 07:14:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 13664782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA7B2C25B77 for ; Wed, 15 May 2024 07:19:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s78rn-0006QG-89; Wed, 15 May 2024 03:15:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s78rF-0005An-TY for qemu-devel@nongnu.org; Wed, 15 May 2024 03:15:29 -0400 Received: from smarthost3.eviden.com ([80.78.11.84]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s78r1-0000oJ-RT for qemu-devel@nongnu.org; Wed, 15 May 2024 03:15:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1715757311; x=1747293311; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=aKnisHdbFAfgulEF7yIkNe9+bvQwr9U5G5fWP8kqic8=; b=nWN8KDReeKonxkijvqwiAJpYR2sET/OwUB+ub8cMUKMFuK02sjXTW03b /cSLWa51g9p+5F1481f8wfVGC3OYHdskdk6PswlfjZ7DNXx0lhfcNqb4b Nzo218N+2i2eLnkruwhLgEmHI3gq0uQ/u1+ZMrON+r2iAkUp8mI2Cybmb UuTrF+vP9OcTs6q++PqYtwExFCiYZNugFtWq/uUJqJJuFI1Z0ySk29NcW 4tIOlp/6Oq37SrLLeg/nngrN64QkIz3hXGMVw2cr1VJH/aUKT/lxa7G6I M1nB2zBjCsJO+6BE60h71HKvWhLj/peFs9zzH2dufBniKWYRplbsnXuhV Q==; X-IronPort-AV: E=Sophos;i="6.08,161,1712613600"; d="scan'208";a="12581817" X-MGA-submission: MDGXDm6pemKBV0ylHiqvuQNKgFoMO9nhaIfc5Yre/TZYSDYfWstlXbZExqBVKXxQhopXc7kMR8DgCIT2Vu34jyDHgfRRR65KcjSr0ZHuSzv62qkn208mPNoGwuPXiypDktrwymCBfjMSyspJqDXMaq78QEwIv+pcCaL8hhoH4SgbFA== Received: from mail-vi1eur04lp2051.outbound.protection.outlook.com (HELO EUR04-VI1-obe.outbound.protection.outlook.com) ([104.47.14.51]) by smarthost3.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 09:14:23 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KL3WAGJBDzfVJ+YKzNZJl8yK+7NSa3ToEAuAkm/S0UDomzTasgxYBA3LDgl2uJMEqBqjomrrPMtwBe8yStYrlA6rzzl3lykE4Gu99wWTayssJJhqQVwUPHmK/3MAyKv836eHibpV3FhBJCZERfwSli5gg5PV0yI+IZEmrhb5ynthp/hmb8tAZVhLxhZsytHNI4ULwAYy45R7ixgFavBfK6mI08F5ZxzrQuuG98BtgRePvR/OVI9IncWWLH31PwT4TQPiFGLNIILnM2UMv8stnv7SvHHbfNGDUutYvkstQfnDNgcwmd6jRUpVj59O5A1qSIvJx20NrI+v4UTbwZGubg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aKnisHdbFAfgulEF7yIkNe9+bvQwr9U5G5fWP8kqic8=; b=R8AI0y94YrBap/HVfoT5z+9L7rzCsxaoyydox2R3HzdkgD3gYhfab0RAdXRKoJDMLVQJRlTCKsnNa1ZPlXedellDC+1L/XAS3b4SYMiOK5QzQMYXXTyTUUH/g0tFoHaRfG2uEw5LPcDE1hT0bcxbN0g0aDtyczKv/HmUe6g2v+HR9gfkS0Hnf449PQJVK0TrBhYTS07uZO1hNlQBEDvozQohVDaUNDzrXFRMhxdqn8O+CGuT0lcPXMZK1Ckodk7YamKzkxSEJHNpBQkc6H1WCZ0ibUiJ1Z73w5/M4TxHeGNFT5cai7oQMbvqFdWHL6ztSkfgOOPFFYgfDXnXgaU4TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by VI1PR07MB6718.eurprd07.prod.outlook.com (2603:10a6:800:18f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.27; Wed, 15 May 2024 07:14:22 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%5]) with mapi id 15.20.7544.056; Wed, 15 May 2024 07:14:22 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH ats_vtd v2 25/25] intel_iommu: add support for ATS Thread-Topic: [PATCH ats_vtd v2 25/25] intel_iommu: add support for ATS Thread-Index: AQHappeCjqBaENfy6kaXOnkN/YX9aA== Date: Wed, 15 May 2024 07:14:22 +0000 Message-ID: <20240515071057.33990-26-clement.mathieu--drif@eviden.com> References: <20240515071057.33990-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240515071057.33990-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|VI1PR07MB6718:EE_ x-ms-office365-filtering-correlation-id: e560f823-9b38-4619-ea1e-08dc74aea509 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|376005|1800799015|38070700009; x-microsoft-antispam-message-info: =?utf-8?q?b9yGM+HTazUf9ELmU/3TBJq0pZ2ap6V?= =?utf-8?q?Dn0R5L5+BdRJAuBoPKqPEg1ymrEViGM03XpJcLAbCtIcau8nLy7Ch5JBOeGn1Djk8?= =?utf-8?q?CJWh3Jr5VZNOFUSCW58bGCeh+AC+ltgs8Q1Wu5xspVn08ro4syMjDMGGIfXxv6F+N?= =?utf-8?q?vecUleSml7LCH4gS/JJDTE2Q9xGiGexmZNRErbtFs0OKMcZynKIgO1MlCuKxVffQy?= =?utf-8?q?C+sZR91MxmVvebvdLGC8sgW8b9Hm1eagt2gyta/bg5ZbexYqJTgQNpDJnT7H8xKXn?= =?utf-8?q?JheVoeaEYuXy5MsYHavLuibotdIaV5gZQ/2u2ArUNs2MT8+w+d0Vx4/yt24tzXl8a?= =?utf-8?q?sCHe43yYlS53Tmu5zHkyU9RFfYzYu6jSGoSO8+CjQaUiKx9UcqheNuVgomKbL1uD2?= =?utf-8?q?u5noAAvsdWSL+qCkhKCzjmvgLFbRmWhMtfi0sEkaBtEs8QPUgMR0LRUT/6vGGHEXX?= =?utf-8?q?ropB7eMJWVXMqU3qcKGCZ7tyTO+m7HguMTH3MCMvKyJBtY3VOyjEbiURz1vunyMjD?= =?utf-8?q?WC30n7K0a90pvOCaHHmTm8O3iwG4bkxOFOTbyBCRRKAnvFpUO9uYc6475atYvLlq9?= =?utf-8?q?sLEZoHtBL3O7iDKA6ruQrL/VcoM9sycjehwmQc5OnjibZCJh8AK8f/ix5TQtPHtw7?= =?utf-8?q?BvYtTHkefkTWFq59KB0Ja9JfAfkeNO9VDh0vfEv5yzWgnlj7NC22S1rDXRV7cxj/P?= =?utf-8?q?Dil+QM5IO3HQGA/WF5TcSEJHuZmZhHLZ93Nq+0P3hTBqMahMNhrluDUBTfihxCqG6?= =?utf-8?q?WUWNlSkak250yRNT2kS+AzlCPyQWftEg0CiH+D5yNGMhh78Ysg83Cl8udXY2upXF7?= =?utf-8?q?Vii+ioNr3areH2/UFKj/hitxvAWNb6lSFGQxDt2EeC85hEXCAa+h120FC+JwBv2h7?= =?utf-8?q?9nUTLHSVnWnbWX5t/7o71w3nsz41j6RTXN2mw4LyVDpld+4m8Cs5xtINnxVltqNpL?= =?utf-8?q?R///yqWCuN3TCtYrTo/x+XZ4UKmu/vP9gnM1nOYpeKpZMnBRPcsr71PAoJ8ajT5OY?= =?utf-8?q?2VwiPt7SCtuJ3XI6fdbnBUia9rssdZBN8ACmwd+UYRIdE9yfKhVyQxclJ1kDUgPru?= =?utf-8?q?FfH+gpKdyNMXGcMW3Yz4bBnDIZVP7Ur8wLAOjlv3wZppNCzCDv509SQKj6hxDYie8?= =?utf-8?q?jjKN4SihwHWz3lMTSJbrAl0oNeeOGWJ0m1ymAphzHcrdyQbh2wU1KaqYYfVicCeHC?= =?utf-8?q?lMwp0esUKIlRw5vjzKhiphfxzuQOfIsVGoLjAX7/W8ifXWjuBhmnzyJtG5tO3e9XO?= =?utf-8?q?gg25bxesmP78Pp8WU/otvSNnogAMfSngKDg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?rjO9ILBn+QlXqGpY/z1FP0CDsYKW?= =?utf-8?q?GJw2CHS/PNF0yG7KFAV1VbblKNfTJGkFcBFeW1SGX3gfmZlqhyVA/r1apC+RrFMZe?= =?utf-8?q?zq2cjIJSrLdOz2bejoVuwCK2GpD0rfCyE7gi3AM7bBuHg55lSDR+3pQLohEe587Bk?= =?utf-8?q?KnAYcCpHlemkYfH+yaSBDG7hjwZK0TlxSL2ATe9LxCvFwH3g+PNKtub8EdlmaMjIK?= =?utf-8?q?3zYYFap0uf2jQFXREtzpjWLCx1V8PE0dOO77+rYEeZRePZ0mmY1oxocvPrHeCYSgM?= =?utf-8?q?p34m8WtDWHsL2uy4dcdEep0hPyfkdA4t97qnQIuuBwSXNNfjaC8MsjMR1b+Ye1Sfn?= =?utf-8?q?p4d3+IGK+yo04HGPPH90RMy4ByrK5UdvaMaDIqLrNcI8QbRGcuG35VyPFf2JbQTcj?= =?utf-8?q?56BUVgwf0RpTCa4+ZLXFLy9UZtSrxfzHnwrL9W4x/W+w6L41/QPQSW5JDQNAc5Qy7?= =?utf-8?q?q0RUb24vGbA9szjtzc9SwfOXIaJ5xk06Gh03oiYAlu2JsqGSmNnqBzioPoE8dIzOS?= =?utf-8?q?XCe+ucmyFkaFNgXNb70nrOjA5rlLInIxn6X/glMIal/jOF2VPq7I0qB8ZlT5+XteH?= =?utf-8?q?KigwyRrg7/iYJJeBj8p4LpQzm8DyX6rPYICVlpbX6syq96scdrDcFzxYO8pYOJyJt?= =?utf-8?q?zbPBxGNfsKFGylxzlUhtJlylWC2HMFiZdWz9TSaEWC6Xgww/VVyEawNrTd8AMeKui?= =?utf-8?q?+GwWRpHPJTLo7hX0qM5END69qPMOMwVwyQlCs/YbHJNLLJ+/fESCUWc/H5arO6THo?= =?utf-8?q?k82nF+LsLzOhDF4MW8cDIEVdmqokYGyAvtD03v5afSkIul5GXdMHIR2ZYazXGDVvO?= =?utf-8?q?wF/FKN/AVTCl984O9iaGy7Vgf80qPB1dCmJNklwphG066nvMR7OqzMEO0gtg9LWAv?= =?utf-8?q?C3oSJzadWP7k5gE0HUFiphcqTrae1kOCJORn3Kks99C7Yqrxfrr5jK0miOBz4C/DP?= =?utf-8?q?pVBWCrgDI3x8N9OnFT/ks2UaYSreDWC8ZQUbko8cgEGIqQsV6b9wuh0EoiBsyY9G4?= =?utf-8?q?aKJQVw9VJOHWN/jrq4KkIIo9htYGZbZMWjbIcgK/Av/HOmTlEHjXNN8OYPBk1ddcH?= =?utf-8?q?/bkqsbxmO3PJ4jVyfryKtioESIX/9C4jt2aB7tCrVyFdqFa/Ww0/lDzdHsZK9UGhc?= =?utf-8?q?287L9rNiOaukwEVwOyd/MG/atDFx/BHCYQOb0L11HZw3Lm5tR+TroeSR17nt2Ll1J?= =?utf-8?q?clYFci9YCz7FT+y/ZxgaVPxWFzcohE3GICt3tqoSSFDLoHGpjoIC6HS8BZ9ufMCWf?= =?utf-8?q?Dcb4MyQC3vWo6v1dmCcwo06jgAnzR1iT3ANMcD4icA/WpdtNrCUHqIPi76LJSbK1R?= =?utf-8?q?T+HjDu5B5iEDlW+CHrqJt4QRoPmMPNaVCDmMN0uTiE0XPVUV9JyHRRY4AtQmmi2OR?= =?utf-8?q?DdENPIY2qL3nc+/AIqUO3Ioj94sxArRUA9y9BXyG9ZV3im2ljcu+Niek8eSuFq9tr?= =?utf-8?q?DHEf6ZiVKzxccSRMolxWi47UIkdRl/TCWELpS6KyE3lHHPJWGqFtCrAgBtBsuE+1Y?= =?utf-8?q?K4Wk0vZKYE8SrekAzcWJytrvlJ8pg97GMLzG1/c/r/EAIXzefG499g0=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e560f823-9b38-4619-ea1e-08dc74aea509 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 07:14:22.1185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YRlVO/4RKl0tZbvBPClQdtdT1nMzusoPoCUYqgFJ1s/uDMmx2/jJ2JUXLzqi6/7mMMa6dKkpqUBS28GeAAMo98gWzeK9LPlQeSZkYJ2GuUWC0ZxCuZJjQVYn4KCq46bc X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB6718 Received-SPF: pass client-ip=80.78.11.84; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost3.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 75 ++++++++++++++++++++++++++++++++-- hw/i386/intel_iommu_internal.h | 1 + 2 files changed, 73 insertions(+), 3 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 67b9ff4934..7421a99373 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -5394,12 +5394,10 @@ static void vtd_report_ir_illegal_access(VTDAddressSpace *vtd_as, bool is_fpd_set = false; VTDContextEntry ce; - assert(vtd_as->pasid != PCI_NO_PASID); - /* Try out best to fetch FPD, we can't do anything more */ if (vtd_dev_to_context_entry(s, bus_n, vtd_as->devfn, &ce) == 0) { is_fpd_set = ce.lo & VTD_CONTEXT_ENTRY_FPD; - if (!is_fpd_set && s->root_scalable) { + if (!is_fpd_set && s->root_scalable && vtd_as->pasid != PCI_NO_PASID) { vtd_ce_get_pasid_fpd(s, &ce, &is_fpd_set, vtd_as->pasid); } } @@ -6024,6 +6022,75 @@ static IOMMUMemoryRegion *vtd_get_memory_region_pasid(PCIBus *bus, return &vtd_as->iommu; } +static IOMMUTLBEntry vtd_iommu_ats_do_translate(IOMMUMemoryRegion *iommu, + hwaddr addr, + IOMMUAccessFlags flags, + int iommu_idx) +{ + IOMMUTLBEntry entry; + VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu); + + if (vtd_is_interrupt_addr(addr)) { + vtd_report_ir_illegal_access(vtd_as, addr, flags & IOMMU_WO); + entry.iova = 0; + entry.translated_addr = 0; + entry.addr_mask = ~VTD_PAGE_MASK_4K; + entry.perm = IOMMU_NONE; + entry.pasid = PCI_NO_PASID; + } else { + entry = vtd_iommu_translate(iommu, addr, flags, iommu_idx); + } + return entry; +} + +static ssize_t vtd_iommu_ats_request_translation(IOMMUMemoryRegion *iommu, + bool priv_req, bool exec_req, + hwaddr addr, size_t length, + bool no_write, + IOMMUTLBEntry *result, + size_t result_length, + uint32_t *err_count) +{ + IOMMUAccessFlags flags = IOMMU_ACCESS_FLAG_FULL(true, !no_write, exec_req, + priv_req, false, false); + ssize_t res_index = 0; + hwaddr target_address = addr + length; + IOMMUTLBEntry entry; + + *err_count = 0; + + while ((addr < target_address) && (res_index < result_length)) { + entry = vtd_iommu_ats_do_translate(iommu, addr, flags, 0); + if (!IOMMU_TLB_ENTRY_TRANSLATION_ERROR(&entry)) { /* Translation done */ + if (no_write) { + /* The device should not use this entry for a write access */ + entry.perm &= ~IOMMU_WO; + } + /* + * 4.1.2 : Global Mapping (G) : Remapping hardware provides a value + * of 0 in this field + */ + entry.perm &= ~IOMMU_GLOBAL; + } else { + *err_count += 1; + } + result[res_index] = entry; + res_index += 1; + addr = (addr & (~entry.addr_mask)) + (entry.addr_mask + 1); + } + + /* Buffer too small */ + if (addr < target_address) { + return -ENOMEM; + } + return res_index; +} + +static uint64_t vtd_get_min_page_size(IOMMUMemoryRegion *iommu) +{ + return VTD_PAGE_SIZE; +} + static PCIIOMMUOps vtd_iommu_ops = { .get_address_space = vtd_host_dma_iommu, .get_address_space_pasid = vtd_host_dma_iommu_pasid, @@ -6230,6 +6297,8 @@ static void vtd_iommu_memory_region_class_init(ObjectClass *klass, imrc->translate = vtd_iommu_translate; imrc->notify_flag_changed = vtd_iommu_notify_flag_changed; imrc->replay = vtd_iommu_replay; + imrc->iommu_ats_request_translation = vtd_iommu_ats_request_translation; + imrc->get_min_page_size = vtd_get_min_page_size; } static const TypeInfo vtd_iommu_memory_region_info = { diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h index 3d59e10488..aa4d0d5f16 100644 --- a/hw/i386/intel_iommu_internal.h +++ b/hw/i386/intel_iommu_internal.h @@ -193,6 +193,7 @@ #define VTD_ECAP_MHMV (15ULL << 20) #define VTD_ECAP_NEST (1ULL << 26) #define VTD_ECAP_SRS (1ULL << 31) +#define VTD_ECAP_NWFS (1ULL << 33) #define VTD_ECAP_PSS (19ULL << 35) #define VTD_ECAP_PASID (1ULL << 40) #define VTD_ECAP_SMTS (1ULL << 43)