From patchwork Wed May 15 07:14:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: CLEMENT MATHIEU--DRIF X-Patchwork-Id: 13664779 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41BE4C25B75 for ; Wed, 15 May 2024 07:18:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s78qV-0004aQ-4u; Wed, 15 May 2024 03:14:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s78qK-0004Y0-JC for qemu-devel@nongnu.org; Wed, 15 May 2024 03:14:29 -0400 Received: from smarthost4.eviden.com ([80.78.11.85]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s78qH-0000oc-0E for qemu-devel@nongnu.org; Wed, 15 May 2024 03:14:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eviden.com; i=@eviden.com; q=dns/txt; s=mail; t=1715757265; x=1747293265; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=XcjKecxBdsPpr9IsLkbs6s9MkMnBwLIwAGN4s71C3bc=; b=L2sx8td6Sgro9SZ6ouh0bdY6T/Pc+G3ddHHl+1Tut5X+9RQzRfz3s3zl YH5HejPQ57/lms1vU+ySfErQyNUfOJBob1+e0iSqy8UOqvsb56/rz7Wt9 XDAApD1Wok9gsh9K99qXs9cEWxh7u9Aw8iuSBGl7G2Uq/TIQrXPjpq/WV gfDEu1KQrp74YQhXuS94Fx5IGR/d89IPvdcCZZvhIVoWpbeZDj6PFx8tC +w0aEQiWXVYUPXgXEf2txwIo6qtxrEByVMietjxI9za6z8hv34hgUnbgD CSE0g+dOWo9MwO7Iyo9ftfA03QpuXlSbS1tDpLV8cO2Y7qVqGv36+uWDR g==; X-IronPort-AV: E=Sophos;i="6.08,161,1712613600"; d="scan'208";a="12635437" X-MGA-submission: MDGdBZAET//s8o3GItneiAiU43x3WGBbR/XnX59ruL2nVx+nSEfm9CwdGVsKwhYCQhKNW4rOc+waaFl3LxoorXk7FAtBKfICTHicB0LjvozUSsTLyYGQvgbW8PRYc+loXZq0U5/bawOkQbCnmsec9nL38xn4QDG9zOAaWtquygv6Ew== Received: from mail-db8eur05lp2104.outbound.protection.outlook.com (HELO EUR05-DB8-obe.outbound.protection.outlook.com) ([104.47.17.104]) by smarthost4.eviden.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 09:14:19 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KU63CaEajKbDofofl/vB8BIn9lbMk1oEABVvjbGKFkGwm3ZmvyZvp/9IZiYSWwIoK8X8IPb3JEEzhgnaWSaGth66geNwDWhvAVTGAzCuNJxYd3k+A8ulUew7N7DMpMQfeMkUIidq/IbkhWv32/nrwx/i4TbOSXLsTLNVQwDZ1ZpmbiLHoLCOMM80CssW7TlcLpmwCwOSM7SCPp+BZ4h3JzhxdVZTiWIC9wufzW6ZL66THPAFhfIXQHKi1eZUPupwF2pIKdeN1xKTf49GDoaAABZrEYbtf2Bs+IJQyCqh+0CoryDwrhM8Sjb1m/eZT5Ofy+OH+/iqJ/qAshPmbfomiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XcjKecxBdsPpr9IsLkbs6s9MkMnBwLIwAGN4s71C3bc=; b=n0xpH61ikuy5qEnXFf9O880I7pFaYUJhEwrUX5C0blPYZoLW2Rd2uRae9QybjcmmYRTfnjQ3czeJlNJOnLw6uGCenzM4lk2ahOrh4YQcPyctPpYLWk/D/KV1IBMAlH++i4hKWCIyWFj4x2V81bLmjJVCKC4VJb/QjHXgTVVGLgUHk9JFeHobf66Fz6EBzMQW+6dgP4TOohyOngSqyu9Kcc6I+FvCd6Li0yW6dTj1fkQ864G6t1MNWrYbGNxiQcIi/9T9gADnEISA6l8Y/wpRwSELiLEeBuW797MJkIpYSOJ/qiLo5vS4fr59XooXDPQVh/m58tN8T2aVihZC7t3gzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=eviden.com; dmarc=pass action=none header.from=eviden.com; dkim=pass header.d=eviden.com; arc=none Received: from AM8PR07MB7602.eurprd07.prod.outlook.com (2603:10a6:20b:24b::7) by AS5PR07MB9896.eurprd07.prod.outlook.com (2603:10a6:20b:676::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Wed, 15 May 2024 07:14:15 +0000 Received: from AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d]) by AM8PR07MB7602.eurprd07.prod.outlook.com ([fe80::fbd7:ca71:b636:6f9d%5]) with mapi id 15.20.7544.056; Wed, 15 May 2024 07:14:15 +0000 From: CLEMENT MATHIEU--DRIF To: "qemu-devel@nongnu.org" CC: "jasowang@redhat.com" , "zhenzhong.duan@intel.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "joao.m.martins@oracle.com" , "peterx@redhat.com" , CLEMENT MATHIEU--DRIF Subject: [PATCH ats_vtd v2 05/25] intel_iommu: return page walk level even when the translation fails Thread-Topic: [PATCH ats_vtd v2 05/25] intel_iommu: return page walk level even when the translation fails Thread-Index: AQHappd+BZPelwlHbkqPdUTJeAISqQ== Date: Wed, 15 May 2024 07:14:15 +0000 Message-ID: <20240515071057.33990-6-clement.mathieu--drif@eviden.com> References: <20240515071057.33990-1-clement.mathieu--drif@eviden.com> In-Reply-To: <20240515071057.33990-1-clement.mathieu--drif@eviden.com> Accept-Language: en-GB, fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=eviden.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM8PR07MB7602:EE_|AS5PR07MB9896:EE_ x-ms-office365-filtering-correlation-id: 1ac4e559-5523-48e9-9bda-08dc74aea0e5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?utf-8?q?pfHkcE7Qt7bbpUpMnpnq/2FLe/+qy0x?= =?utf-8?q?BGYfa9O9bdFH2OqHhM1UTRmUG35i3FbwwTgnWA735lNDKn4errvy5WE8VwfdQ6tFn?= =?utf-8?q?A1Ke62ElB7lp5Ye+MDz2LjhyK9xrsC/A7xRkqWCTC7gbgZklAS51P7+H/Tmo1/MeI?= =?utf-8?q?2/FJn1Y3mCvV65bO5wO8dD58piDHoDMcuzQ8DuAwcGS4U7NVio/0nA5sjh3Dk/BBT?= =?utf-8?q?BAkkmSRmcP8XoJWEvkxg/MhWPHhnEmRbdaqbgGWnrLmT4QkPtBoIaSiC8XNdHtgqs?= =?utf-8?q?8YPuPZRviT+MMZIuP+z6q7yJdB9IFNaqq9vsITBPrRw01TGeu0tSjjMpUMT0xCh7F?= =?utf-8?q?OH+NIPnziwIhltwHDpTMhPkrFf80spWgQgMS4Bd6u4oQn78WW2yA3UiMO/uAAO24W?= =?utf-8?q?QQth7Hv92u7MtaOOLlS7dBjYdkPP+OocX56v/dveWSLD2DBjbVM5SmbKqnJ0CqIY1?= =?utf-8?q?2xIa3ZC0Xq/RnXQDUgLfj16NDDnQHo9HBQC39JQKmIzQg9hLfH4WLIjPqIxuu8kts?= =?utf-8?q?Lr7nFvfaCjCv1lTCrey3k7aFeQmKmI+3Vhmbqp7jahNQtmaA9W7XQmYkefbJYGs6G?= =?utf-8?q?aBs9DXiq4p323D3bA4bzD/00jhGBbdfsCUbFvkrS7IhviusNFR1KDu7h1zkqi5mmP?= =?utf-8?q?dXp+d+mlzDTKDeAzgm7VtMHTqspCslg5A9nFP2+zaOdt5l0raP2ymbdDmCnWmd5Nu?= =?utf-8?q?3cziESPrjgJ1RWYtM6BV5nSY5XntEmtLdoYcRVilerFWWmBFUPsgOnxcGxiFkvpiH?= =?utf-8?q?D+iWlPOxtE+3RkMhjbeSTDGyymkslNL5hRRgxKpK3bhHl41eMnmAGyK4qXAeqgsXM?= =?utf-8?q?jQUjWYg40R8IpclLpygALG1GswfAeseKyPqWNGs4w8IntnG+RyX5uxyBEbQkawIAR?= =?utf-8?q?T9hkoQxs+QSrIoN9kPj2tJFSo2YqB1SPlkbwY/BV52tZ5+Z1iogSaS6Tob79sbcMZ?= =?utf-8?q?RGhKNq28pYSCdxvb0a8Wp9t3TFr6VZlLT/L3mRbZIlHHm/oNrR3jPJOUSaoe5p3dx?= =?utf-8?q?GnD1xFuG/IEboAaZnF+vtYydyVXWA4sptC5ROaAqI4ahkAkQApZ3x0rIUfvGvDBil?= =?utf-8?q?jj0DfviVYTj2ZHKbrTgqwhDo6qhUj3AdqnFhL01s0VPtjyfovpAaEiOSYeFiBGnMa?= =?utf-8?q?pTid+vc1BQvpN7ieLVMmmmJmyCCj0/EgBZFgax04ZjUfqSXjDMr0SNdNNl/8S38Uc?= =?utf-8?q?bTh8KOJKT4UBtzoKr5xzNHyy3WdcuKzJl/zcdHI3sm6d3mYo0hyQWfdxlqhzA+S+9?= =?utf-8?q?k4sRNpM4H+fmdYGnCbc/CyPpdb8lbnjow7w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR07MB7602.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?kJlTnXKBOpsaon+q7outcvJ/QhCV?= =?utf-8?q?DOd3A739R4pw8f3i+2sVHl9NJVd4AQJC7U36nQQMCAfg/qPxatuOOTyTDGH6AyhaY?= =?utf-8?q?i0/SHwAfIB73vX/qltU5eZ2te5X+bKwHvofqQizLQDdK9udLm3Ju6YAhTmvGFOXAm?= =?utf-8?q?HiGBfsPFLHsqOQvRzspfsJX1xPY+vYHVXLMe1rFUcnCG746FzEZ/fc9S2k89DZkgC?= =?utf-8?q?fcu5GJ5LmtE+B7Bl7RqKLWEtxbU5xIXkfue9R89NY10AVEaU0LYSsE5Akf8WV4qET?= =?utf-8?q?CvEDqRGG4IhILqF0VUP+9N7S7en3OzMoFab6RSIo7E6vGUxDATpCXIzk2JflgpFo3?= =?utf-8?q?24r8Gm5fG7zC0Zy3CSEPnUZgTt+9VQQo1t9XrcMP1GhuMsyJu2MMqIVGJtgC0LmIM?= =?utf-8?q?50lq0Q6XLPwPSfFchI866E4yWOQ5lIcNc1HZgMKrLfkNllzeoGVlOyDk1uzptpFrC?= =?utf-8?q?tYUkBBAqRrggHEoGlXewnZUJGasNWiQj6QDG/0Vooxqo2Su+jkU6iKrjUVLy2rITU?= =?utf-8?q?MnKeVN5d6gUWTMfW33W8EclThgH7i/R8VMuo99THnuqlwBvk3tJcstUXLfgh11Fj6?= =?utf-8?q?pqhas0c1m3a2QH6a0c2+M9FL+rJ0oJIxb89qnCvgglTsZQupt0d2u51S43yryBcg6?= =?utf-8?q?yJgtRbxRTvxvEIyZfELWUiXoVEkjenVaC8LJ32sHmvEV75Tv2BEedjVoZZsel4u/A?= =?utf-8?q?k3wR11Jvt4XoRIKngAPRrk0PdILcVS4OH0gxTQ/ysEIZldmHPAHaPgTlDy6IJAhKp?= =?utf-8?q?9fElqGYXXQH9Lu/X+cZesKxCkFcHWrbmHtr6o10R04FGoUMDygPWDHtGlDobKxSb7?= =?utf-8?q?ufSXf2HA0Y/n5l3M3sESdqnNVR8xwkTY+GdvNQ5WpKXFHeQoBJjz1xPEhHFemtQGm?= =?utf-8?q?9UoJlBo8Qk7jiJ35SD7Ns9EWhoAlDTBRwIHNymJ1F1SQtH4vKbcZPXqbisKho2Ejm?= =?utf-8?q?Pd4gWMCQGLY3PPZ8en7yTH6yFG1kpRJXi/oK4p3rjl5aIOeuRG9kV3eRlNeUYTZw1?= =?utf-8?q?InQuEyRXO68utaqBw/yY2sZjCHjlBReXGy5PBLsxl2AWrJ1cLpEdrSimFpninOFue?= =?utf-8?q?lWbh3Xnbqtnk0RcCJZsYPAsBJplz56xjXVgTNBsSgyDbME7LzJ4n8f0QsIsDTB9S9?= =?utf-8?q?HXZXJLPmdjUv+FWJ7n1BcBgCg/jGnUoDVsXvveucvYoVFQJrK5kLdk2EnTlrEK2A3?= =?utf-8?q?NbqyzgckynD8LnTedjOXpwaGD7SvKpmiuzV5TGa7p20JfdQ+31sGXZYskBLcz6NZR?= =?utf-8?q?ut0yccDcho32kVPpEIDJ1/CZ9FThbmtb2oGHtAupczU/67Zqb4BZyAobX+R7K6q0h?= =?utf-8?q?MntBKjz3kpAEm2GL4EwA838fTN92YwvvYJXKRaIDTr0VFyAcNRkUCLK1luAY0VAfG?= =?utf-8?q?n+ZQN/kZKXNFdNN7GjeHzXGWnhjjN6xe3R4h4ufaXHaB/divLWu2/ZphK1LeBLIKb?= =?utf-8?q?DXjsq2/r52rJh5AECoVZ3WIaVUsMzvJxGiAO8Udp1/77SG2p8JakKwVw+EJkJQriz?= =?utf-8?q?5Xb6HBciARJ91QelnOiU5e31+LqPoPdKEGPa5e4Xi29MxlV6dzFMlIY=3D?= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: eviden.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR07MB7602.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ac4e559-5523-48e9-9bda-08dc74aea0e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2024 07:14:15.2240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7d1c7785-2d8a-437d-b842-1ed5d8fbe00a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g/ukO6+HTU18UZ3b1zZRolYqWHZjaggE5tyPSrz4exaiC4WhgbXdhgRJlAipy0n0OA3FbmIWeuf6dHM0KOuuNXka8TVFmDQr2Y05l7nU8tGEJCnOqLpWWt6hb8J1oQYW X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR07MB9896 Received-SPF: pass client-ip=80.78.11.85; envelope-from=clement.mathieu--drif@eviden.com; helo=smarthost4.eviden.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org We use this information in vtd_do_iommu_translate to populate the IOMMUTLBEntry and indicate the correct page mask. This prevents ATS devices from sending many useless translation requests when a megapage or gigapage iova is not mapped to a physical address. Signed-off-by: Clément Mathieu--Drif --- hw/i386/intel_iommu.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 252364893b..7a4dd738a3 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2064,9 +2064,9 @@ static int vtd_iova_to_flpte(IntelIOMMUState *s, VTDContextEntry *ce, uint32_t pasid) { dma_addr_t addr = vtd_get_iova_pgtbl_base(s, ce, pasid); - uint32_t level = vtd_get_iova_level(s, ce, pasid); uint32_t offset; uint64_t flpte; + *flpte_level = vtd_get_iova_level(s, ce, pasid); if (!vtd_iova_fl_check_canonical(s, iova, ce, pasid)) { error_report_once("%s: detected non canonical IOVA (iova=0x%" PRIx64 "," @@ -2075,10 +2075,10 @@ static int vtd_iova_to_flpte(IntelIOMMUState *s, VTDContextEntry *ce, } while (true) { - offset = vtd_iova_fl_level_offset(iova, level); + offset = vtd_iova_fl_level_offset(iova, *flpte_level); flpte = vtd_get_flpte(addr, offset); if (flpte == (uint64_t)-1) { - if (level == vtd_get_iova_level(s, ce, pasid)) { + if (*flpte_level == vtd_get_iova_level(s, ce, pasid)) { /* Invalid programming of context-entry */ return -VTD_FR_CONTEXT_ENTRY_INV; } else { @@ -2103,19 +2103,18 @@ static int vtd_iova_to_flpte(IntelIOMMUState *s, VTDContextEntry *ce, return -VTD_FR_FS_BIT_UPDATE_FAILED; } - if (vtd_is_last_flpte(flpte, level)) { + if (vtd_is_last_flpte(flpte, *flpte_level)) { if (is_write && (vtd_set_flag_in_pte(addr, offset, flpte, VTD_FL_PTE_D) != MEMTX_OK)) { return -VTD_FR_FS_BIT_UPDATE_FAILED; } *flptep = flpte; - *flpte_level = level; return 0; } addr = vtd_get_flpte_addr(flpte, aw_bits); - level--; + (*flpte_level)--; } }