| Message ID | 20240522170107.289532-8-clg@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | s390x/ccw: Error reporting cleanups | expand |
>-----Original Message----- >From: Cédric Le Goater <clg@redhat.com> >Subject: [PATCH 7/7] vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier >registration errors > >vfio_ccw_register_irq_notifier() and vfio_ap_register_irq_notifier() >errors are currently reported using error_report_err(). Since they are >not considered as failing conditions, using warn_report_err() is more >appropriate. > >Signed-off-by: Cédric Le Goater <clg@redhat.com> Reviewed-by: Zhenzhong Duan <zhenzhong.duan@intel.com> Thanks Zhenzhong >--- > hw/vfio/ap.c | 2 +- > hw/vfio/ccw.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c >index >c12531a7886a2fe87598be0861fba5923bd2c206..0c4354e3e70169ec072e1 >6da0919936647d1d351 100644 >--- a/hw/vfio/ap.c >+++ b/hw/vfio/ap.c >@@ -172,7 +172,7 @@ static void vfio_ap_realize(DeviceState *dev, Error >**errp) > * Report this error, but do not make it a failing condition. > * Lack of this IRQ in the host does not prevent normal operation. > */ >- error_report_err(err); >+ warn_report_err(err); > } > > return; >diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c >index >36f2677a448c5e31523dcc3de7d973ec70e4a13c..1f8e1272c7555cd0a77048 >1d1ae92988f6e2e62e 100644 >--- a/hw/vfio/ccw.c >+++ b/hw/vfio/ccw.c >@@ -616,7 +616,7 @@ static void vfio_ccw_realize(DeviceState *dev, Error >**errp) > * Report this error, but do not make it a failing condition. > * Lack of this IRQ in the host does not prevent normal operation. > */ >- error_report_err(err); >+ warn_report_err(err); > } > > return; >-- >2.45.1
On 5/22/24 1:01 PM, Cédric Le Goater wrote: > vfio_ccw_register_irq_notifier() and vfio_ap_register_irq_notifier() > errors are currently reported using error_report_err(). Since they are > not considered as failing conditions, using warn_report_err() is more > appropriate. > > Signed-off-by: Cédric Le Goater <clg@redhat.com> Reviewed-by: Anthony Krowiak <akrowiak@linux.ibm.com> > --- > hw/vfio/ap.c | 2 +- > hw/vfio/ccw.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index c12531a7886a2fe87598be0861fba5923bd2c206..0c4354e3e70169ec072e16da0919936647d1d351 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -172,7 +172,7 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp) > * Report this error, but do not make it a failing condition. > * Lack of this IRQ in the host does not prevent normal operation. > */ > - error_report_err(err); > + warn_report_err(err); > } > > return; > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > index 36f2677a448c5e31523dcc3de7d973ec70e4a13c..1f8e1272c7555cd0a770481d1ae92988f6e2e62e 100644 > --- a/hw/vfio/ccw.c > +++ b/hw/vfio/ccw.c > @@ -616,7 +616,7 @@ static void vfio_ccw_realize(DeviceState *dev, Error **errp) > * Report this error, but do not make it a failing condition. > * Lack of this IRQ in the host does not prevent normal operation. > */ > - error_report_err(err); > + warn_report_err(err); > } > > return;
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index c12531a7886a2fe87598be0861fba5923bd2c206..0c4354e3e70169ec072e16da0919936647d1d351 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -172,7 +172,7 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp) * Report this error, but do not make it a failing condition. * Lack of this IRQ in the host does not prevent normal operation. */ - error_report_err(err); + warn_report_err(err); } return; diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 36f2677a448c5e31523dcc3de7d973ec70e4a13c..1f8e1272c7555cd0a770481d1ae92988f6e2e62e 100644 --- a/hw/vfio/ccw.c +++ b/hw/vfio/ccw.c @@ -616,7 +616,7 @@ static void vfio_ccw_realize(DeviceState *dev, Error **errp) * Report this error, but do not make it a failing condition. * Lack of this IRQ in the host does not prevent normal operation. */ - error_report_err(err); + warn_report_err(err); } return;
vfio_ccw_register_irq_notifier() and vfio_ap_register_irq_notifier() errors are currently reported using error_report_err(). Since they are not considered as failing conditions, using warn_report_err() is more appropriate. Signed-off-by: Cédric Le Goater <clg@redhat.com> --- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)