| Message ID | 20240619093508.2528537-3-jamin_lin@aspeedtech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix coverity issues for AST2700 | expand |
On 6/19/24 11:35 AM, Jamin Lin wrote: > Fix coverity defect: Control flow issues (DEADCODE) aspeed/sdmc: Remove extra R_MAIN_STATUS case Coverity reports that the newly added 'case R_MAIN_STATUS' is DEADCODE because it can not be reached. This is because R_MAIN_STATUS is handled before in the "Unprotected registers" switch statement. Remove it. Fixes: Coverity CID 1547112 with that, Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> > --- > hw/misc/aspeed_sdmc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c > index 93e2e29ead..94eed9264d 100644 > --- a/hw/misc/aspeed_sdmc.c > +++ b/hw/misc/aspeed_sdmc.c > @@ -589,7 +589,6 @@ static void aspeed_2700_sdmc_write(AspeedSDMCState *s, uint32_t reg, > case R_INT_STATUS: > case R_INT_CLEAR: > case R_INT_MASK: > - case R_MAIN_STATUS: > case R_ERR_STATUS: > case R_ECC_FAIL_STATUS: > case R_ECC_FAIL_ADDR:
diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c index 93e2e29ead..94eed9264d 100644 --- a/hw/misc/aspeed_sdmc.c +++ b/hw/misc/aspeed_sdmc.c @@ -589,7 +589,6 @@ static void aspeed_2700_sdmc_write(AspeedSDMCState *s, uint32_t reg, case R_INT_STATUS: case R_INT_CLEAR: case R_INT_MASK: - case R_MAIN_STATUS: case R_ERR_STATUS: case R_ECC_FAIL_STATUS: case R_ECC_FAIL_ADDR:
Fix coverity defect: Control flow issues (DEADCODE) Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- hw/misc/aspeed_sdmc.c | 1 - 1 file changed, 1 deletion(-)