[PULL,01/16] hw/vfio/container: Fix SIGSEV on vfio_container_instance_finalize()

Commit Message

Cédric Le Goater July 23, 2024, 2 p.m. UTC

From: Eric Auger <[e-mail]>

In vfio_connect_container's error path, the base container is
removed twice form the VFIOAddressSpace QLIST: first on the
listener_release_exit label and second, on free_container_exit
label, through object_unref(container), which calls
vfio_container_instance_finalize().

Let's remove the first instance.

Fixes: 938026053f4 ("vfio/container: Switch to QOM")
Signed-off-by: Eric Auger <[e-mail]>
Reviewed-by: Cédric Le Goater <[e-mail]>
Reviewed-by: Zhenzhong Duan <[e-mail]>
---
 hw/vfio/container.c | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/hw/vfio/container.c b/hw/vfio/container.c
index 38a9df34964a4e5a4d349c14d54f66585728d5ca..ce9a858e56218a9e9c803b4f5cf4c9f7cfc4edda 100644
--- a/hw/vfio/container.c
+++ b/hw/vfio/container.c
@@ -656,7 +656,6 @@  static bool vfio_connect_container(VFIOGroup *group, AddressSpace *as,
     return true;
 listener_release_exit:
     QLIST_REMOVE(group, container_next);
-    QLIST_REMOVE(bcontainer, next);
     vfio_kvm_device_del_group(group);
     memory_listener_unregister(&bcontainer->listener);
     if (vioc->release) {