diff mbox series

[3/7] target/ppc: Fix mtDPDES targeting SMT siblings

Message ID 20240806131318.275109-4-npiggin@gmail.com (mailing list archive)
State New, archived
Headers show
Series various ppc fixes | expand

Commit Message

Nicholas Piggin Aug. 6, 2024, 1:13 p.m. UTC 
A typo in the loop over SMT threads to set irq level for doorbells
when storing to DPDES meant everything was aimed at the CPU executing
the instruction.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 target/ppc/misc_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Aug. 6, 2024, 1:34 p.m. UTC | #1 
On 6/8/24 15:13, Nicholas Piggin wrote:
> A typo in the loop over SMT threads to set irq level for doorbells
> when storing to DPDES meant everything was aimed at the CPU executing
> the instruction.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
>   target/ppc/misc_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Fixes: d24e80b2ae ("target/ppc: Add msgsnd/p and DPDES SMT support")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
index 1b83971375..f0ca80153b 100644
--- a/target/ppc/misc_helper.c
+++ b/target/ppc/misc_helper.c
@@ -288,7 +288,7 @@  void helper_store_dpdes(CPUPPCState *env, target_ulong val)
         PowerPCCPU *ccpu = POWERPC_CPU(ccs);
         uint32_t thread_id = ppc_cpu_tir(ccpu);
 
-        ppc_set_irq(cpu, PPC_INTERRUPT_DOORBELL, val & (0x1 << thread_id));
+        ppc_set_irq(ccpu, PPC_INTERRUPT_DOORBELL, val & (0x1 << thread_id));
     }
     bql_unlock();
 }