| Message ID | 20240829185527.47152-1-kwolf@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | raw-format: Fix error message for invalid offset/size | expand |
On Thu, Aug 29, 2024 at 08:55:27PM +0200, Kevin Wolf wrote: > s->offset and s->size are only set at the end of the function and still > contain the old values when formatting the error message. Print the > parameters with the new values that we actually checked instead. > > Fixes: 500e2434207d ('raw-format: Split raw_read_options()') > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > block/raw-format.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
On 29.08.24 20:55, Kevin Wolf wrote: > s->offset and s->size are only set at the end of the function and still > contain the old values when formatting the error message. Print the > parameters with the new values that we actually checked instead. > > Fixes: 500e2434207d ('raw-format: Split raw_read_options()') > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > block/raw-format.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
29.08.2024 21:55, Kevin Wolf wrote: > s->offset and s->size are only set at the end of the function and still > contain the old values when formatting the error message. Print the > parameters with the new values that we actually checked instead. > > Fixes: 500e2434207d ('raw-format: Split raw_read_options()') > Signed-off-by: Kevin Wolf <kwolf@redhat.com> I picked this up for stable. It's not a big deal but the change is trivial too. JFYI, /mjt
diff --git a/block/raw-format.c b/block/raw-format.c index ac7e8495f6..e08526e2ec 100644 --- a/block/raw-format.c +++ b/block/raw-format.c @@ -111,7 +111,7 @@ raw_apply_options(BlockDriverState *bs, BDRVRawState *s, uint64_t offset, if (offset > real_size) { error_setg(errp, "Offset (%" PRIu64 ") cannot be greater than " "size of the containing file (%" PRId64 ")", - s->offset, real_size); + offset, real_size); return -EINVAL; } @@ -119,7 +119,7 @@ raw_apply_options(BlockDriverState *bs, BDRVRawState *s, uint64_t offset, error_setg(errp, "The sum of offset (%" PRIu64 ") and size " "(%" PRIu64 ") has to be smaller or equal to the " " actual size of the containing file (%" PRId64 ")", - s->offset, s->size, real_size); + offset, size, real_size); return -EINVAL; }
s->offset and s->size are only set at the end of the function and still contain the old values when formatting the error message. Print the parameters with the new values that we actually checked instead. Fixes: 500e2434207d ('raw-format: Split raw_read_options()') Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- block/raw-format.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)