| Message ID | 20240923093016.66437-13-shentey@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | E500 Cleanup | expand |
On Mon, 23 Sep 2024, Bernhard Beschow wrote: > Prefer a macro rather than a string literal when instantiaging device models. > > Signed-off-by: Bernhard Beschow <shentey@gmail.com> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > hw/pci-host/ppce500.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c > index 97e5d47cec..d7ff2ba778 100644 > --- a/hw/pci-host/ppce500.c > +++ b/hw/pci-host/ppce500.c > @@ -475,7 +475,7 @@ static void e500_pcihost_realize(DeviceState *dev, Error **errp) > address_space_init(&s->bm_as, &s->bm, "pci-bm"); > pci_setup_iommu(b, &ppce500_iommu_ops, s); > > - pci_create_simple(b, 0, "e500-host-bridge"); > + pci_create_simple(b, 0, TYPE_PPC_E500_PCI_BRIDGE); > > memory_region_init(&s->container, OBJECT(h), "pci-container", PCIE500_ALL_SIZE); > memory_region_init_io(&h->conf_mem, OBJECT(h), &pci_host_conf_be_ops, h, >
diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c index 97e5d47cec..d7ff2ba778 100644 --- a/hw/pci-host/ppce500.c +++ b/hw/pci-host/ppce500.c @@ -475,7 +475,7 @@ static void e500_pcihost_realize(DeviceState *dev, Error **errp) address_space_init(&s->bm_as, &s->bm, "pci-bm"); pci_setup_iommu(b, &ppce500_iommu_ops, s); - pci_create_simple(b, 0, "e500-host-bridge"); + pci_create_simple(b, 0, TYPE_PPC_E500_PCI_BRIDGE); memory_region_init(&s->container, OBJECT(h), "pci-container", PCIE500_ALL_SIZE); memory_region_init_io(&h->conf_mem, OBJECT(h), &pci_host_conf_be_ops, h,
Prefer a macro rather than a string literal when instantiaging device models. Signed-off-by: Bernhard Beschow <shentey@gmail.com> --- hw/pci-host/ppce500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)