tests/unit: Add a assert for test_io_channel_unix_listen_cleanup

Commit Message

Kunwu Oct. 10, 2024, 2:34 a.m. UTC

Calling bind without checking return value. Add a assert for it.

Signed-off-by: Kunwu <[e-mail]>
---
 tests/unit/test-io-channel-socket.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Daniel P. Berrangé Oct. 10, 2024, 12:41 p.m. UTC | #1

On Thu, Oct 10, 2024 at 10:34:55AM +0800, Kunwu wrote:
> Calling bind without checking return value. Add a assert for it.
> 
> Signed-off-by: Kunwu <[e-mail]>
> ---
>  tests/unit/test-io-channel-socket.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <[e-mail]>

and queued.

With regards,
Daniel

Patch

diff --git a/tests/unit/test-io-channel-socket.c b/tests/unit/test-io-channel-socket.c
index b964bb202d..dc7be96e9c 100644
--- a/tests/unit/test-io-channel-socket.c
+++ b/tests/unit/test-io-channel-socket.c
@@ -506,7 +506,7 @@  static void test_io_channel_unix_listen_cleanup(void)
 {
     QIOChannelSocket *ioc;
     struct sockaddr_un un;
-    int sock;
+    int sock, ret = 0;
 
 #define TEST_SOCKET "test-io-channel-socket.sock"
 
@@ -519,7 +519,9 @@  static void test_io_channel_unix_listen_cleanup(void)
     un.sun_family = AF_UNIX;
     snprintf(un.sun_path, sizeof(un.sun_path), "%s", TEST_SOCKET);
     unlink(TEST_SOCKET);
-    bind(sock, (struct sockaddr *)&un, sizeof(un));
+    ret = bind(sock, (struct sockaddr *)&un, sizeof(un));
+    g_assert_cmpint(ret, ==, 0);
+
     ioc->fd = sock;
     ioc->localAddrLen = sizeof(ioc->localAddr);
     getsockname(sock, (struct sockaddr *)&ioc->localAddr,