diff mbox series

[02/16] meson: remove repeated search for rust_root_crate.sh

Message ID 20241015131735.518771-3-pbonzini@redhat.com (mailing list archive)
State New, archived
Headers show
Series rust: allow older versions of rustc and bindgen | expand

Commit Message

Paolo Bonzini Oct. 15, 2024, 1:17 p.m. UTC
Avoid repeated lines of the form

Program scripts/rust/rust_root_crate.sh found: YES (/home/pbonzini/work/upstream/qemu/scripts/rust/rust_root_crate.sh)

in the meson logs.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Junjie Mao Oct. 16, 2024, 6:50 a.m. UTC | #1
Paolo Bonzini <pbonzini@redhat.com> writes:

> Avoid repeated lines of the form
>
> Program scripts/rust/rust_root_crate.sh found: YES (/home/pbonzini/work/upstream/qemu/scripts/rust/rust_root_crate.sh)
>
> in the meson logs.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Junjie Mao <junjie.mao@hotmail.com>

Thanks for cleaning this up!

--
Best Regards
Junjie Mao
Zhao Liu Oct. 18, 2024, 3:16 p.m. UTC | #2
On Tue, Oct 15, 2024 at 03:17:20PM +0200, Paolo Bonzini wrote:
> Date: Tue, 15 Oct 2024 15:17:20 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 02/16] meson: remove repeated search for rust_root_crate.sh
> X-Mailer: git-send-email 2.46.2
> 
> Avoid repeated lines of the form
> 
> Program scripts/rust/rust_root_crate.sh found: YES (/home/pbonzini/work/upstream/qemu/scripts/rust/rust_root_crate.sh)
> 
> in the meson logs.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index c2e736d2051..37f94ab32aa 100644
--- a/meson.build
+++ b/meson.build
@@ -3977,6 +3977,7 @@  endif
 
 
 feature_to_c = find_program('scripts/feature_to_c.py')
+rust_root_crate = find_program('scripts/rust/rust_root_crate.sh')
 
 if host_os == 'darwin'
   entitlement = find_program('scripts/entitlement.sh')
@@ -4078,7 +4079,7 @@  foreach target : target_dirs
     if crates.length() > 0
       rlib_rs = custom_target('rust_' + target.underscorify() + '.rs',
                               output: 'rust_' + target.underscorify() + '.rs',
-                              command: [find_program('scripts/rust/rust_root_crate.sh')] + crates,
+                              command: [rust_root_crate, crates],
                               capture: true,
                               build_by_default: true,
                               build_always_stale: true)