| Message ID | 20241024213056.1395400-4-peterx@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Migration: Make misc.h helpers available for whole VM lifecycle | expand |
On 10/24/24 23:30, Peter Xu wrote: > It's only used within migration/. > > Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > include/migration/misc.h | 1 - > migration/ram.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/migration/misc.h b/include/migration/misc.h > index df57be6b5e..e8490e3af5 100644 > --- a/include/migration/misc.h > +++ b/include/migration/misc.h > @@ -39,7 +39,6 @@ void precopy_add_notifier(NotifierWithReturn *n); > void precopy_remove_notifier(NotifierWithReturn *n); > int precopy_notify(PrecopyNotifyReason reason, Error **errp); > > -void ram_mig_init(void); > void qemu_guest_free_page_hint(void *addr, size_t len); > bool migrate_ram_is_ignored(RAMBlock *block); > > diff --git a/migration/ram.h b/migration/ram.h > index bc0318b834..0d1981f888 100644 > --- a/migration/ram.h > +++ b/migration/ram.h > @@ -44,6 +44,7 @@ extern XBZRLECacheStats xbzrle_counters; > INTERNAL_RAMBLOCK_FOREACH(block) \ > if (!qemu_ram_is_migratable(block)) {} else > > +void ram_mig_init(void); > int xbzrle_cache_resize(uint64_t new_size, Error **errp); > uint64_t ram_bytes_remaining(void); > uint64_t ram_bytes_total(void);
Peter Xu <peterx@redhat.com> writes: > It's only used within migration/. > > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > include/migration/misc.h | 1 - > migration/ram.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/migration/misc.h b/include/migration/misc.h > index df57be6b5e..e8490e3af5 100644 > --- a/include/migration/misc.h > +++ b/include/migration/misc.h > @@ -39,7 +39,6 @@ void precopy_add_notifier(NotifierWithReturn *n); > void precopy_remove_notifier(NotifierWithReturn *n); > int precopy_notify(PrecopyNotifyReason reason, Error **errp); > > -void ram_mig_init(void); > void qemu_guest_free_page_hint(void *addr, size_t len); > bool migrate_ram_is_ignored(RAMBlock *block); > > diff --git a/migration/ram.h b/migration/ram.h > index bc0318b834..0d1981f888 100644 > --- a/migration/ram.h > +++ b/migration/ram.h > @@ -44,6 +44,7 @@ extern XBZRLECacheStats xbzrle_counters; > INTERNAL_RAMBLOCK_FOREACH(block) \ > if (!qemu_ram_is_migratable(block)) {} else > > +void ram_mig_init(void); > int xbzrle_cache_resize(uint64_t new_size, Error **errp); > uint64_t ram_bytes_remaining(void); > uint64_t ram_bytes_total(void); Reviewed-by: Fabiano Rosas <farosas@suse.de>
diff --git a/include/migration/misc.h b/include/migration/misc.h index df57be6b5e..e8490e3af5 100644 --- a/include/migration/misc.h +++ b/include/migration/misc.h @@ -39,7 +39,6 @@ void precopy_add_notifier(NotifierWithReturn *n); void precopy_remove_notifier(NotifierWithReturn *n); int precopy_notify(PrecopyNotifyReason reason, Error **errp); -void ram_mig_init(void); void qemu_guest_free_page_hint(void *addr, size_t len); bool migrate_ram_is_ignored(RAMBlock *block); diff --git a/migration/ram.h b/migration/ram.h index bc0318b834..0d1981f888 100644 --- a/migration/ram.h +++ b/migration/ram.h @@ -44,6 +44,7 @@ extern XBZRLECacheStats xbzrle_counters; INTERNAL_RAMBLOCK_FOREACH(block) \ if (!qemu_ram_is_migratable(block)) {} else +void ram_mig_init(void); int xbzrle_cache_resize(uint64_t new_size, Error **errp); uint64_t ram_bytes_remaining(void); uint64_t ram_bytes_total(void);
It's only used within migration/. Signed-off-by: Peter Xu <peterx@redhat.com> --- include/migration/misc.h | 1 - migration/ram.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)