| Message ID | 20241120163046.3661675-1-peterx@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ahci: Add comment for possible slowness on ahci_irq_lower() | expand |
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 0eb24304ee..7ddcc4e37c 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -197,6 +197,11 @@ static void ahci_irq_raise(AHCIState *s) static void ahci_irq_lower(AHCIState *s) { DeviceState *dev_state = s->container; + /* + * NOTE: from some profiling on Linux VM boots, this can trigger quite + * frequently (10000+ when seeing the root prompt). It might be good to + * consider speeding this path up on the type cast. + */ PCIDevice *pci_dev = (PCIDevice *) object_dynamic_cast(OBJECT(dev_state), TYPE_PCI_DEVICE);
In some adhoc profiling, it's observed that ahci_irq_lower() can be a hot path and the type cast might be slow and prone to optimizations. Considering it's in ODD FIXES stage, we may not expect major time consumed yet on this on either developing efforts, or reviewing efforts from maintainers. However still add a comment as suggested by Paolo so we keep it a record for future reference. Cc: John Snow <jsnow@redhat.com> Link: https://lore.kernel.org/r/CABgObfbXuiqw01mzVLZEgw-o_tdbf83QzYugq7oL4g7TFVV_yg@mail.gmail.com Suggested-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Peter Xu <peterx@redhat.com> --- hw/ide/ahci.c | 5 +++++ 1 file changed, 5 insertions(+)