| Message ID | 20241121165806.476008-13-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | maintainer updates for -rc2 pre-PR | expand |
On 21/11/2024 17.57, Alex Bennée wrote: > From: Daniel P. Berrangé <berrange@redhat.com> > > When functional tests go wrong, it will often be related to the console > interaction wait state. By logging the messages that we're looking for, > and data we're about to be sending, it'll be easier to diagnose where > tests are getting stuck. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > Message-Id: <20241121154218.1423005-13-berrange@redhat.com> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/functional/qemu_test/cmd.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/functional/qemu_test/cmd.py b/tests/functional/qemu_test/cmd.py > index cbabb1ceed..98722a9cf6 100644 > --- a/tests/functional/qemu_test/cmd.py > +++ b/tests/functional/qemu_test/cmd.py > @@ -85,6 +85,9 @@ def _console_interaction(test, success_message, failure_message, > vm = test.vm > console = vm.console_file > console_logger = logging.getLogger('console') > + test.log.debug( > + f"Console interaction: success_msg='{success_message}' " + > + f"failure_msg='{failure_message}' send_string='{send_string}'") > while True: > if send_string: > vm.console_socket.sendall(send_string.encode()) Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/functional/qemu_test/cmd.py b/tests/functional/qemu_test/cmd.py index cbabb1ceed..98722a9cf6 100644 --- a/tests/functional/qemu_test/cmd.py +++ b/tests/functional/qemu_test/cmd.py @@ -85,6 +85,9 @@ def _console_interaction(test, success_message, failure_message, vm = test.vm console = vm.console_file console_logger = logging.getLogger('console') + test.log.debug( + f"Console interaction: success_msg='{success_message}' " + + f"failure_msg='{failure_message}' send_string='{send_string}'") while True: if send_string: vm.console_socket.sendall(send_string.encode())