| Message ID | 20241203092153.60590-2-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | cli: Remove mentions of legacy '-machine foo, accel=bar' command line | expand |
On Tue, Dec 03, 2024 at 10:21:47AM +0100, Philippe Mathieu-Daudé wrote: > Since commit 6f6e1698a68 ("vl: configure accelerators from -accel > options") we prefer the '-accel bar' command line option. > > Replace '-machine foo,accel=bar' -> '-machine foo -accel bar' in > functional tests. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > tests/functional/test_ppc64_hv.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel
On 03/12/2024 10.21, Philippe Mathieu-Daudé wrote: > Since commit 6f6e1698a68 ("vl: configure accelerators from -accel > options") we prefer the '-accel bar' command line option. > > Replace '-machine foo,accel=bar' -> '-machine foo -accel bar' in > functional tests. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > tests/functional/test_ppc64_hv.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/functional/test_ppc64_hv.py b/tests/functional/test_ppc64_hv.py > index 312248bbfe4..536a433b993 100755 > --- a/tests/functional/test_ppc64_hv.py > +++ b/tests/functional/test_ppc64_hv.py > @@ -138,7 +138,8 @@ def do_test_kvm(self, hpt=False): > else: > append = '' > exec_command(self, 'qemu-system-ppc64 -nographic -smp 2 -m 1g ' > - '-machine pseries,x-vof=on,accel=kvm ' > + '-accel kvm ' > + '-machine pseries,x-vof=on ' > '-machine cap-cfpc=broken,cap-sbbc=broken,' > 'cap-ibs=broken,cap-ccf-assist=off ' > '-drive file=/dev/nvme0n1,format=raw,readonly=on ' Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/functional/test_ppc64_hv.py b/tests/functional/test_ppc64_hv.py index 312248bbfe4..536a433b993 100755 --- a/tests/functional/test_ppc64_hv.py +++ b/tests/functional/test_ppc64_hv.py @@ -138,7 +138,8 @@ def do_test_kvm(self, hpt=False): else: append = '' exec_command(self, 'qemu-system-ppc64 -nographic -smp 2 -m 1g ' - '-machine pseries,x-vof=on,accel=kvm ' + '-accel kvm ' + '-machine pseries,x-vof=on ' '-machine cap-cfpc=broken,cap-sbbc=broken,' 'cap-ibs=broken,cap-ccf-assist=off ' '-drive file=/dev/nvme0n1,format=raw,readonly=on '
Since commit 6f6e1698a68 ("vl: configure accelerators from -accel options") we prefer the '-accel bar' command line option. Replace '-machine foo,accel=bar' -> '-machine foo -accel bar' in functional tests. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- tests/functional/test_ppc64_hv.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)