| Message ID | 20241211230357.97036-4-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | misc: Reduce 'exec/tswap.h' inclusions | expand |
On 12/11/24 17:03, Philippe Mathieu-Daudé wrote: > translator.c indirectly gets "exec/tswap.h" declarations via > "exec/cpu-all.h". Include it directly to be able to remove the > former from the latter, otherwise we get: > > accel/tcg/translator.c:433:15: error: call to undeclared function 'tswap16'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > 433 | tgt = tswap16(raw); > | ^ > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > accel/tcg/translator.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index cbad00a5172..ff5dabc9014 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.c @@ -15,6 +15,7 @@ #include "exec/cpu_ldst.h" #include "exec/plugin-gen.h" #include "exec/cpu_ldst.h" +#include "exec/tswap.h" #include "tcg/tcg-op-common.h" #include "internal-target.h" #include "disas/disas.h"
translator.c indirectly gets "exec/tswap.h" declarations via "exec/cpu-all.h". Include it directly to be able to remove the former from the latter, otherwise we get: accel/tcg/translator.c:433:15: error: call to undeclared function 'tswap16'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 433 | tgt = tswap16(raw); | ^ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- accel/tcg/translator.c | 1 + 1 file changed, 1 insertion(+)