diff mbox series

[RFC,02/11] target/ppc: replace tcg_gen_qemu_ld_tl() with gen_ld_tl()

Message ID 20241212151412.570454-3-mark.cave-ayland@ilande.co.uk (mailing list archive)
State New
Headers show
Series target/ppc: implement legacy address-swizzling MSR_LE support | expand

Commit Message

Mark Cave-Ayland Dec. 12, 2024, 3:14 p.m. UTC 
To ensure that all memory loads are performed by gen_ld_tl(), convert all
remaining users of tcg_gen_qemu_ld_tl() with gen_ld_tl().

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 target/ppc/translate.c                     | 14 +++++++-------
 target/ppc/translate/fixedpoint-impl.c.inc |  2 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Richard Henderson Dec. 12, 2024, 3:26 p.m. UTC | #1 
On 12/12/24 09:14, Mark Cave-Ayland wrote:
> To ensure that all memory loads are performed by gen_ld_tl(), convert all
> remaining users of tcg_gen_qemu_ld_tl() with gen_ld_tl().
> 
> Signed-off-by: Mark Cave-Ayland<mark.cave-ayland@ilande.co.uk>
> ---
>   target/ppc/translate.c                     | 14 +++++++-------
>   target/ppc/translate/fixedpoint-impl.c.inc |  2 +-
>   2 files changed, 8 insertions(+), 8 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
diff mbox series

Patch

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 5ddaf69599..5fb0aa36ce 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -2675,7 +2675,7 @@  static void glue(gen_, name##epx)(DisasContext *ctx)                          \
     gen_set_access_type(ctx, ACCESS_INT);                                     \
     EA = tcg_temp_new();                                                      \
     gen_addr_reg_index(ctx, EA);                                              \
-    tcg_gen_qemu_ld_tl(cpu_gpr[rD(ctx->opcode)], EA, PPC_TLB_EPID_LOAD, ldop);\
+    gen_ld_tl(ctx, cpu_gpr[rD(ctx->opcode)], EA, PPC_TLB_EPID_LOAD, ldop);    \
 }
 
 GEN_LDEPX(lb, DEF_MEMOP(MO_UB), 0x1F, 0x02)
@@ -2942,7 +2942,7 @@  static void gen_load_locked(DisasContext *ctx, MemOp memop)
 
     gen_set_access_type(ctx, ACCESS_RES);
     gen_addr_reg_index(ctx, t0);
-    tcg_gen_qemu_ld_tl(gpr, t0, ctx->mem_idx, DEF_MEMOP(memop) | MO_ALIGN);
+    gen_ld_tl(ctx, gpr, t0, ctx->mem_idx, DEF_MEMOP(memop) | MO_ALIGN);
     tcg_gen_mov_tl(cpu_reserve, t0);
     tcg_gen_movi_tl(cpu_reserve_length, memop_size(memop));
     tcg_gen_mov_tl(cpu_reserve_val, gpr);
@@ -2966,9 +2966,9 @@  static void gen_fetch_inc_conditional(DisasContext *ctx, MemOp memop,
     TCGv t2 = tcg_temp_new();
     TCGv u = tcg_temp_new();
 
-    tcg_gen_qemu_ld_tl(t, EA, ctx->mem_idx, memop);
+    gen_ld_tl(ctx, t, EA, ctx->mem_idx, memop);
     tcg_gen_addi_tl(t2, EA, memop_size(memop));
-    tcg_gen_qemu_ld_tl(t2, t2, ctx->mem_idx, memop);
+    gen_ld_tl(ctx, t2, t2, ctx->mem_idx, memop);
     tcg_gen_addi_tl(u, t, addend);
 
     /* E.g. for fetch and increment bounded... */
@@ -3031,7 +3031,7 @@  static void gen_ld_atomic(DisasContext *ctx, MemOp memop)
             TCGv t0 = tcg_temp_new();
             TCGv t1 = tcg_temp_new();
 
-            tcg_gen_qemu_ld_tl(t0, EA, ctx->mem_idx, memop);
+            gen_ld_tl(ctx, t0, EA, ctx->mem_idx, memop);
             if ((memop & MO_SIZE) == MO_64 || TARGET_LONG_BITS == 32) {
                 tcg_gen_mov_tl(t1, src);
             } else {
@@ -3138,9 +3138,9 @@  static void gen_st_atomic(DisasContext *ctx, MemOp memop)
             TCGv s2 = tcg_temp_new();
             TCGv ea_plus_s = tcg_temp_new();
 
-            tcg_gen_qemu_ld_tl(t, EA, ctx->mem_idx, memop);
+            gen_ld_tl(ctx, t, EA, ctx->mem_idx, memop);
             tcg_gen_addi_tl(ea_plus_s, EA, memop_size(memop));
-            tcg_gen_qemu_ld_tl(t2, ea_plus_s, ctx->mem_idx, memop);
+            gen_ld_tl(ctx, t2, ea_plus_s, ctx->mem_idx, memop);
             tcg_gen_movcond_tl(TCG_COND_EQ, s, t, t2, src, t);
             tcg_gen_movcond_tl(TCG_COND_EQ, s2, t, t2, src, t2);
             tcg_gen_qemu_st_tl(s, EA, ctx->mem_idx, memop);
diff --git a/target/ppc/translate/fixedpoint-impl.c.inc b/target/ppc/translate/fixedpoint-impl.c.inc
index fa0191e866..717e3f122f 100644
--- a/target/ppc/translate/fixedpoint-impl.c.inc
+++ b/target/ppc/translate/fixedpoint-impl.c.inc
@@ -37,7 +37,7 @@  static bool do_ldst(DisasContext *ctx, int rt, int ra, TCGv displ, bool update,
     if (store) {
         tcg_gen_qemu_st_tl(cpu_gpr[rt], ea, ctx->mem_idx, mop);
     } else {
-        tcg_gen_qemu_ld_tl(cpu_gpr[rt], ea, ctx->mem_idx, mop);
+        gen_ld_tl(ctx, cpu_gpr[rt], ea, ctx->mem_idx, mop);
     }
     if (update) {
         tcg_gen_mov_tl(cpu_gpr[ra], ea);