diff mbox series

[PULL,11/11] system: Inline machine_containers[] in qemu_create_machine_containers()

Message ID 20250109171948.31092-12-philmd@linaro.org (mailing list archive)
State New
Headers show
Series [PULL,01/11] hw/pci: Use -1 as the default value for rombar | expand

Commit Message

Philippe Mathieu-Daudé Jan. 9, 2025, 5:19 p.m. UTC
Only qemu_create_machine_containers() uses the
machine_containers[] array, restrict the scope
to this single user.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250102211800.79235-9-philmd@linaro.org>
---
 system/vl.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)
diff mbox series

Patch

diff --git a/system/vl.c b/system/vl.c
index ed1623b26b9..be029c52ef8 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -2113,18 +2113,16 @@  static void parse_memory_options(void)
     loc_pop(&loc);
 }
 
-static const char *const machine_containers[] = {
-    "unattached",
-    "peripheral",
-    "peripheral-anon"
-};
-
 static void qemu_create_machine_containers(Object *machine)
 {
-    int i;
+    static const char *const containers[] = {
+        "unattached",
+        "peripheral",
+        "peripheral-anon",
+    };
 
-    for (i = 0; i < ARRAY_SIZE(machine_containers); i++) {
-        object_property_add_new_container(machine, machine_containers[i]);
+    for (unsigned i = 0; i < ARRAY_SIZE(containers); i++) {
+        object_property_add_new_container(machine, containers[i]);
     }
 }