| Message ID | 20250228102747.867770-6-pbonzini@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/riscv: declarative CPU definitions | expand |
On Fri, Feb 28, 2025 at 8:33 PM Paolo Bonzini <pbonzini@redhat.com> wrote: > > Since all TYPE_RISCV_CPU subclasses support a class_data of type > RISCVCPUDef, process it even before calling the .class_init function > for the subclasses. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > target/riscv/cpu.c | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 51acce07752..91dd63edc9f 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -2967,15 +2967,18 @@ static void riscv_cpu_class_base_init(ObjectClass *c, void *data) > } else { > mcc->def = g_new0(RISCVCPUDef, 1); > } > -} > > -static void riscv_cpu_class_init(ObjectClass *c, void *data) > -{ > - RISCVCPUClass *mcc = RISCV_CPU_CLASS(c); > - const RISCVCPUDef *def = data; > + if (data) { > + const RISCVCPUDef *def = data; > + if (def->misa_mxl_max) { > + assert(def->misa_mxl_max <= MXL_RV128); > + mcc->def->misa_mxl_max = def->misa_mxl_max; > + } > + } > > - mcc->def->misa_mxl_max = def->misa_mxl_max; > - riscv_cpu_validate_misa_mxl(mcc); > + if (!object_class_is_abstract(c)) { > + riscv_cpu_validate_misa_mxl(mcc); > + } > } > > static void riscv_isa_string_ext(RISCVCPU *cpu, char **isa_str, > @@ -3075,7 +3078,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename) > .name = (type_name), \ > .parent = TYPE_RISCV_DYNAMIC_CPU, \ > .instance_init = (initfn), \ > - .class_init = riscv_cpu_class_init, \ > .class_data = (void*) &((const RISCVCPUDef) { \ > .misa_mxl_max = (misa_mxl_max_), \ > }), \ > @@ -3086,7 +3088,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename) > .name = (type_name), \ > .parent = TYPE_RISCV_VENDOR_CPU, \ > .instance_init = (initfn), \ > - .class_init = riscv_cpu_class_init, \ > .class_data = (void*) &((const RISCVCPUDef) { \ > .misa_mxl_max = (misa_mxl_max_), \ > }), \ > @@ -3097,7 +3098,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename) > .name = (type_name), \ > .parent = TYPE_RISCV_BARE_CPU, \ > .instance_init = (initfn), \ > - .class_init = riscv_cpu_class_init, \ > .class_data = (void*) &((const RISCVCPUDef) { \ > .misa_mxl_max = (misa_mxl_max_), \ > }), \ > @@ -3108,7 +3108,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename) > .name = (type_name), \ > .parent = TYPE_RISCV_BARE_CPU, \ > .instance_init = (initfn), \ > - .class_init = riscv_cpu_class_init, \ > .class_data = (void*) &((const RISCVCPUDef) { \ > .misa_mxl_max = (misa_mxl_max_), \ > }), \ > -- > 2.48.1 > >
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 51acce07752..91dd63edc9f 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -2967,15 +2967,18 @@ static void riscv_cpu_class_base_init(ObjectClass *c, void *data) } else { mcc->def = g_new0(RISCVCPUDef, 1); } -} -static void riscv_cpu_class_init(ObjectClass *c, void *data) -{ - RISCVCPUClass *mcc = RISCV_CPU_CLASS(c); - const RISCVCPUDef *def = data; + if (data) { + const RISCVCPUDef *def = data; + if (def->misa_mxl_max) { + assert(def->misa_mxl_max <= MXL_RV128); + mcc->def->misa_mxl_max = def->misa_mxl_max; + } + } - mcc->def->misa_mxl_max = def->misa_mxl_max; - riscv_cpu_validate_misa_mxl(mcc); + if (!object_class_is_abstract(c)) { + riscv_cpu_validate_misa_mxl(mcc); + } } static void riscv_isa_string_ext(RISCVCPU *cpu, char **isa_str, @@ -3075,7 +3078,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename) .name = (type_name), \ .parent = TYPE_RISCV_DYNAMIC_CPU, \ .instance_init = (initfn), \ - .class_init = riscv_cpu_class_init, \ .class_data = (void*) &((const RISCVCPUDef) { \ .misa_mxl_max = (misa_mxl_max_), \ }), \ @@ -3086,7 +3088,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename) .name = (type_name), \ .parent = TYPE_RISCV_VENDOR_CPU, \ .instance_init = (initfn), \ - .class_init = riscv_cpu_class_init, \ .class_data = (void*) &((const RISCVCPUDef) { \ .misa_mxl_max = (misa_mxl_max_), \ }), \ @@ -3097,7 +3098,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename) .name = (type_name), \ .parent = TYPE_RISCV_BARE_CPU, \ .instance_init = (initfn), \ - .class_init = riscv_cpu_class_init, \ .class_data = (void*) &((const RISCVCPUDef) { \ .misa_mxl_max = (misa_mxl_max_), \ }), \ @@ -3108,7 +3108,6 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename) .name = (type_name), \ .parent = TYPE_RISCV_BARE_CPU, \ .instance_init = (initfn), \ - .class_init = riscv_cpu_class_init, \ .class_data = (void*) &((const RISCVCPUDef) { \ .misa_mxl_max = (misa_mxl_max_), \ }), \
Since all TYPE_RISCV_CPU subclasses support a class_data of type RISCVCPUDef, process it even before calling the .class_init function for the subclasses. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- target/riscv/cpu.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-)