From patchwork Sat Mar 1 05:28:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Cain X-Patchwork-Id: 13997347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88E9BC282CD for ; Sat, 1 Mar 2025 05:34:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1toFPf-0000km-4i; Sat, 01 Mar 2025 00:29:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1toFPd-0000i1-Rr for qemu-devel@nongnu.org; Sat, 01 Mar 2025 00:29:22 -0500 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1toFPb-0008P6-CM for qemu-devel@nongnu.org; Sat, 01 Mar 2025 00:29:21 -0500 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5214Bom7027112 for ; Sat, 1 Mar 2025 05:29:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9H2JfNRmmuuWCm2TVDdMCermZwoCDf412NpA/UH3RyQ=; b=B2EDfir2W+bdsTrO GxY/CBfdZZ7e9ZeWhRH2JYjO18bmgwlIZ6obi+4xCm7pFEScZXU1dCz3aNx8cLV4 lP8z4WmyJ7OoN+mc3fRVUOpv+pPCh4vQxTdFTE0mmSHEeGRY6QhuqdR6vexEIQwx MztTxe80KE0Mh1oJcRuu/funIDefM6RMuGiLgjjJQT6ufVF591rPW+l/T0ocVDuo hjNA0GU/6mbk4fqHzrBz9B/I/T9AOAJpKwyUj1Hkg1/UBe0Km5aPHdOQezHZRXn3 2ox1NXvzl2GS1YV9ZjRso1+YSXWALCUl1snr/hMt6o+q7cc57FZ5jXrHQcfQ63nk m0tkSQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 453u0d037q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 01 Mar 2025 05:29:08 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2fec3e38b60so2178452a91.0 for ; Fri, 28 Feb 2025 21:29:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740806947; x=1741411747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9H2JfNRmmuuWCm2TVDdMCermZwoCDf412NpA/UH3RyQ=; b=lMjl9vgaBHmauIOdkVQJi4eWO9dguBsAShVcUwLMIW1y6+7mIuTBZ/Bo1Ya5J3DuG4 /OnAnBwOFhryLbLispCOxrbKYuJp7zrbK18oSvTOVRPImAw2BL9+q9NtdEa6FnpikPw6 /zUO51D8QMJrcyQo8prK3XRmpBLx7MLuE6QjlrVYaVxxz+FdQk6IkKDKGOR3ngyLN+Yr IPSPbKQfP9x6Zo39mAEd+ZWyM/4qPD49M9NmZbw2lKOMVhuCyj2Ob4CzVxpW13B9kfn+ sDqWnrRYGW6etS8NoVtVATeWgaSjIR4aZkQhcMva0PY7+SG5Hu6y0Yfdmk8OsGK6lKdr fkDA== X-Gm-Message-State: AOJu0YypthXt1QkBiV9Cm61NyusVwmpqdtAxe4iXYq2D8J5hCsxFxXxy HDS9neQUaAy1kJX8xVAc7eXkgJaNlup1SCPNDxANPvAN63AjEwGZ6P84XCBOS/L0fp8IB8mw4AH JKEuMYgKQVrf4UtUjlAV0a6s8/2LXKt/3hdF2HtUCyzpzL9hZ30iK60ZBPCU1Ow== X-Gm-Gg: ASbGncuap8+bQ0pZfw/FqFwT0nMlE8PHqwL7aL+SzbdXNESv/+cLfo11HH3bGPsLv+I oChg6peZKycfk6oGZbShJY5qWrQCd3oPaFk86UiAipg+FDzboU1u6+W1uy8997tz6exI32BmR/B Xuetk3m6rnwJKWDVI0rRmxkx5wI6oGys19yXkXGfjKPY6632ocpS3tlY/zrrrhtUByZZiLbzgfu AaTKQwwsh42XhJSxhGWOAuTBebavUtIJZn6nt6yuxO8SJvuIA2syZ74xWZIggVXj7+RNTcdPzdR R53C/lFWIFraVqp99WQB8+qFnX9yYdob3vvxAEXq/OBmI/Cb8gVvCezlGMt7wFBK X-Received: by 2002:a17:90b:3f50:b0:2ee:af31:a7bd with SMTP id 98e67ed59e1d1-2febab2bdcbmr9121452a91.5.1740806947127; Fri, 28 Feb 2025 21:29:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwFEpdGle6h21DnBPZTxIoFxVC7S2+nEs/vgJiVDgoMd2J4A5fIPdz1Klg92rYWsZpstT0QQ== X-Received: by 2002:a17:90b:3f50:b0:2ee:af31:a7bd with SMTP id 98e67ed59e1d1-2febab2bdcbmr9121432a91.5.1740806946767; Fri, 28 Feb 2025 21:29:06 -0800 (PST) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fea67a5dc8sm4732955a91.23.2025.02.28.21.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 21:29:06 -0800 (PST) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, richard.henderson@linaro.org, philmd@linaro.org, quic_mathbern@quicinc.com, ale@rev.ng, anjo@rev.ng, quic_mliebel@quicinc.com, ltaylorsimpson@gmail.com, alex.bennee@linaro.org, quic_mburton@quicinc.com, sidneym@quicinc.com, Brian Cain Subject: [PATCH 13/39] target/hexagon: Implement modify_syscfg() Date: Fri, 28 Feb 2025 21:28:19 -0800 Message-Id: <20250301052845.1012069-14-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250301052845.1012069-1-brian.cain@oss.qualcomm.com> References: <20250301052845.1012069-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: uj1R6gyFZCTR2gpfeZuv6rtG4ZxFKpWD X-Proofpoint-GUID: uj1R6gyFZCTR2gpfeZuv6rtG4ZxFKpWD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-01_01,2025-02-28_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 mlxlogscore=556 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503010040 Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Brian Cain Signed-off-by: Brian Cain --- target/hexagon/op_helper.c | 51 +++++++++++++++++++++++++++++++++++++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 03bed11f6e..42805d0f1d 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -1522,7 +1522,56 @@ static bool handle_pmu_sreg_write(CPUHexagonState *env, uint32_t reg, static void modify_syscfg(CPUHexagonState *env, uint32_t val) { - g_assert_not_reached(); + g_assert(bql_locked()); + + uint32_t old; + uint32_t syscfg_read_only_mask = 0x80001c00; + uint32_t syscfg = arch_get_system_reg(env, HEX_SREG_SYSCFG); + + /* clear read-only bits if they are set in the new value. */ + val &= ~syscfg_read_only_mask; + /* if read-only are currently set in syscfg keep them set. */ + val |= (syscfg & syscfg_read_only_mask); + + uint32_t tmp = val; + old = arch_get_system_reg(env, HEX_SREG_SYSCFG); + arch_set_system_reg(env, HEX_SREG_SYSCFG, tmp); + + /* Check for change in MMU enable */ + target_ulong old_mmu_enable = GET_SYSCFG_FIELD(SYSCFG_MMUEN, old); + uint8_t old_en = GET_SYSCFG_FIELD(SYSCFG_PCYCLEEN, old); + uint8_t old_gie = GET_SYSCFG_FIELD(SYSCFG_GIE, old); + target_ulong new_mmu_enable = + GET_SYSCFG_FIELD(SYSCFG_MMUEN, val); + if (new_mmu_enable && !old_mmu_enable) { + hex_mmu_on(env); + } else if (!new_mmu_enable && old_mmu_enable) { + hex_mmu_off(env); + } + + /* Changing pcycle enable from 0 to 1 resets the counters */ + uint8_t new_en = GET_SYSCFG_FIELD(SYSCFG_PCYCLEEN, val); + CPUState *cs; + if (old_en == 0 && new_en == 1) { + CPU_FOREACH(cs) { + CPUHexagonState *_env = cpu_env(cs); + _env->t_cycle_count = 0; + } + } + + /* See if global interrupts are turned on */ + uint8_t new_gie = GET_SYSCFG_FIELD(SYSCFG_GIE, val); + if (!old_gie && new_gie) { + qemu_log_mask(CPU_LOG_INT, "%s: global interrupts enabled\n", __func__); + hex_interrupt_update(env); + } + + if (qemu_loglevel_mask(LOG_UNIMP)) { + int new_v2x = GET_SYSCFG_FIELD(SYSCFG_V2X, val); + if (!new_v2x) { + qemu_log("HVX: 64 byte vector length is unsupported\n"); + } + } } static uint32_t hexagon_find_last_irq(CPUHexagonState *env, uint32_t vid)