| Message ID | 20250303073547.1145080-7-jamin_lin@aspeedtech.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix hw-strap for AST2700 | expand |
On 3/3/25 08:35, Jamin Lin wrote: > Currently, ASPEED_DEV_SPI_BOOT is set to "0x400000000", which is the DRAM start > address, and the QEMU loader is used to load the U-Boot binary into this address. > > However, if users want to install FMC flash contents as a boot ROM, the DRAM > address 0x400000000 would be overwritten with Boot ROM data. This causes the > AST2700 to fail to boot because the U-Boot data becomes incorrect. > > To fix this, change the ASPEED_DEV_SPI_BOOT address to "0x100000000", which is > the FMC0 memory-mapped start address in the AST2700. > > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > hw/arm/aspeed_ast27x0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c > index 8c225d4f90..527a5f8245 100644 > --- a/hw/arm/aspeed_ast27x0.c > +++ b/hw/arm/aspeed_ast27x0.c > @@ -24,7 +24,7 @@ > #include "qemu/log.h" > > static const hwaddr aspeed_soc_ast2700_memmap[] = { > - [ASPEED_DEV_SPI_BOOT] = 0x400000000, > + [ASPEED_DEV_SPI_BOOT] = 0x100000000, > [ASPEED_DEV_SRAM] = 0x10000000, > [ASPEED_DEV_SDMC] = 0x12C00000, > [ASPEED_DEV_SCU] = 0x12C02000,
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index 8c225d4f90..527a5f8245 100644 --- a/hw/arm/aspeed_ast27x0.c +++ b/hw/arm/aspeed_ast27x0.c @@ -24,7 +24,7 @@ #include "qemu/log.h" static const hwaddr aspeed_soc_ast2700_memmap[] = { - [ASPEED_DEV_SPI_BOOT] = 0x400000000, + [ASPEED_DEV_SPI_BOOT] = 0x100000000, [ASPEED_DEV_SRAM] = 0x10000000, [ASPEED_DEV_SDMC] = 0x12C00000, [ASPEED_DEV_SCU] = 0x12C02000,
Currently, ASPEED_DEV_SPI_BOOT is set to "0x400000000", which is the DRAM start address, and the QEMU loader is used to load the U-Boot binary into this address. However, if users want to install FMC flash contents as a boot ROM, the DRAM address 0x400000000 would be overwritten with Boot ROM data. This causes the AST2700 to fail to boot because the U-Boot data becomes incorrect. To fix this, change the ASPEED_DEV_SPI_BOOT address to "0x100000000", which is the FMC0 memory-mapped start address in the AST2700. Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com> --- hw/arm/aspeed_ast27x0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)