From patchwork Tue May 30 16:15:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Maxime Coquelin X-Patchwork-Id: 9754843 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 728BF602BF for ; Tue, 30 May 2017 16:17:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 645E327165 for ; Tue, 30 May 2017 16:17:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 58C4927F07; Tue, 30 May 2017 16:17:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C75C227165 for ; Tue, 30 May 2017 16:17:27 +0000 (UTC) Received: from localhost ([::1]:54906 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFjpn-0002Hk-4E for patchwork-qemu-devel@patchwork.kernel.org; Tue, 30 May 2017 12:17:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFjo6-0001Yt-O2 for qemu-devel@nongnu.org; Tue, 30 May 2017 12:15:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFjo5-0002BX-C6 for qemu-devel@nongnu.org; Tue, 30 May 2017 12:15:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55796) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFjo5-0002BL-34 for qemu-devel@nongnu.org; Tue, 30 May 2017 12:15:41 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57D48654D; Tue, 30 May 2017 16:15:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 57D48654D Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=maxime.coquelin@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 57D48654D Received: from [10.36.112.42] (ovpn-112-42.ams2.redhat.com [10.36.112.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AA2818C55; Tue, 30 May 2017 16:15:31 +0000 (UTC) To: mst@redhat.com, peterx@redhat.com, marcandre.lureau@gmail.com, vkaplans@redhat.com, jasowang@redhat.com, wexu@redhat.com, yuanhan.liu@linux.intel.com, qemu-devel@nongnu.org, jfreiman@redhat.com References: <20170526142858.19931-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <3f97a248-dac2-c260-abf7-42b1a488ac3d@redhat.com> Date: Tue, 30 May 2017 18:15:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170526142858.19931-1-maxime.coquelin@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 30 May 2017 16:15:39 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 0/6] vhost-user: Specify and implement device IOTLB support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi, On 05/26/2017 04:28 PM, Maxime Coquelin wrote: > This series aims at specifying ans implementing the protocol update > required to support device IOTLB with user backends. > > In this second non-RFC version, main changes are: > - spec fixes and clarification > - rings information update has been restored back to ring enablement time > - Work around GCC 4.4.7 limitation wrt assignment in unnamed union at > declaration time. > > The series can be tested with vhost_iotlb_proto_v2 branch on my gitlab > account[0]. > > The slave requests channel part is re-used from Marc-André's series submitted > last year[1], with main changes from original version being request/feature > names renaming and addition of the REPLY_ACK feature support. > > Regarding IOTLB protocol, one noticeable change is the IOTLB miss request > reply made optionnal (i.e. only if slave requests it by setting the > VHOST_USER_NEED_REPLY flag in the message header). This change provides > more flexibility in the backend implementation of the feature. > > The protocol is very close to kernel backends, except that a new > communication channel is introduced to enable the slave to send > requests to the master. > > [0]: https://gitlab.com/mcoquelin/dpdk-next-virtio/commits/vhost_iotlb_proto_v2 > [1]: https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg00095.html > > Marc-André Lureau (2): > vhost-user: add vhost_user to hold the chr > vhost-user: add slave-req-fd support > > Maxime Coquelin (4): > vhost: propagate errors in vhost_device_iotlb_miss() > vhost: rework IOTLB messaging > vhost: extend ring information update for IOTLB to all rings > spec/vhost-user spec: Add IOMMU support > > docs/specs/vhost-user.txt | 118 ++++++++++++++++++++++++- > hw/virtio/vhost-backend.c | 130 ++++++++++++++++------------ > hw/virtio/vhost-user.c | 177 +++++++++++++++++++++++++++++++++++++- > hw/virtio/vhost.c | 27 ++++-- > include/hw/virtio/vhost-backend.h | 23 +++-- > include/hw/virtio/vhost.h | 2 +- > 6 files changed, 397 insertions(+), 80 deletions(-) > I just noticed I missed the below change in the series. I'll wait v2 is reviewed before posting the v3, or I can post v3 now if you prefer. Regards, Maxime ------------------------------------------------------------------ diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c index 22874a9..e037db6 100644 --- a/hw/net/vhost_net.c +++ b/hw/net/vhost_net.c @@ -77,6 +77,7 @@ static const int user_feature_bits[] = { VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_MRG_RXBUF, VIRTIO_NET_F_MTU, + VIRTIO_F_IOMMU_PLATFORM, /* This bit implies RARP isn't sent by QEMU out of band */ VIRTIO_NET_F_GUEST_ANNOUNCE,