From patchwork Fri May 27 13:00:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 9138339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8BA3B6075C for ; Fri, 27 May 2016 13:18:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7DA6925D91 for ; Fri, 27 May 2016 13:18:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7298827E3D; Fri, 27 May 2016 13:18:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, FSL_HELO_HOME, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 088C225D91 for ; Fri, 27 May 2016 13:18:44 +0000 (UTC) Received: from localhost ([::1]:45776 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6Hf1-0007jQ-4e for patchwork-qemu-devel@patchwork.kernel.org; Fri, 27 May 2016 09:18:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6HNv-0007a7-8m for qemu-devel@nongnu.org; Fri, 27 May 2016 09:01:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6HNq-0001EK-4U for qemu-devel@nongnu.org; Fri, 27 May 2016 09:01:02 -0400 Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]:34471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6HNp-0001E2-S2 for qemu-devel@nongnu.org; Fri, 27 May 2016 09:00:58 -0400 Received: by mail-lb0-x232.google.com with SMTP id sh2so31746236lbb.1 for ; Fri, 27 May 2016 06:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mjD3Dwu7PvwX605c2OnJ8Q6gD3KJY+LQIl7dn64lySw=; b=HdvQZ+zVOGUwlY047oStdep2RM1/bfXqfHeH6qyfvyFWC/0PgEbaNM/1sfi48K45Mb gW1OC9Q0c8cq1lr2YaHhTmTGY8iI2dDmqzdsfTJcrbSlRMlETsNxnKLs/T/Twic/BBZF diAUwJb7MH95Y/9ceBbPiF0ROivEH96nL1JYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mjD3Dwu7PvwX605c2OnJ8Q6gD3KJY+LQIl7dn64lySw=; b=EjR0RZK5iT8pkMh1tf9WAvYQcNOCQPQqYihhOu2x5aDGSJbuwISao7h/s70ZuGmybT UWjple2IMdZOE5YqzZiMR3E4Q3d2WZ986QwXA/bfmDL0KVghnwwx/UWSfmo+NethAi3h EKeaGGoI8cA7JKWpmaNfG66X/WGTOcbBFQq5WX3JHiVXOzMuTnI7CpEtO98RF9oBs/WP 0tWvbxoCSdSiFTsIt+7kqS2B3yIF6yngG/0mVEDeLUFDjsSPjdyWROEf2gBYi2Mk3sw4 n2gwZY5ig+p8i94pKz68My4jNOgAPFc+MYaqoyoU4J1HNU/8AyoFVZ2pUPpNaunWKwej NdVQ== X-Gm-Message-State: ALyK8tL1apvcaUk5QM8UpfXuj8JQaDv0gF6AlzKNNyvR9h6f4D6HTxQdOkoNbKindatwtnXb X-Received: by 10.112.0.240 with SMTP id 16mr4525450lbh.13.1464354056997; Fri, 27 May 2016 06:00:56 -0700 (PDT) Received: from beaming.home (91-157-168-132.elisa-laajakaista.fi. [91.157.168.132]) by smtp.gmail.com with ESMTPSA id n16sm2281066lfg.31.2016.05.27.06.00.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 27 May 2016 06:00:56 -0700 (PDT) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Fri, 27 May 2016 16:00:11 +0300 Message-Id: <4134ecfeb903c362558cb1cb594ff532fd83fb84.1464353863.git.riku.voipio@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::232 Subject: [Qemu-devel] [PULL v2 20/38] linux-user: Support for restarting system calls for Microblaze targets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Timothy E Baldwin Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Timothy E Baldwin Update the Microblaze main loop and sigreturn code: * on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn * set all guest CPU state within signal.c code on sigreturn * handle TARGET_QEMU_ESIGRETURN in the main loop as the indication that the main loop should not touch any guest CPU state Note that this in passing fixes a bug where we were corrupting the guest r[3] on sigreturn with the guest's r[10] because do_sigreturn() was returning env->regs[10] but the register for syscall return values is env->regs[3]. Signed-off-by: Timothy Edward Baldwin Message-id: 1441497448-32489-11-git-send-email-T.E.Baldwin99@members.leeds.ac.uk Reviewed-by: Edgar E. Iglesias Reviewed-by: Peter Maydell [PMM: Commit message tweaks; drop TARGET_USE_ERESTARTSYS define; drop whitespace changes] Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio --- linux-user/main.c | 7 ++++++- linux-user/microblaze/target_signal.h | 1 + linux-user/signal.c | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index c5da418..b2bc6ab 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -2982,7 +2982,12 @@ void cpu_loop(CPUMBState *env) env->regs[9], env->regs[10], 0, 0); - env->regs[3] = ret; + if (ret == -TARGET_ERESTARTSYS) { + /* Wind back to before the syscall. */ + env->sregs[SR_PC] -= 4; + } else if (ret != -TARGET_QEMU_ESIGRETURN) { + env->regs[3] = ret; + } /* All syscall exits result in guest r14 being equal to the * PC we return to, because the kernel syscall exit "rtbd" does * this. (This is true even for sigreturn(); note that r14 is diff --git a/linux-user/microblaze/target_signal.h b/linux-user/microblaze/target_signal.h index 3d1f7a7..acdf3b5 100644 --- a/linux-user/microblaze/target_signal.h +++ b/linux-user/microblaze/target_signal.h @@ -26,4 +26,5 @@ static inline abi_ulong get_sp_from_cpustate(CPUMBState *state) return state->regs[14]; } + #endif /* TARGET_SIGNAL_H */ diff --git a/linux-user/signal.c b/linux-user/signal.c index b4641df..9e85550 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -3618,7 +3618,7 @@ long do_sigreturn(CPUMBState *env) env->regs[14] = env->sregs[SR_PC]; unlock_user_struct(frame, frame_addr, 0); - return env->regs[10]; + return -TARGET_QEMU_ESIGRETURN; badframe: force_sig(TARGET_SIGSEGV); }