From patchwork Mon Feb 15 13:33:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 8315071 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9A0939F372 for ; Mon, 15 Feb 2016 13:33:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D73022017D for ; Mon, 15 Feb 2016 13:33:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7F33201F5 for ; Mon, 15 Feb 2016 13:33:27 +0000 (UTC) Received: from localhost ([::1]:60466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVJHL-00088I-BD for patchwork-qemu-devel@patchwork.kernel.org; Mon, 15 Feb 2016 08:33:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVJH7-00081x-60 for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:33:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVJH3-0008Bs-2S for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:33:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:54804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVJH2-0008Ba-Ne for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:33:09 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9CB12AAB4; Mon, 15 Feb 2016 13:33:06 +0000 (UTC) To: Wei Liu , Paul Durrant References: <20160212191037.GF8818@citrix.com> <3fbbf2a606a14f708655037f5e4fb31e@AMSPEX02CL03.citrite.net> <20160215131621.GL8818@citrix.com> From: Juergen Gross Message-ID: <56C1D391.101@suse.com> Date: Mon, 15 Feb 2016 14:33:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160215131621.GL8818@citrix.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 Cc: "qemu-devel@nongnu.org" , Stefano Stabellini , "aneesh.kumar@linux.vnet.ibm.com" , Anthony Perard , Xen-devel , "gkurz@linux.vnet.ibm.com" Subject: Re: [Qemu-devel] [Xen-devel] RFC: configuring QEMU virtfs for Xen PV(H) guests X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 15/02/16 14:16, Wei Liu wrote: > On Mon, Feb 15, 2016 at 09:07:13AM +0000, Paul Durrant wrote: >>> > [...] >>> # Option 2: Invent a xen-9p device >>> >>> Another way of doing it is to expose a dummy xen-9p device, so that we >>> can use -fsdev XXX -device xen-9p,YYY. This simple device should be >>> used to capture the parameters like mount_tag and fsdev_id, and then >>> chained itself to a known location. Later Xen transport can traverse >>> this known location. This xen-9p device doesn't seem to fit well into >>> the hierarchy. The best I can think of its parent should be >>> TYPE_DEVICE. In this case: >>> >>> 1. Toolstack arranges some xenstore entries. >>> 2. Toolstack arranges command line options for QEMU: >>> -fsdev XXX -device xen-9p,XXX >>> 3. QEMU starts up in xen-attach mode, scans xenstore for relevant >>> entries, then traverses the known location. >>> >>> Downside: Inventing a dummy device looks suboptimal to me. Sorry, didn't notice this thread before. For Xen pvUSB backend in qemu I need a Xen system device acting as parent for being able to attach/detach virtual USB busses. I haven't had time to update my patches for some time, but the patch for this system device is rather easy. It could be used as a parent of the xen-9p devices, too. I've attached the patch for reference. Juergen From 1bc23acf54e60c666b1ec8e3f59c7e5550423e6f Mon Sep 17 00:00:00 2001 From: Juergen Gross Date: Thu, 3 Sep 2015 11:54:50 +0200 Subject: [Patch V1 1/3] xen: introduce dummy system device Introduce a new dummy system device serving as parent for virtual buses. This will enable new pv backends to introduce virtual buses which are removable again opposed to system buses which are meant to stay once added. Signed-off-by: Juergen Gross --- hw/xenpv/xen_machine_pv.c | 39 +++++++++++++++++++++++++++++++++++++++ include/hw/xen/xen_backend.h | 1 + 2 files changed, 40 insertions(+) diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c index 2e545d2..57bc071 100644 --- a/hw/xenpv/xen_machine_pv.c +++ b/hw/xenpv/xen_machine_pv.c @@ -24,10 +24,15 @@ #include "hw/hw.h" #include "hw/boards.h" +#include "hw/sysbus.h" #include "hw/xen/xen_backend.h" #include "xen_domainbuild.h" #include "sysemu/block-backend.h" +#define TYPE_XENSYSDEV "xensysdev" + +DeviceState *xen_sysdev; + static void xen_init_pv(MachineState *machine) { const char *kernel_filename = machine->kernel_filename; @@ -59,6 +64,9 @@ static void xen_init_pv(MachineState *machine) break; } + xen_sysdev = qdev_create(NULL, TYPE_XENSYSDEV); + qdev_init_nofail(xen_sysdev); + xen_be_register("console", &xen_console_ops); xen_be_register("vkbd", &xen_kbdmouse_ops); xen_be_register("vfb", &xen_framebuffer_ops); @@ -93,6 +101,31 @@ static void xen_init_pv(MachineState *machine) xen_init_display(xen_domid); } +static int xen_sysdev_init(SysBusDevice *dev) +{ + return 0; +} + +static Property xen_sysdev_properties[] = { + {/* end of property list */}, +}; + +static void xen_sysdev_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc = DEVICE_CLASS(klass); + SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass); + + k->init = xen_sysdev_init; + dc->props = xen_sysdev_properties; +} + +static const TypeInfo xensysdev_info = { + .name = TYPE_XENSYSDEV, + .parent = TYPE_SYS_BUS_DEVICE, + .instance_size = sizeof(SysBusDevice), + .class_init = xen_sysdev_class_init, +}; + static QEMUMachine xenpv_machine = { .name = "xenpv", .desc = "Xen Para-virtualized PC", @@ -101,9 +134,15 @@ static QEMUMachine xenpv_machine = { .default_machine_opts = "accel=xen", }; +static void xenpv_register_types(void) +{ + type_register_static(&xensysdev_info); +} + static void xenpv_machine_init(void) { qemu_register_machine(&xenpv_machine); } +type_init(xenpv_register_types) machine_init(xenpv_machine_init); diff --git a/include/hw/xen/xen_backend.h b/include/hw/xen/xen_backend.h index 3b4125e..911ba6d 100644 --- a/include/hw/xen/xen_backend.h +++ b/include/hw/xen/xen_backend.h @@ -59,6 +59,7 @@ struct XenDevice { extern XenXC xen_xc; extern struct xs_handle *xenstore; extern const char *xen_protocol; +extern DeviceState *xen_sysdev; /* xenstore helper functions */ int xenstore_write_str(const char *base, const char *node, const char *val); -- 2.1.4