From patchwork Fri Feb 28 18:07:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Babu Moger X-Patchwork-Id: 13996878 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40851C282C6 for ; Fri, 28 Feb 2025 18:08:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1to4mT-0006FC-2N; Fri, 28 Feb 2025 13:08:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1to4mG-0005pp-KG for qemu-devel@nongnu.org; Fri, 28 Feb 2025 13:08:02 -0500 Received: from mail-dm6nam04on20622.outbound.protection.outlook.com ([2a01:111:f403:2409::622] helo=NAM04-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1to4mE-0002Uy-JP for qemu-devel@nongnu.org; Fri, 28 Feb 2025 13:08:00 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=if43fOTNEU9thHkeCwIZNv9ATIT0Y76cTWrbp2mRNkEn4F6p8ZHv21GbdyGpyTIWYP5XdAmLRiaF2gHVkPQMIYXYCTT+6tcOMZA6YqmDtXEFzKEEUjj0LZEhDtz7m+ll6ipe31WmQIG4nYcBD9f9e6fbwdg8QJhSHgl24qDXK8wuHLsv6UgAIap93oJQ3VMGzXKErADCshdOInwT1dF9kLnsOcCj8BxICMYXZ7MXtM0JN6QHW6M/FsvmaG7KrTu56OZLXJmb/AOxxHoLYPoaZkf/b4Aj9/a8QJi0AQETqNUQa6+pQyCaucv0zxex1+3iw6evP4smQ8gGzzrh3d9i4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CpHTQFBSlcBx0vaqV0qTiPHgAgB1EQIBkdtWUxW2+Ug=; b=UVQTsk3tiUzfKaQfHZmDMhgqFlHad0830fZ4k8CZ8Z3DxIcIduPXVkW+C40KyO3UBpXTOsxfM6TgAxjBgKN41OSnzpPUcbI8My8K1QwD7v7rwTNS0HHT2fqq6OtYN/RDk0f1Tjj+IwpACdibETAOvcyVAKKfYszuTe7FXwD8PFH56lMOw5SW0bFQsc8erk+/mAZF+WZ+2PayLo9zN642jhtpqfwLnZxnfjyLK2PrRSKzx1tdcECEULSjxfX7lWdwVnVQHf3ww3u53aAPF/TAXptfpZthNOCh+qDL8248rfXcxr5LspT5aZsSlx10fIi0/yzy3vA0fmH8EuhGhUF9ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CpHTQFBSlcBx0vaqV0qTiPHgAgB1EQIBkdtWUxW2+Ug=; b=morb66GOy7k7Vdj+bRLCfrOJCzyKlQJp8BWKZUVhSva046BRDy94z2ThCBpVjFnPCk3cxO8bvtNvMtqrdPcNSKYai2/19GiuSIXxDcQiIhxNZYZ9gkZavR5vSA/nlf9RyS3+onUvBlT+yUkVqLAwY1KtxkHyGXjkjtV5SMxjn+Y= Received: from BY5PR04CA0024.namprd04.prod.outlook.com (2603:10b6:a03:1d0::34) by PH8PR12MB7232.namprd12.prod.outlook.com (2603:10b6:510:224::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.19; Fri, 28 Feb 2025 18:07:52 +0000 Received: from CY4PEPF0000EE38.namprd03.prod.outlook.com (2603:10b6:a03:1d0:cafe::a3) by BY5PR04CA0024.outlook.office365.com (2603:10b6:a03:1d0::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8489.21 via Frontend Transport; Fri, 28 Feb 2025 18:07:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE38.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8489.16 via Frontend Transport; Fri, 28 Feb 2025 18:07:52 +0000 Received: from bmoger-ubuntu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 28 Feb 2025 12:07:50 -0600 From: Babu Moger To: CC: , , , Subject: [PATCH v6 5/6] target/i386: Update EPYC-Genoa for Cache property, perfmon-v2, RAS and SVM feature bits Date: Fri, 28 Feb 2025 12:07:05 -0600 Message-ID: <6be1c5cbe1717d9d62b30db49fcb480f1e8f9d33.1740766026.git.babu.moger@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE38:EE_|PH8PR12MB7232:EE_ X-MS-Office365-Filtering-Correlation-Id: d9ff6538-24c3-4e11-de79-08dd5822d16a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: HJtSgmYBBYXc8wPLTlW1LnMDgH2ImYYrDE8wLyFwOUDqZzJjoxjz8XuJONuFMzaVLlXUQPSNuAwMC+6GSaGdYc0XJ6/eTSv55etV0u5Pr29yjrqHAD7CyruuqXN9RY3ZMtFnzU5pqSFS+dfMH5/UizGGgBKRxv7H1um3jKrEuBqNAoILEB9ysIxbmSSshv2NU/xts/MiNOALv+d78/f3iPP8tX6y0CWq1xd9K/OzWFzL2wYp0bIjogDdFyLE3Rdj1cAqZVPuOnQ3Us4ylI30EoM51cpOF7ngneIj35vLjWKVWpnnJoZTvvwAD5hh77FdT0MstVF5b16O57AeXOvcA4tAzlWN50Hhmdq3i65EtjyP0JVL6zMLdArxewtKmXxOvIrB2zjj3hxuPRn++E5GpRYEvqdfuw18J7klf/q+5vn1JTp3eBlPAzx86k/WHgf2SmqwBfLvUhYC8jI9w9O9Z3WvoLmM9S+ZX7PbAKvWOTsSDzVsutLBQ6ubATwo/2QfoXc54bsnAWvKxZapBeKHbRbLtme53cXnpbN+v0o8bVq0VAum2gnOJx+uE2x5IVLNXfykb456PescqKmpCDHLaeKZWk56jFm1K5wwyDMLcCc9igdRZiRMql9TjiMhtDqGo7RG/LD5ZylcRM0LTX6rUb9uRovSK1R0AAHPDvxKKp/m+ZhN0q8j1k9wsjHRWjMxzmMNijs5RAT8cUKEAfehwjW4ONROCciQo1JZQhHi0Rk85iPHSOK8Ub5i5E1G0zitRBmh8AkNjvmZCKFkXb1X55QzkMxnkmf8wBfqJtD74UphH7jRUA67WkErnSiBIB/q6fWGtXhUMaT2KuYScsvxQWVYl3duz6GOlfh0A4zml5kgvh6IiFuRGTS14x7cWnK+yNSaYktm1fOnB4lXpfyRElNLYoTELFnugutSDMrNkvjng2ffxyEIJJgTljfy1oFK5cGfKmFqrpEkDZTLHmJWCTFFdzsu6Yxv7oQrrgc9L3njOW63+eHUuLcB6VRYzx5ftfdgEJABvWRycNGveuHYjfGTaumSf8jFUNZSgSem1Fod/HaoSdosVIwhGVzh6s1rdhadVUBp/MInQmeQ7nSUPOgGbq5n80JPsofYj7MopFXpvRRxpjsGB/kX7Y+kdsRvgg/VeW1rIMUkgK1ErHDXpediP/V8xCzzqWnMeKoXBTXXZQUxaRgwF+EHLq+S3ZV+GYiK0cGNwF4ilyYw2xP5f0FOTpMn24TcQpftB9OyYtpbWwj5L9TAGqABUdaUddhcOf9qefju4Ens1JtJ5jEzY/rp5388ps8DJRxfrhx0ZwJxxTqInc/Q45lwAXpB3fYWQSXGhNczZWCH55hiPRxV3kExo5rfOrlHguO/vZfmMYsNohKmWrnPD009TOIVwQUkh9SeeviGpd07RSJtrRo9PvKX10KQN75+z8BgLrc6hWSJwhuN7Jll9294ARuqTRG1 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2025 18:07:52.0490 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9ff6538-24c3-4e11-de79-08dd5822d16a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE38.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7232 Received-SPF: permerror client-ip=2a01:111:f403:2409::622; envelope-from=Babu.Moger@amd.com; helo=NAM04-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.444, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Found that some of the cache properties are not set correctly for EPYC models. l1d_cache.no_invd_sharing should not be true. l1i_cache.no_invd_sharing should not be true. L2.self_init should be true. L2.inclusive should be true. L3.inclusive should not be true. L3.no_invd_sharing should be true. Fix these cache properties. Also add the missing RAS and SVM features bits on AMD EPYC-Genoa model. The SVM feature bits are used in nested guests. perfmon-v2 : Allow guests to make use of the PerfMonV2 features. succor : Software uncorrectable error containment and recovery capability. overflow-recov : MCA overflow recovery support. lbrv : LBR virtualization tsc-scale : MSR based TSC rate control vmcb-clean : VMCB clean bits flushbyasid : Flush by ASID pause-filter : Pause intercept filter pfthreshold : PAUSE filter threshold v-vmsave-vmload: Virtualized VMLOAD and VMSAVE vgif : Virtualized GIF fs-gs-base-ns : WRMSR to {FS,GS,KERNEL_GS}_BASE is non-serializing The feature details are available in APM listed below [1]. [1] AMD64 Architecture Programmer's Manual Volume 2: System Programming Publication # 24593 Revision 3.41. Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537 Signed-off-by: Babu Moger Reviewed-by: Maksim Davydov Reviewed-by: Zhao Liu --- target/i386/cpu.c | 78 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 7a5c5da0f1..b9109b7e79 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -2612,6 +2612,59 @@ static const CPUCaches epyc_genoa_cache_info = { }, }; +static const CPUCaches epyc_genoa_v2_cache_info = { + .l1d_cache = &(CPUCacheInfo) { + .type = DATA_CACHE, + .level = 1, + .size = 32 * KiB, + .line_size = 64, + .associativity = 8, + .partitions = 1, + .sets = 64, + .lines_per_tag = 1, + .self_init = true, + .share_level = CPU_TOPOLOGY_LEVEL_CORE, + }, + .l1i_cache = &(CPUCacheInfo) { + .type = INSTRUCTION_CACHE, + .level = 1, + .size = 32 * KiB, + .line_size = 64, + .associativity = 8, + .partitions = 1, + .sets = 64, + .lines_per_tag = 1, + .self_init = true, + .share_level = CPU_TOPOLOGY_LEVEL_CORE, + }, + .l2_cache = &(CPUCacheInfo) { + .type = UNIFIED_CACHE, + .level = 2, + .size = 1 * MiB, + .line_size = 64, + .associativity = 8, + .partitions = 1, + .sets = 2048, + .lines_per_tag = 1, + .self_init = true, + .inclusive = true, + .share_level = CPU_TOPOLOGY_LEVEL_CORE, + }, + .l3_cache = &(CPUCacheInfo) { + .type = UNIFIED_CACHE, + .level = 3, + .size = 32 * MiB, + .line_size = 64, + .associativity = 16, + .partitions = 1, + .sets = 32768, + .lines_per_tag = 1, + .self_init = true, + .no_invd_sharing = true, + .complex_indexing = false, + .share_level = CPU_TOPOLOGY_LEVEL_DIE, + }, +}; /* The following VMX features are not supported by KVM and are left out in the * CPU definitions: * @@ -5713,6 +5766,31 @@ static const X86CPUDefinition builtin_x86_defs[] = { .xlevel = 0x80000022, .model_id = "AMD EPYC-Genoa Processor", .cache_info = &epyc_genoa_cache_info, + .versions = (X86CPUVersionDefinition[]) { + { .version = 1 }, + { + .version = 2, + .props = (PropValue[]) { + { "overflow-recov", "on" }, + { "succor", "on" }, + { "lbrv", "on" }, + { "tsc-scale", "on" }, + { "vmcb-clean", "on" }, + { "flushbyasid", "on" }, + { "pause-filter", "on" }, + { "pfthreshold", "on" }, + { "v-vmsave-vmload", "on" }, + { "vgif", "on" }, + { "fs-gs-base-ns", "on" }, + { "perfmon-v2", "on" }, + { "model-id", + "AMD EPYC-Genoa-v2 Processor" }, + { /* end of list */ } + }, + .cache_info = &epyc_genoa_v2_cache_info + }, + { /* end of list */ } + } }, };