From patchwork Thu Sep 22 19:12:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nikunj A. Dadhania" X-Patchwork-Id: 9346863 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 34358607D0 for ; Thu, 22 Sep 2016 20:04:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 240C82ACEC for ; Thu, 22 Sep 2016 20:04:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 18DCF2ACEE; Thu, 22 Sep 2016 20:04:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7A4052ACEC for ; Thu, 22 Sep 2016 20:04:15 +0000 (UTC) Received: from localhost ([::1]:59663 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnAEA-0005xr-B0 for patchwork-qemu-devel@patchwork.kernel.org; Thu, 22 Sep 2016 16:04:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn9Qi-0004JJ-3t for qemu-devel@nongnu.org; Thu, 22 Sep 2016 15:13:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bn9Qc-0000w5-D1 for qemu-devel@nongnu.org; Thu, 22 Sep 2016 15:13:07 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40402 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bn9Qc-0000vy-7C for qemu-devel@nongnu.org; Thu, 22 Sep 2016 15:13:02 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8MJCxJi014379 for ; Thu, 22 Sep 2016 15:13:01 -0400 Received: from e28smtp05.in.ibm.com (e28smtp05.in.ibm.com [125.16.236.5]) by mx0b-001b2d01.pphosted.com with ESMTP id 25mjyrxthf-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 22 Sep 2016 15:13:01 -0400 Received: from localhost by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Sep 2016 00:42:18 +0530 Received: from d28dlp03.in.ibm.com (9.184.220.128) by e28smtp05.in.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 23 Sep 2016 00:42:17 +0530 Received: from d28relay09.in.ibm.com (d28relay09.in.ibm.com [9.184.220.160]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id A40261258026; Fri, 23 Sep 2016 00:42:33 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay09.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8MJCFE319398806; Fri, 23 Sep 2016 00:42:15 +0530 Received: from d28av03.in.ibm.com (localhost [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8MJCDFd031138; Fri, 23 Sep 2016 00:42:14 +0530 Received: from abhimanyu.vnet.linux.ibm.com ([9.79.243.19]) by d28av03.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u8MJC9bC030934 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 23 Sep 2016 00:42:12 +0530 From: Nikunj A Dadhania To: Peter Maydell , David Gibson In-Reply-To: <87wpi3omwl.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> References: <1474526262-27011-1-git-send-email-david@gibson.dropbear.id.au> <87wpi3omwl.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Emacs/25.0.94.1 (x86_64-redhat-linux-gnu) Date: Fri, 23 Sep 2016 00:42:09 +0530 MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16092219-0016-0000-0000-000003378684 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16092219-0017-0000-0000-000026774A4F Message-Id: <87ponvoik6.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-09-22_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609220336 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.158.5 Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 00/44] ppc-for-2.8 queue 20160922 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-ppc@nongnu.org" , QEMU Developers Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Nikunj A Dadhania writes: > Peter Maydell writes: > >> On 22 September 2016 at 07:36, David Gibson wrote: >>> The following changes since commit a008535b9fa396226ff9cf78b8ac5f3584bda58e: >>> >>> build-sys: fix make install regression (2016-09-20 11:32:43 +0100) >>> >>> are available in the git repository at: >>> >>> git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20160922 >>> >>> for you to fetch changes up to 2832da4b6fc549d5feb2cf9fe53ad98cee894327: >>> >>> monitor: fix crash for platforms without a CPU 0 (2016-09-22 15:53:01 +1000) >>> >>> ---------------------------------------------------------------- >>> ppc patch queue 2016-09-22 >>> >>> This is my second pull request of ppc and spapr related patches for >>> qemu-2.8. Included here are >>> * TCG implementations for more POWER9 instructions >>> * Some preliminary XICS fixes in preparataion for the pnv machine type >>> * A significant ADB (Macintosh kbd/mouse) cleanup >>> * Some conversions to use trace instead of debug macros >>> * Fixes to correctly handle global TLB flush synchronization in >>> TCG. This is already a bug, but it will have much more impact >>> when we get MTTCG >>> * Add more qtest testcases for Power >>> * Some MAINTAINERS updates >>> * Assorted bugfixes >>> >>> This touches some test files and monitor.c which are technically >>> outside the ppc code, but coming through this tree because the changes >>> are primarily of interest to ppc. >>> >>> ---------------------------------------------------------------- >> >> I'm afraid this fails to build with clang: >> >> /home/petmay01/linaro/qemu-for-merges/target-ppc/translate.c:532:16: >> error: unused function 'L' [-Werro >> r,-Wunused-function] >> EXTRACT_HELPER(L, 16, 2); >> ^ >> 1 error generated. > > +/* darn */ > +static void gen_darn(DisasContext *ctx) > +{ > + int l = L(ctx->opcode); > > Used here, false positive ? It is not a false positive, below would be needed in "[PULL 34/44] target-ppc: implement darn instruction" as gen_darn is within TARGET_PPC64: Regards, Nikunj diff --git a/target-ppc/translate.c b/target-ppc/translate.c index eb681de..4f33915 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -528,8 +528,10 @@ EXTRACT_HELPER(FPW, 16, 1); /* addpcis */ EXTRACT_HELPER_DXFORM(DX, 10, 6, 6, 5, 16, 1, 1, 0, 0) +#if defined(TARGET_PPC64) /* darn */ EXTRACT_HELPER(L, 16, 2); +#endif /*** Jump target decoding ***/ /* Immediate address */