From patchwork Sat Nov 2 21:52:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 13860246 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62EA9E67814 for ; Sat, 2 Nov 2024 21:53:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7M3S-0005Fi-15; Sat, 02 Nov 2024 17:53:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7M3P-0005FG-3P for qemu-devel@nongnu.org; Sat, 02 Nov 2024 17:53:07 -0400 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7M3J-0003tQ-HF for qemu-devel@nongnu.org; Sat, 02 Nov 2024 17:53:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:Date:Cc:To: From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=O+qYEcV6Zo/oc9EEp/w/DPcytGgJzkO9IjpgAtYj+O0=; b=MGXJoxd8P3hpfIACVYMPLRB/BZ KBr1IR3xqoppaJ4XqC6y2PDPE8ZkH9XAFO/t70f/9jIghRLmuzY97PdbisawsnzrfJiBzFAbvhlNw 9oRT2C4JaZKrxaVbbu8ZKC/V6ZbANkPuluUGIVOtsIkcksLXapfECTDQFpKKVJD9COS0M3A2a7jVa zRiF4/dT6gWGXLu+8q3ph4OaxHklFGEini5KI1boyaUsEw7DeFKu2fjGNY7ZfB6xAysTHMSF3vBoK edwT9if9npd7KYn6to6slvTobNDkT7wA3j4H0LeOnCSO31yin/2glmrI8uXQxWsxKJyT+e0+AyyJh zR0JmVRg==; Received: from [52.94.133.142] (helo=edge-m2-r1-128.e-lax51.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1t7M2g-0000000HAoP-31ix; Sat, 02 Nov 2024 21:52:24 +0000 Message-ID: <89955b74d225129d6e3d79b53aa8d81d1b50560f.camel@infradead.org> Subject: [PATCH net-next] ptp: Remove 'default y' for VMCLOCK PTP device From: David Woodhouse To: Jakub Kicinski Cc: Richard Cochran , Peter Hilber , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, "Ridoux, Julien" , virtio-dev@lists.linux.dev, "Luu, Ryan" , "Chashper, David" , "Mohamed Abuelfotoh, Hazem" , Paolo Abeni , "Christopher S . Hall" , Jason Wang , John Stultz , "Michael S . Tsirkin" , netdev@vger.kernel.org, Stephen Boyd , Thomas Gleixner , Xuan Zhuo , Marc Zyngier , Mark Rutland , Daniel Lezcano , Alessandro Zummo , Alexandre Belloni , qemu-devel , Simon Horman Date: Sat, 02 Nov 2024 16:52:17 -0500 User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Received-SPF: none client-ip=2001:8b0:10b:1236::1; envelope-from=BATV+5d56c07513167e53e1a9+7741+infradead.org+dwmw2@casper.srs.infradead.org; helo=casper.infradead.org X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: David Woodhouse The VMCLOCK device gives support for accurate timekeeping even across live migration, unlike the KVM PTP clock. To help ensure that users can always use ptp_vmclock where it's available in preference to ptp_kvm, set it to 'default PTP_1588_CLOCK_VMCLOCK' instead of 'default y'. Signed-off-by: David Woodhouse --- drivers/ptp/Kconfig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index e98c9767e0ef..ed087ae75f0e 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -135,12 +135,16 @@ config PTP_1588_CLOCK_VMCLOCK tristate "Virtual machine PTP clock" depends on X86_TSC || ARM_ARCH_TIMER depends on PTP_1588_CLOCK && ACPI && ARCH_SUPPORTS_INT128 - default y + default PTP_1588_CLOCK_KVM help This driver adds support for using a virtual precision clock advertised by the hypervisor. This clock is only useful in virtual machines where such a device is present. + Unlike the KVM virtual PTP clock, the VMCLOCK device offers support + for reliable timekeeping even across live migration. So this driver + is enabled by default whenever the KVM PTP clock is. + To compile this driver as a module, choose M here: the module will be called ptp_vmclock.