diff mbox series

[3/4] tests/qtest: Fix a comment typo in vhost-user-test.c

Message ID 89d88ee1cab67b8412617e593ea786f1014d737b.1685476786.git.mzamazal@redhat.com (mailing list archive)
State New, archived
Headers show
Series Add SCMI vhost-user VIRTIO device | expand

Commit Message

Milan Zamazal May 24, 2023, 1:34 p.m. UTC 
Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 tests/qtest/vhost-user-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth May 31, 2023, 5:02 a.m. UTC | #1 
On 24/05/2023 15.34, Milan Zamazal wrote:
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> ---
>   tests/qtest/vhost-user-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
> index e4f95b2858..8ab10732f8 100644
> --- a/tests/qtest/vhost-user-test.c
> +++ b/tests/qtest/vhost-user-test.c
> @@ -281,7 +281,7 @@ static void read_guest_mem_server(QTestState *qts, TestServer *s)
>       /* iterate all regions */
>       for (i = 0; i < s->fds_num; i++) {
>   
> -        /* We'll check only the region statring at 0x0*/
> +        /* We'll check only the region starting at 0x0*/

While you're at it, I'd also add a space between the "0x0" and the "*/".

Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>

>           if (s->memory.regions[i].guest_phys_addr != 0x0) {
>               continue;
>           }
Milan Zamazal May 31, 2023, 11:06 a.m. UTC | #2 
Thomas Huth <thuth@redhat.com> writes:

> On 24/05/2023 15.34, Milan Zamazal wrote:
>> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
>> ---
>
>>   tests/qtest/vhost-user-test.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/tests/qtest/vhost-user-test.c
>> b/tests/qtest/vhost-user-test.c
>> index e4f95b2858..8ab10732f8 100644
>> --- a/tests/qtest/vhost-user-test.c
>> +++ b/tests/qtest/vhost-user-test.c
>> @@ -281,7 +281,7 @@ static void read_guest_mem_server(QTestState *qts, TestServer *s)
>>       /* iterate all regions */
>>       for (i = 0; i < s->fds_num; i++) {
>>   -        /* We'll check only the region statring at 0x0*/
>> +        /* We'll check only the region starting at 0x0*/
>
> While you're at it, I'd also add a space between the "0x0" and the "*/".

I'll add it in the next patch iteration, thanks for pointing this out.

> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>>           if (s->memory.regions[i].guest_phys_addr != 0x0) {
>>               continue;
>>           }
diff mbox series

Patch

diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c
index e4f95b2858..8ab10732f8 100644
--- a/tests/qtest/vhost-user-test.c
+++ b/tests/qtest/vhost-user-test.c
@@ -281,7 +281,7 @@  static void read_guest_mem_server(QTestState *qts, TestServer *s)
     /* iterate all regions */
     for (i = 0; i < s->fds_num; i++) {
 
-        /* We'll check only the region statring at 0x0*/
+        /* We'll check only the region starting at 0x0*/
         if (s->memory.regions[i].guest_phys_addr != 0x0) {
             continue;
         }